Uh oh!
There was an error while loading. Please reload this page.
[Flight] Restore original function name in dev, server callstacks served with unsafe-eval - #35650
Merged
Conversation
eps1lon
commented
Jan 28, 2026
| expect(receivedError.message).toEqual( | ||
| 'An error occurred in the Server Components render. The specific message is omitted in production builds to avoid leaking sensitive details. A digest property is included on this error instance which may provide additional details about the nature of the error.', | ||
| ); | ||
| expect(receivedError).not.toHaveProperty('digest'); |
CollaboratorAuthor
There was a problem hiding this comment.
Leaving this here mostly as an interesting observation. When we serialize errors in prod we scrub all sensitive information and say that the digest should be used instead to find the original errors. However, digest is produced from onError which only triggers on thrown errors not errors we pass as props.
Comparing: 87ae75b...374b794 Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: (No significant changes) |
eps1lon
marked this pull request as ready for review
January 28, 2026 14:52
ForwardRef doesn't try-catch either
unstubbable
approved these changes
Jan 28, 2026
unsafe-evalUh oh!
There was an error while loading. Please reload this page.
eps1lon
deleted the
sebbie/01-28-_flight_restore_original_function_name_in_dev_server_callstacks_served_with_unsafe-eval_
branch
January 28, 2026 17:41
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #29671
React uses
evalwith React Server Components to create fake stacks (e.g. to reconstruct Server stacks). In CSP environments,evalmay not be available unlessunsafe-evalis set.We already degraded gracefully without
evalwithout restoring the function name. We can restore the function name though. Usually we use{[name]: (_) => _()}but that is badly minified by Closure. The usual trick to usebindproduces bad names though e.g.function a() {}would now have the nameObject.a.Instead we define the
nameon the function. This doesn't work everywhere either. This should be acceptable since we're already in fallback mode and try-catch in case of even more misconfigured environments.How did you test this change?