Uh oh!
There was an error while loading. Please reload this page.
Fix context propagation through suspended Suspense boundaries - #35839
Merged
Conversation
acdlite
marked this pull request as ready for review
February 21, 2026 02:01
Comparing: b16b768...adbadd0 Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: Expand to show
|
acdlite
marked this pull request as draft
February 21, 2026 02:06
acdliteforce-pushed
the
fix-context-suspended-suspense
branch
from
February 21, 2026 02:16
02815c5 to
a744a53Compareacdlite
marked this pull request as ready for review
February 21, 2026 02:20
When a Suspense boundary suspends during initial mount, the primary children's fibers are discarded because there is no current tree to preserve them. If the suspended promise never resolves, the only way to retry is something external like a context change. However, lazy context propagation could not find the consumer fibers — they no longer exist in the tree — so the Suspense boundary was never marked for retry and remained stuck in fallback state indefinitely. The fix teaches context propagation to conservatively mark suspended Suspense boundaries for retry when a parent context changes, even when the consumer fibers can't be found. This matches the existing conservative approach used for dehydrated (SSR) Suspense boundaries.
acdliteforce-pushed
the
fix-context-suspended-suspense
branch
from
February 21, 2026 02:22
a744a53 to
adbadd0Compareeps1lon
approved these changes
Feb 21, 2026
Uh oh!
There was an error while loading. Please reload this page.
github-actionsBot
pushed a commit
that referenced
this pull request
Feb 21, 2026
When a Suspense boundary suspends during initial mount, the primary children's fibers are discarded because there is no current tree to preserve them. If the suspended promise never resolves, the only way to retry is something external like a context change. However, lazy context propagation could not find the consumer fibers — they no longer exist in the tree — so the Suspense boundary was never marked for retry and remained stuck in fallback state indefinitely. The fix teaches context propagation to conservatively mark suspended Suspense boundaries for retry when a parent context changes, even when the consumer fibers can't be found. This matches the existing conservative approach used for dehydrated (SSR) Suspense boundaries. DiffTrain build for [ab18f33](ab18f33)
github-actionsBot
pushed a commit
that referenced
this pull request
Feb 21, 2026
When a Suspense boundary suspends during initial mount, the primary children's fibers are discarded because there is no current tree to preserve them. If the suspended promise never resolves, the only way to retry is something external like a context change. However, lazy context propagation could not find the consumer fibers — they no longer exist in the tree — so the Suspense boundary was never marked for retry and remained stuck in fallback state indefinitely. The fix teaches context propagation to conservatively mark suspended Suspense boundaries for retry when a parent context changes, even when the consumer fibers can't be found. This matches the existing conservative approach used for dehydrated (SSR) Suspense boundaries. DiffTrain build for [ab18f33](ab18f33)
github-actionsBot
pushed a commit
to code/lib-react
that referenced
this pull request
Feb 22, 2026
…35839) When a Suspense boundary suspends during initial mount, the primary children's fibers are discarded because there is no current tree to preserve them. If the suspended promise never resolves, the only way to retry is something external like a context change. However, lazy context propagation could not find the consumer fibers — they no longer exist in the tree — so the Suspense boundary was never marked for retry and remained stuck in fallback state indefinitely. The fix teaches context propagation to conservatively mark suspended Suspense boundaries for retry when a parent context changes, even when the consumer fibers can't be found. This matches the existing conservative approach used for dehydrated (SSR) Suspense boundaries. DiffTrain build for [ab18f33](react@ab18f33)
github-actionsBot
pushed a commit
to code/lib-react
that referenced
this pull request
Feb 22, 2026
…35839) When a Suspense boundary suspends during initial mount, the primary children's fibers are discarded because there is no current tree to preserve them. If the suspended promise never resolves, the only way to retry is something external like a context change. However, lazy context propagation could not find the consumer fibers — they no longer exist in the tree — so the Suspense boundary was never marked for retry and remained stuck in fallback state indefinitely. The fix teaches context propagation to conservatively mark suspended Suspense boundaries for retry when a parent context changes, even when the consumer fibers can't be found. This matches the existing conservative approach used for dehydrated (SSR) Suspense boundaries. DiffTrain build for [ab18f33](react@ab18f33)
tonyrosario added a commit
to What-We-Will/community-platform
that referenced
this pull request
May 28, 2026
…ush) Typing pauses navigate via router.replace (no new history entry per debounce). Enter or blur calls commitSearch via router.push, short-circuiting when the value hasn't changed. Tests cover: in-progress text not clobbered by unrelated URL change, Enter commits via push, debounced typing uses replace not push. Adds e2e/members/search.spec.ts as a skipped suite. URL assertions under Playwright currently fail because App Router silently skips pushState (vercel/next.js#83386, fixed by react/react#35839). The fix ships in Next.js 16.2.0+ via bundled React canary; this project is on Next 16.1.6 -- unskip after the bump. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
tonyrosario added a commit
to What-We-Will/community-platform
that referenced
this pull request
May 28, 2026
…ush) Browser history should reflect intentional searches the user committed to, not every debounce pause. Typing replaces; Enter/blur push. Two refs (lastUrlQ, lastCommittedQ) because one couldn't carry both signals: external-nav sync needs to know our writes, but commitSearch needs to dedupe only against the last push. A single shared ref made Enter after a debounce-replace look like a duplicate and silently drop the history entry. updateFilter captures the live input value because searchParams is stale by the time skill/referrals change; without it, in-progress typing gets clobbered. e2e suite is skipped pending Next 16.2.0+ (vercel/next.js#83386, fixed by react/react#35839). Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
tonyrosario added a commit
to What-We-Will/community-platform
that referenced
this pull request
Jun 1, 2026
…ush) Browser history should reflect intentional searches the user committed to, not every debounce pause. Typing replaces; Enter/blur push. Two refs (lastUrlQ, lastCommittedQ) because one couldn't carry both signals: external-nav sync needs to know our writes, but commitSearch needs to dedupe only against the last push. A single shared ref made Enter after a debounce-replace look like a duplicate and silently drop the history entry. updateFilter captures the live input value because searchParams is stale by the time skill/referrals change; without it, in-progress typing gets clobbered. e2e suite is skipped pending Next 16.2.0+ (vercel/next.js#83386, fixed by react/react#35839). Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Kananel0 pushed a commit
to Kananel0/react
that referenced
this pull request
Aug 18, 2026
Kananel0 pushed a commit
to Kananel0/react
that referenced
this pull request
Aug 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a Suspense boundary suspends during initial mount, the primary children's fibers are discarded because there is no current tree to preserve them. If the suspended promise never resolves, the only way to retry is something external like a context change. However, lazy context propagation could not find the consumer fibers — they no longer exist in the tree — so the Suspense boundary was never marked for retry and remained stuck in fallback state indefinitely.
The fix teaches context propagation to conservatively mark suspended Suspense boundaries for retry when a parent context changes, even when the consumer fibers can't be found. This matches the existing conservative approach used for dehydrated (SSR) Suspense boundaries.