Skip to content

[RN] Fix timeStamp property of SyntheticEvent in React Native - #35912

Merged
rubennorte merged 1 commit into
react:mainfrom
rubennorte:correct-event-timestamps
Feb 26, 2026
Merged

[RN] Fix timeStamp property of SyntheticEvent in React Native#35912
rubennorte merged 1 commit into
react:mainfrom
rubennorte:correct-event-timestamps

Conversation

@rubennorte

@rubennorterubennorte commented Feb 26, 2026

Copy link
Copy Markdown
Member

Summary

This fixes the semantics of the timeStamp property of events in React Native.

Currently, most events just assign Date.now() (at the time of creating the event object in JavaScript) as the timeStamp property. This is a divergence with Web and most native platforms, that use a monotonic timestamp for the value (on Web, the same timestamp provided by performance.now()).

Additionally, many native events specify a timestamp in the event data object as timestamp and gets ignored by the logic in JS as it only looks at properties named timeStamp specifically (camel case).

This PR fixes both issues by:

  1. Using performance.now() instead of Date.now() by default (if available).
  2. Checking for a timestamp property before falling back to the default (apart from timeStamp).

How did you test this change?

Added unit tests for verify the new behavior.

@react-sizebot

react-sizebot commented Feb 26, 2026

Copy link
Copy Markdown

Comparing: 074d96b...eec2df2

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name+/-BaseCurrent+/- gzipBase gzipCurrent gzip
oss-stable/react-dom/cjs/react-dom.production.js=6.84 kB6.84 kB=1.88 kB1.88 kB
oss-stable/react-dom/cjs/react-dom-client.production.js=611.76 kB611.76 kB=108.10 kB108.10 kB
oss-experimental/react-dom/cjs/react-dom.production.js=6.84 kB6.84 kB=1.88 kB1.88 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js=677.69 kB677.69 kB=119.07 kB119.06 kB
facebook-www/ReactDOM-prod.classic.js=697.89 kB697.89 kB=122.63 kB122.63 kB
facebook-www/ReactDOM-prod.modern.js=688.21 kB688.21 kB=121.01 kB121.01 kB

Significant size changes

Includes any change greater than 0.2%:

(No significant changes)

Generated by 🚫 dangerJS against eec2df2

@rubennorte
rubennorte merged commit a48e9e3 into react:mainFeb 26, 2026
235 of 241 checks passed
@rubennorte
rubennorte deleted the correct-event-timestamps branch February 26, 2026 15:51
github-actionsBot pushed a commit that referenced this pull request Feb 26, 2026
@rubennorte
[RN] Fix timeStamp property of SyntheticEvent in React Native (#35912)
510aa60
## Summary
This fixes the semantics of the `timeStamp` property of events in React
Native.
Currently, most events just assign `Date.now()` (at the time of creating
the event object in JavaScript) as the `timeStamp` property. This is a
divergence with Web and most native platforms, that use a monotonic
timestamp for the value (on Web, the same timestamp provided by
`performance.now()`).
Additionally, many native events specify a timestamp in the event data
object as `timestamp` and gets ignored by the logic in JS as it only
looks at properties named `timeStamp` specifically (camel case).
This PR fixes both issues by:
1. Using `performance.now()` instead of `Date.now()` by default (if
available).
2. Checking for a `timestamp` property before falling back to the
default (apart from `timeStamp`).
## How did you test this change?
Added unit tests for verify the new behavior.
DiffTrain build for [a48e9e3](a48e9e3)
@nextjs-botnextjs-bot mentioned this pull request Feb 26, 2026
Merged
emmaeng700 added a commit to emmaeng700/react that referenced this pull request Feb 26, 2026
@emmaeng700
fix: don't double-invoke effects for moved children in StrictMode
a2b2040
In StrictMode, `doubleInvokeEffectsInDEVIfNecessary` fires for any
fiber that has the `PlacementDEV` flag set. Previously, `placeChild`
set `PlacementDEV` on both newly inserted fibers AND fibers that were
moved to a different position in an array.
This caused a regression in React 19: when a keyed child is reordered
within an array, its effects are re-run in dev/StrictMode even when
dependencies are empty `[]`. The same component in production, or in
React 18, correctly skips effect re-runs for moves.
The fix is to only set `PlacementDEV` for actual insertions (where
`current === null`). Moved fibers (`current !== null`, `oldIndex <
lastPlacedIndex`) still receive the `Placement` flag so the host node
is correctly repositioned in the DOM, but StrictMode no longer treats
them as new mounts.
Also fix unused `ref3` variable in ReactFabric-test.internal.js
introduced in react#35912 (copy-paste: third View used ref2 instead of ref3).
Fixesreact#32561
@rubennorterubennorte mentioned this pull request Mar 3, 2026
Merged
rubennorte added a commit that referenced this pull request Mar 3, 2026
@rubennorte
Add support for event information in React scheduler tracks in React …
4cc5b7a
…Native (#35947)
## Summary
This defines the same fiber configuration for RN as used in DOM, so we
can expose event timing information in the React scheduler tracks in
performance traces.
This was unblocked by #35913 and #35912.
## How did you test this change?
Manually compiled the renderer and tested e2e in FB infra: <img width="1217" height="161" alt="Screenshot 2026-03-03 at 10 10 44"
src="https://github.com/user-attachments/assets/6ca1512e-dcaf-49cf-8da9-1c6ae554733a"
/>
github-actionsBot pushed a commit that referenced this pull request Mar 3, 2026
@rubennorte
Add support for event information in React scheduler tracks in React …
809350a
…Native (#35947)
## Summary
This defines the same fiber configuration for RN as used in DOM, so we
can expose event timing information in the React scheduler tracks in
performance traces.
This was unblocked by #35913 and #35912.
## How did you test this change?
Manually compiled the renderer and tested e2e in FB infra:
<img width="1217" height="161" alt="Screenshot 2026-03-03 at 10 10 44"
src="https://github.com/user-attachments/assets/6ca1512e-dcaf-49cf-8da9-1c6ae554733a"
/>
DiffTrain build for [4cc5b7a](4cc5b7a)
github-actionsBot pushed a commit to code/lib-react that referenced this pull request Mar 7, 2026
@pull
Add support for event information in React scheduler tracks in React …
da8969c
…Native (react#35947)
## Summary
This defines the same fiber configuration for RN as used in DOM, so we
can expose event timing information in the React scheduler tracks in
performance traces.
This was unblocked by react#35913 and react#35912.
## How did you test this change?
Manually compiled the renderer and tested e2e in FB infra:
<img width="1217" height="161" alt="Screenshot 2026-03-03 at 10 10 44"
src="https://github.com/user-attachments/assets/6ca1512e-dcaf-49cf-8da9-1c6ae554733a"
/>
DiffTrain build for [4cc5b7a](react@4cc5b7a)
github-actionsBot pushed a commit to code/lib-react that referenced this pull request Mar 7, 2026
@pull
Add support for event information in React scheduler tracks in React …
8ede614
…Native (react#35947)
## Summary
This defines the same fiber configuration for RN as used in DOM, so we
can expose event timing information in the React scheduler tracks in
performance traces.
This was unblocked by react#35913 and react#35912.
## How did you test this change?
Manually compiled the renderer and tested e2e in FB infra:
<img width="1217" height="161" alt="Screenshot 2026-03-03 at 10 10 44"
src="https://github.com/user-attachments/assets/6ca1512e-dcaf-49cf-8da9-1c6ae554733a"
/>
DiffTrain build for [4cc5b7a](react@4cc5b7a)
@rubennorterubennorte mentioned this pull request Jun 5, 2026
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@javachejavachejavache approved these changes
@sammy-SCsammy-SCAwaiting requested review from sammy-SC
@huntiehuntieAwaiting requested review from huntie
@cipolleschicipolleschiAwaiting requested review from cipolleschi

Assignees

No one assigned

Labels

CLA Signed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rubennorte@react-sizebot@javache
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
[RN] Fix timeStamp property of SyntheticEvent in React Native by rubennorte · Pull Request #35912 · react/react · GitHub
Skip to content
[RN] Fix timeStamp property of SyntheticEvent in React Native - #35912
Merged
rubennorte merged 1 commit into
react:mainfrom 
rubennorte:correct-event-timestamps
Feb 26, 2026
Merged
[RN] Fix timeStamp property of SyntheticEvent in React Native#35912
rubennorte merged 1 commit into
react:mainfrom 
rubennorte:correct-event-timestamps
Conversation
@rubennorte
@rubennorterubennorte
commented
Feb 26, 2026

Copy link


Copy Markdown

Member
Summary
This fixes the semantics of the timeStamp property of events in React Native.
Currently, most events just assign Date.now() (at the time of creating the event object in JavaScript) as the timeStamp property. This is a divergence with Web and most native platforms, that use a monotonic timestamp for the value (on Web, the same timestamp provided by performance.now()).
Additionally, many native events specify a timestamp in the event data object as timestamp and gets ignored by the logic in JS as it only looks at properties named timeStamp specifically (camel case).
This PR fixes both issues by:
  1. Using performance.now() instead of Date.now() by default (if available).
  2. Checking for a timestamp property before falling back to the default (apart from timeStamp).
How did you test this change?
Added unit tests for verify the new behavior.
@react-sizebot
react-sizebot
commented
Feb 26, 2026

Copy link


Copy Markdown

Comparing: 074d96b...eec2df2
Critical size changes
Includes critical production bundles, as well as any change greater than 2%:
Name+/-BaseCurrent+/- gzipBase gzipCurrent gzip
oss-stable/react-dom/cjs/react-dom.production.js=6.84 kB6.84 kB=1.88 kB1.88 kB
oss-stable/react-dom/cjs/react-dom-client.production.js=611.76 kB611.76 kB=108.10 kB108.10 kB
oss-experimental/react-dom/cjs/react-dom.production.js=6.84 kB6.84 kB=1.88 kB1.88 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js=677.69 kB677.69 kB=119.07 kB119.06 kB
facebook-www/ReactDOM-prod.classic.js=697.89 kB697.89 kB=122.63 kB122.63 kB
facebook-www/ReactDOM-prod.modern.js=688.21 kB688.21 kB=121.01 kB121.01 kB
Significant size changes
Includes any change greater than 0.2%:
(No significant changes)

Generated by 🚫 dangerJS against eec2df2
@rubennorte
rubennorte
merged commit a48e9e3
into
react:mainFeb 26, 2026

235 of 241 checks passed

@rubennorte
rubennorte
deleted the

correct-event-timestamps

branch
February 26, 2026 15:51
github-actionsBot
pushed a commit
that referenced
this pull request
Feb 26, 2026
@rubennorte
[RN] Fix timeStamp property of SyntheticEvent in React Native (#35912)
510aa60
## Summary
This fixes the semantics of the `timeStamp` property of events in React
Native.
Currently, most events just assign `Date.now()` (at the time of creating
the event object in JavaScript) as the `timeStamp` property. This is a
divergence with Web and most native platforms, that use a monotonic
timestamp for the value (on Web, the same timestamp provided by
`performance.now()`).
Additionally, many native events specify a timestamp in the event data
object as `timestamp` and gets ignored by the logic in JS as it only
looks at properties named `timeStamp` specifically (camel case).
This PR fixes both issues by:
1. Using `performance.now()` instead of `Date.now()` by default (if
available).
2. Checking for a `timestamp` property before falling back to the
default (apart from `timeStamp`).
## How did you test this change?
Added unit tests for verify the new behavior.
DiffTrain build for [a48e9e3](a48e9e3)
@nextjs-botnextjs-bot
mentioned this pull request
Feb 26, 2026
 Merged

emmaeng700 added a commit
to emmaeng700/react
that referenced
this pull request
Feb 26, 2026
@emmaeng700
fix: don't double-invoke effects for moved children in StrictMode
a2b2040
In StrictMode, `doubleInvokeEffectsInDEVIfNecessary` fires for any
fiber that has the `PlacementDEV` flag set. Previously, `placeChild`
set `PlacementDEV` on both newly inserted fibers AND fibers that were
moved to a different position in an array.
This caused a regression in React 19: when a keyed child is reordered
within an array, its effects are re-run in dev/StrictMode even when
dependencies are empty `[]`. The same component in production, or in
React 18, correctly skips effect re-runs for moves.
The fix is to only set `PlacementDEV` for actual insertions (where
`current === null`). Moved fibers (`current !== null`, `oldIndex <
lastPlacedIndex`) still receive the `Placement` flag so the host node
is correctly repositioned in the DOM, but StrictMode no longer treats
them as new mounts.
Also fix unused `ref3` variable in ReactFabric-test.internal.js
introduced in react#35912 (copy-paste: third View used ref2 instead of ref3).
Fixesreact#32561
@rubennorterubennorte
mentioned this pull request
Mar 3, 2026
 Merged

rubennorte added a commit
that referenced
this pull request
Mar 3, 2026
@rubennorte
Add support for event information in React scheduler tracks in React …
4cc5b7a
…Native (#35947)
## Summary
This defines the same fiber configuration for RN as used in DOM, so we
can expose event timing information in the React scheduler tracks in
performance traces.
This was unblocked by #35913 and #35912.
## How did you test this change?
Manually compiled the renderer and tested e2e in FB infra: <img width="1217" height="161" alt="Screenshot 2026-03-03 at 10 10 44"
src="https://github.com/user-attachments/assets/6ca1512e-dcaf-49cf-8da9-1c6ae554733a"
/>
github-actionsBot
pushed a commit
that referenced
this pull request
Mar 3, 2026
@rubennorte
Add support for event information in React scheduler tracks in React …
809350a
…Native (#35947)
## Summary
This defines the same fiber configuration for RN as used in DOM, so we
can expose event timing information in the React scheduler tracks in
performance traces.
This was unblocked by #35913 and #35912.
## How did you test this change?
Manually compiled the renderer and tested e2e in FB infra:
<img width="1217" height="161" alt="Screenshot 2026-03-03 at 10 10 44"
src="https://github.com/user-attachments/assets/6ca1512e-dcaf-49cf-8da9-1c6ae554733a"
/>
DiffTrain build for [4cc5b7a](4cc5b7a)
github-actionsBot
pushed a commit
to code/lib-react
that referenced
this pull request
Mar 7, 2026
@pull
Add support for event information in React scheduler tracks in React …
da8969c
…Native (react#35947)
## Summary
This defines the same fiber configuration for RN as used in DOM, so we
can expose event timing information in the React scheduler tracks in
performance traces.
This was unblocked by react#35913 and react#35912.
## How did you test this change?
Manually compiled the renderer and tested e2e in FB infra:
<img width="1217" height="161" alt="Screenshot 2026-03-03 at 10 10 44"
src="https://github.com/user-attachments/assets/6ca1512e-dcaf-49cf-8da9-1c6ae554733a"
/>
DiffTrain build for [4cc5b7a](react@4cc5b7a)
github-actionsBot
pushed a commit
to code/lib-react
that referenced
this pull request
Mar 7, 2026
@pull
Add support for event information in React scheduler tracks in React …
8ede614
…Native (react#35947)
## Summary
This defines the same fiber configuration for RN as used in DOM, so we
can expose event timing information in the React scheduler tracks in
performance traces.
This was unblocked by react#35913 and react#35912.
## How did you test this change?
Manually compiled the renderer and tested e2e in FB infra:
<img width="1217" height="161" alt="Screenshot 2026-03-03 at 10 10 44"
src="https://github.com/user-attachments/assets/6ca1512e-dcaf-49cf-8da9-1c6ae554733a"
/>
DiffTrain build for [4cc5b7a](react@4cc5b7a)
@rubennorterubennorte
mentioned this pull request
Jun 5, 2026
 Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@javachejavachejavache approved these changes
@sammy-SCsammy-SCAwaiting requested review from sammy-SC
@huntiehuntieAwaiting requested review from huntie
@cipolleschicipolleschiAwaiting requested review from cipolleschi

Assignees


No one assigned


Labels

CLA Signed

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@rubennorte@react-sizebot@javache

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
[RN] Fix timeStamp property of SyntheticEvent in React Native by rubennorte · Pull Request #35912 · react/react · GitHub
Skip to content
[RN] Fix timeStamp property of SyntheticEvent in React Native - #35912
Merged
rubennorte merged 1 commit into
react:mainfrom 
rubennorte:correct-event-timestamps
Feb 26, 2026
Merged
[RN] Fix timeStamp property of SyntheticEvent in React Native#35912
rubennorte merged 1 commit into
react:mainfrom 
rubennorte:correct-event-timestamps
Conversation
@rubennorte
@rubennorterubennorte
commented
Feb 26, 2026

Copy link


Copy Markdown

Member
Summary
This fixes the semantics of the timeStamp property of events in React Native.
Currently, most events just assign Date.now() (at the time of creating the event object in JavaScript) as the timeStamp property. This is a divergence with Web and most native platforms, that use a monotonic timestamp for the value (on Web, the same timestamp provided by performance.now()).
Additionally, many native events specify a timestamp in the event data object as timestamp and gets ignored by the logic in JS as it only looks at properties named timeStamp specifically (camel case).
This PR fixes both issues by:
  1. Using performance.now() instead of Date.now() by default (if available).
  2. Checking for a timestamp property before falling back to the default (apart from timeStamp).
How did you test this change?
Added unit tests for verify the new behavior.
@react-sizebot
react-sizebot
commented
Feb 26, 2026

Copy link


Copy Markdown

Comparing: 074d96b...eec2df2
Critical size changes
Includes critical production bundles, as well as any change greater than 2%:
Name+/-BaseCurrent+/- gzipBase gzipCurrent gzip
oss-stable/react-dom/cjs/react-dom.production.js=6.84 kB6.84 kB=1.88 kB1.88 kB
oss-stable/react-dom/cjs/react-dom-client.production.js=611.76 kB611.76 kB=108.10 kB108.10 kB
oss-experimental/react-dom/cjs/react-dom.production.js=6.84 kB6.84 kB=1.88 kB1.88 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js=677.69 kB677.69 kB=119.07 kB119.06 kB
facebook-www/ReactDOM-prod.classic.js=697.89 kB697.89 kB=122.63 kB122.63 kB
facebook-www/ReactDOM-prod.modern.js=688.21 kB688.21 kB=121.01 kB121.01 kB
Significant size changes
Includes any change greater than 0.2%:
(No significant changes)

Generated by 🚫 dangerJS against eec2df2
@rubennorte
rubennorte
merged commit a48e9e3
into
react:mainFeb 26, 2026

235 of 241 checks passed

@rubennorte
rubennorte
deleted the

correct-event-timestamps

branch
February 26, 2026 15:51
github-actionsBot
pushed a commit
that referenced
this pull request
Feb 26, 2026
@rubennorte
[RN] Fix timeStamp property of SyntheticEvent in React Native (#35912)
510aa60
## Summary
This fixes the semantics of the `timeStamp` property of events in React
Native.
Currently, most events just assign `Date.now()` (at the time of creating
the event object in JavaScript) as the `timeStamp` property. This is a
divergence with Web and most native platforms, that use a monotonic
timestamp for the value (on Web, the same timestamp provided by
`performance.now()`).
Additionally, many native events specify a timestamp in the event data
object as `timestamp` and gets ignored by the logic in JS as it only
looks at properties named `timeStamp` specifically (camel case).
This PR fixes both issues by:
1. Using `performance.now()` instead of `Date.now()` by default (if
available).
2. Checking for a `timestamp` property before falling back to the
default (apart from `timeStamp`).
## How did you test this change?
Added unit tests for verify the new behavior.
DiffTrain build for [a48e9e3](a48e9e3)
@nextjs-botnextjs-bot
mentioned this pull request
Feb 26, 2026
 Merged

emmaeng700 added a commit
to emmaeng700/react
that referenced
this pull request
Feb 26, 2026
@emmaeng700
fix: don't double-invoke effects for moved children in StrictMode
a2b2040
In StrictMode, `doubleInvokeEffectsInDEVIfNecessary` fires for any
fiber that has the `PlacementDEV` flag set. Previously, `placeChild`
set `PlacementDEV` on both newly inserted fibers AND fibers that were
moved to a different position in an array.
This caused a regression in React 19: when a keyed child is reordered
within an array, its effects are re-run in dev/StrictMode even when
dependencies are empty `[]`. The same component in production, or in
React 18, correctly skips effect re-runs for moves.
The fix is to only set `PlacementDEV` for actual insertions (where
`current === null`). Moved fibers (`current !== null`, `oldIndex <
lastPlacedIndex`) still receive the `Placement` flag so the host node
is correctly repositioned in the DOM, but StrictMode no longer treats
them as new mounts.
Also fix unused `ref3` variable in ReactFabric-test.internal.js
introduced in react#35912 (copy-paste: third View used ref2 instead of ref3).
Fixesreact#32561
@rubennorterubennorte
mentioned this pull request
Mar 3, 2026
 Merged

rubennorte added a commit
that referenced
this pull request
Mar 3, 2026
@rubennorte
Add support for event information in React scheduler tracks in React …
4cc5b7a
…Native (#35947)
## Summary
This defines the same fiber configuration for RN as used in DOM, so we
can expose event timing information in the React scheduler tracks in
performance traces.
This was unblocked by #35913 and #35912.
## How did you test this change?
Manually compiled the renderer and tested e2e in FB infra: <img width="1217" height="161" alt="Screenshot 2026-03-03 at 10 10 44"
src="https://github.com/user-attachments/assets/6ca1512e-dcaf-49cf-8da9-1c6ae554733a"
/>
github-actionsBot
pushed a commit
that referenced
this pull request
Mar 3, 2026
@rubennorte
Add support for event information in React scheduler tracks in React …
809350a
…Native (#35947)
## Summary
This defines the same fiber configuration for RN as used in DOM, so we
can expose event timing information in the React scheduler tracks in
performance traces.
This was unblocked by #35913 and #35912.
## How did you test this change?
Manually compiled the renderer and tested e2e in FB infra:
<img width="1217" height="161" alt="Screenshot 2026-03-03 at 10 10 44"
src="https://github.com/user-attachments/assets/6ca1512e-dcaf-49cf-8da9-1c6ae554733a"
/>
DiffTrain build for [4cc5b7a](4cc5b7a)
github-actionsBot
pushed a commit
to code/lib-react
that referenced
this pull request
Mar 7, 2026
@pull
Add support for event information in React scheduler tracks in React …
da8969c
…Native (react#35947)
## Summary
This defines the same fiber configuration for RN as used in DOM, so we
can expose event timing information in the React scheduler tracks in
performance traces.
This was unblocked by react#35913 and react#35912.
## How did you test this change?
Manually compiled the renderer and tested e2e in FB infra:
<img width="1217" height="161" alt="Screenshot 2026-03-03 at 10 10 44"
src="https://github.com/user-attachments/assets/6ca1512e-dcaf-49cf-8da9-1c6ae554733a"
/>
DiffTrain build for [4cc5b7a](react@4cc5b7a)
github-actionsBot
pushed a commit
to code/lib-react
that referenced
this pull request
Mar 7, 2026
@pull
Add support for event information in React scheduler tracks in React …
8ede614
…Native (react#35947)
## Summary
This defines the same fiber configuration for RN as used in DOM, so we
can expose event timing information in the React scheduler tracks in
performance traces.
This was unblocked by react#35913 and react#35912.
## How did you test this change?
Manually compiled the renderer and tested e2e in FB infra:
<img width="1217" height="161" alt="Screenshot 2026-03-03 at 10 10 44"
src="https://github.com/user-attachments/assets/6ca1512e-dcaf-49cf-8da9-1c6ae554733a"
/>
DiffTrain build for [4cc5b7a](react@4cc5b7a)
@rubennorterubennorte
mentioned this pull request
Jun 5, 2026
 Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@javachejavachejavache approved these changes
@sammy-SCsammy-SCAwaiting requested review from sammy-SC
@huntiehuntieAwaiting requested review from huntie
@cipolleschicipolleschiAwaiting requested review from cipolleschi

Assignees


No one assigned


Labels

CLA Signed

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@rubennorte@react-sizebot@javache

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
[RN] Fix timeStamp property of SyntheticEvent in React Native by rubennorte · Pull Request #35912 · react/react · GitHub
Skip to content
[RN] Fix timeStamp property of SyntheticEvent in React Native - #35912
Merged
rubennorte merged 1 commit into
react:mainfrom 
rubennorte:correct-event-timestamps
Feb 26, 2026
Merged
[RN] Fix timeStamp property of SyntheticEvent in React Native#35912
rubennorte merged 1 commit into
react:mainfrom 
rubennorte:correct-event-timestamps
Conversation
@rubennorte
@rubennorterubennorte
commented
Feb 26, 2026

Copy link


Copy Markdown

Member
Summary
This fixes the semantics of the timeStamp property of events in React Native.
Currently, most events just assign Date.now() (at the time of creating the event object in JavaScript) as the timeStamp property. This is a divergence with Web and most native platforms, that use a monotonic timestamp for the value (on Web, the same timestamp provided by performance.now()).
Additionally, many native events specify a timestamp in the event data object as timestamp and gets ignored by the logic in JS as it only looks at properties named timeStamp specifically (camel case).
This PR fixes both issues by:
  1. Using performance.now() instead of Date.now() by default (if available).
  2. Checking for a timestamp property before falling back to the default (apart from timeStamp).
How did you test this change?
Added unit tests for verify the new behavior.
@react-sizebot
react-sizebot
commented
Feb 26, 2026

Copy link


Copy Markdown

Comparing: 074d96b...eec2df2
Critical size changes
Includes critical production bundles, as well as any change greater than 2%:
Name+/-BaseCurrent+/- gzipBase gzipCurrent gzip
oss-stable/react-dom/cjs/react-dom.production.js=6.84 kB6.84 kB=1.88 kB1.88 kB
oss-stable/react-dom/cjs/react-dom-client.production.js=611.76 kB611.76 kB=108.10 kB108.10 kB
oss-experimental/react-dom/cjs/react-dom.production.js=6.84 kB6.84 kB=1.88 kB1.88 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js=677.69 kB677.69 kB=119.07 kB119.06 kB
facebook-www/ReactDOM-prod.classic.js=697.89 kB697.89 kB=122.63 kB122.63 kB
facebook-www/ReactDOM-prod.modern.js=688.21 kB688.21 kB=121.01 kB121.01 kB
Significant size changes
Includes any change greater than 0.2%:
(No significant changes)

Generated by 🚫 dangerJS against eec2df2
@rubennorte
rubennorte
merged commit a48e9e3
into
react:mainFeb 26, 2026

235 of 241 checks passed

@rubennorte
rubennorte
deleted the

correct-event-timestamps

branch
February 26, 2026 15:51
github-actionsBot
pushed a commit
that referenced
this pull request
Feb 26, 2026
@rubennorte
[RN] Fix timeStamp property of SyntheticEvent in React Native (#35912)
510aa60
## Summary
This fixes the semantics of the `timeStamp` property of events in React
Native.
Currently, most events just assign `Date.now()` (at the time of creating
the event object in JavaScript) as the `timeStamp` property. This is a
divergence with Web and most native platforms, that use a monotonic
timestamp for the value (on Web, the same timestamp provided by
`performance.now()`).
Additionally, many native events specify a timestamp in the event data
object as `timestamp` and gets ignored by the logic in JS as it only
looks at properties named `timeStamp` specifically (camel case).
This PR fixes both issues by:
1. Using `performance.now()` instead of `Date.now()` by default (if
available).
2. Checking for a `timestamp` property before falling back to the
default (apart from `timeStamp`).
## How did you test this change?
Added unit tests for verify the new behavior.
DiffTrain build for [a48e9e3](a48e9e3)
@nextjs-botnextjs-bot
mentioned this pull request
Feb 26, 2026
 Merged

emmaeng700 added a commit
to emmaeng700/react
that referenced
this pull request
Feb 26, 2026
@emmaeng700
fix: don't double-invoke effects for moved children in StrictMode
a2b2040
In StrictMode, `doubleInvokeEffectsInDEVIfNecessary` fires for any
fiber that has the `PlacementDEV` flag set. Previously, `placeChild`
set `PlacementDEV` on both newly inserted fibers AND fibers that were
moved to a different position in an array.
This caused a regression in React 19: when a keyed child is reordered
within an array, its effects are re-run in dev/StrictMode even when
dependencies are empty `[]`. The same component in production, or in
React 18, correctly skips effect re-runs for moves.
The fix is to only set `PlacementDEV` for actual insertions (where
`current === null`). Moved fibers (`current !== null`, `oldIndex <
lastPlacedIndex`) still receive the `Placement` flag so the host node
is correctly repositioned in the DOM, but StrictMode no longer treats
them as new mounts.
Also fix unused `ref3` variable in ReactFabric-test.internal.js
introduced in react#35912 (copy-paste: third View used ref2 instead of ref3).
Fixesreact#32561
@rubennorterubennorte
mentioned this pull request
Mar 3, 2026
 Merged

rubennorte added a commit
that referenced
this pull request
Mar 3, 2026
@rubennorte
Add support for event information in React scheduler tracks in React …
4cc5b7a
…Native (#35947)
## Summary
This defines the same fiber configuration for RN as used in DOM, so we
can expose event timing information in the React scheduler tracks in
performance traces.
This was unblocked by #35913 and #35912.
## How did you test this change?
Manually compiled the renderer and tested e2e in FB infra: <img width="1217" height="161" alt="Screenshot 2026-03-03 at 10 10 44"
src="https://github.com/user-attachments/assets/6ca1512e-dcaf-49cf-8da9-1c6ae554733a"
/>
github-actionsBot
pushed a commit
that referenced
this pull request
Mar 3, 2026
@rubennorte
Add support for event information in React scheduler tracks in React …
809350a
…Native (#35947)
## Summary
This defines the same fiber configuration for RN as used in DOM, so we
can expose event timing information in the React scheduler tracks in
performance traces.
This was unblocked by #35913 and #35912.
## How did you test this change?
Manually compiled the renderer and tested e2e in FB infra:
<img width="1217" height="161" alt="Screenshot 2026-03-03 at 10 10 44"
src="https://github.com/user-attachments/assets/6ca1512e-dcaf-49cf-8da9-1c6ae554733a"
/>
DiffTrain build for [4cc5b7a](4cc5b7a)
github-actionsBot
pushed a commit
to code/lib-react
that referenced
this pull request
Mar 7, 2026
@pull
Add support for event information in React scheduler tracks in React …
da8969c
…Native (react#35947)
## Summary
This defines the same fiber configuration for RN as used in DOM, so we
can expose event timing information in the React scheduler tracks in
performance traces.
This was unblocked by react#35913 and react#35912.
## How did you test this change?
Manually compiled the renderer and tested e2e in FB infra:
<img width="1217" height="161" alt="Screenshot 2026-03-03 at 10 10 44"
src="https://github.com/user-attachments/assets/6ca1512e-dcaf-49cf-8da9-1c6ae554733a"
/>
DiffTrain build for [4cc5b7a](react@4cc5b7a)
github-actionsBot
pushed a commit
to code/lib-react
that referenced
this pull request
Mar 7, 2026
@pull
Add support for event information in React scheduler tracks in React …
8ede614
…Native (react#35947)
## Summary
This defines the same fiber configuration for RN as used in DOM, so we
can expose event timing information in the React scheduler tracks in
performance traces.
This was unblocked by react#35913 and react#35912.
## How did you test this change?
Manually compiled the renderer and tested e2e in FB infra:
<img width="1217" height="161" alt="Screenshot 2026-03-03 at 10 10 44"
src="https://github.com/user-attachments/assets/6ca1512e-dcaf-49cf-8da9-1c6ae554733a"
/>
DiffTrain build for [4cc5b7a](react@4cc5b7a)
@rubennorterubennorte
mentioned this pull request
Jun 5, 2026
 Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@javachejavachejavache approved these changes
@sammy-SCsammy-SCAwaiting requested review from sammy-SC
@huntiehuntieAwaiting requested review from huntie
@cipolleschicipolleschiAwaiting requested review from cipolleschi

Assignees


No one assigned


Labels

CLA Signed

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@rubennorte@react-sizebot@javache

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '
[RN] Fix timeStamp property of SyntheticEvent in React Native by rubennorte · Pull Request #35912 · react/react · GitHub
Skip to content
[RN] Fix timeStamp property of SyntheticEvent in React Native - #35912
Merged
rubennorte merged 1 commit into
react:mainfrom 
rubennorte:correct-event-timestamps
Feb 26, 2026
Merged
[RN] Fix timeStamp property of SyntheticEvent in React Native#35912
rubennorte merged 1 commit into
react:mainfrom 
rubennorte:correct-event-timestamps
Conversation
@rubennorte
@rubennorterubennorte
commented
Feb 26, 2026

Copy link


Copy Markdown

Member
Summary
This fixes the semantics of the timeStamp property of events in React Native.
Currently, most events just assign Date.now() (at the time of creating the event object in JavaScript) as the timeStamp property. This is a divergence with Web and most native platforms, that use a monotonic timestamp for the value (on Web, the same timestamp provided by performance.now()).
Additionally, many native events specify a timestamp in the event data object as timestamp and gets ignored by the logic in JS as it only looks at properties named timeStamp specifically (camel case).
This PR fixes both issues by:
  1. Using performance.now() instead of Date.now() by default (if available).
  2. Checking for a timestamp property before falling back to the default (apart from timeStamp).
How did you test this change?
Added unit tests for verify the new behavior.
@react-sizebot
react-sizebot
commented
Feb 26, 2026

Copy link


Copy Markdown

Comparing: 074d96b...eec2df2
Critical size changes
Includes critical production bundles, as well as any change greater than 2%:
Name+/-BaseCurrent+/- gzipBase gzipCurrent gzip
oss-stable/react-dom/cjs/react-dom.production.js=6.84 kB6.84 kB=1.88 kB1.88 kB
oss-stable/react-dom/cjs/react-dom-client.production.js=611.76 kB611.76 kB=108.10 kB108.10 kB
oss-experimental/react-dom/cjs/react-dom.production.js=6.84 kB6.84 kB=1.88 kB1.88 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js=677.69 kB677.69 kB=119.07 kB119.06 kB
facebook-www/ReactDOM-prod.classic.js=697.89 kB697.89 kB=122.63 kB122.63 kB
facebook-www/ReactDOM-prod.modern.js=688.21 kB688.21 kB=121.01 kB121.01 kB
Significant size changes
Includes any change greater than 0.2%:
(No significant changes)

Generated by 🚫 dangerJS against eec2df2
@rubennorte
rubennorte
merged commit a48e9e3
into
react:mainFeb 26, 2026

235 of 241 checks passed

@rubennorte
rubennorte
deleted the

correct-event-timestamps

branch
February 26, 2026 15:51
github-actionsBot
pushed a commit
that referenced
this pull request
Feb 26, 2026
@rubennorte
[RN] Fix timeStamp property of SyntheticEvent in React Native (#35912)
510aa60
## Summary
This fixes the semantics of the `timeStamp` property of events in React
Native.
Currently, most events just assign `Date.now()` (at the time of creating
the event object in JavaScript) as the `timeStamp` property. This is a
divergence with Web and most native platforms, that use a monotonic
timestamp for the value (on Web, the same timestamp provided by
`performance.now()`).
Additionally, many native events specify a timestamp in the event data
object as `timestamp` and gets ignored by the logic in JS as it only
looks at properties named `timeStamp` specifically (camel case).
This PR fixes both issues by:
1. Using `performance.now()` instead of `Date.now()` by default (if
available).
2. Checking for a `timestamp` property before falling back to the
default (apart from `timeStamp`).
## How did you test this change?
Added unit tests for verify the new behavior.
DiffTrain build for [a48e9e3](a48e9e3)
@nextjs-botnextjs-bot
mentioned this pull request
Feb 26, 2026
 Merged

emmaeng700 added a commit
to emmaeng700/react
that referenced
this pull request
Feb 26, 2026
@emmaeng700
fix: don't double-invoke effects for moved children in StrictMode
a2b2040
In StrictMode, `doubleInvokeEffectsInDEVIfNecessary` fires for any
fiber that has the `PlacementDEV` flag set. Previously, `placeChild`
set `PlacementDEV` on both newly inserted fibers AND fibers that were
moved to a different position in an array.
This caused a regression in React 19: when a keyed child is reordered
within an array, its effects are re-run in dev/StrictMode even when
dependencies are empty `[]`. The same component in production, or in
React 18, correctly skips effect re-runs for moves.
The fix is to only set `PlacementDEV` for actual insertions (where
`current === null`). Moved fibers (`current !== null`, `oldIndex <
lastPlacedIndex`) still receive the `Placement` flag so the host node
is correctly repositioned in the DOM, but StrictMode no longer treats
them as new mounts.
Also fix unused `ref3` variable in ReactFabric-test.internal.js
introduced in react#35912 (copy-paste: third View used ref2 instead of ref3).
Fixesreact#32561
@rubennorterubennorte
mentioned this pull request
Mar 3, 2026
 Merged

rubennorte added a commit
that referenced
this pull request
Mar 3, 2026
@rubennorte
Add support for event information in React scheduler tracks in React …
4cc5b7a
…Native (#35947)
## Summary
This defines the same fiber configuration for RN as used in DOM, so we
can expose event timing information in the React scheduler tracks in
performance traces.
This was unblocked by #35913 and #35912.
## How did you test this change?
Manually compiled the renderer and tested e2e in FB infra: <img width="1217" height="161" alt="Screenshot 2026-03-03 at 10 10 44"
src="https://github.com/user-attachments/assets/6ca1512e-dcaf-49cf-8da9-1c6ae554733a"
/>
github-actionsBot
pushed a commit
that referenced
this pull request
Mar 3, 2026
@rubennorte
Add support for event information in React scheduler tracks in React …
809350a
…Native (#35947)
## Summary
This defines the same fiber configuration for RN as used in DOM, so we
can expose event timing information in the React scheduler tracks in
performance traces.
This was unblocked by #35913 and #35912.
## How did you test this change?
Manually compiled the renderer and tested e2e in FB infra:
<img width="1217" height="161" alt="Screenshot 2026-03-03 at 10 10 44"
src="https://github.com/user-attachments/assets/6ca1512e-dcaf-49cf-8da9-1c6ae554733a"
/>
DiffTrain build for [4cc5b7a](4cc5b7a)
github-actionsBot
pushed a commit
to code/lib-react
that referenced
this pull request
Mar 7, 2026
@pull
Add support for event information in React scheduler tracks in React …
da8969c
…Native (react#35947)
## Summary
This defines the same fiber configuration for RN as used in DOM, so we
can expose event timing information in the React scheduler tracks in
performance traces.
This was unblocked by react#35913 and react#35912.
## How did you test this change?
Manually compiled the renderer and tested e2e in FB infra:
<img width="1217" height="161" alt="Screenshot 2026-03-03 at 10 10 44"
src="https://github.com/user-attachments/assets/6ca1512e-dcaf-49cf-8da9-1c6ae554733a"
/>
DiffTrain build for [4cc5b7a](react@4cc5b7a)
github-actionsBot
pushed a commit
to code/lib-react
that referenced
this pull request
Mar 7, 2026
@pull
Add support for event information in React scheduler tracks in React …
8ede614
…Native (react#35947)
## Summary
This defines the same fiber configuration for RN as used in DOM, so we
can expose event timing information in the React scheduler tracks in
performance traces.
This was unblocked by react#35913 and react#35912.
## How did you test this change?
Manually compiled the renderer and tested e2e in FB infra:
<img width="1217" height="161" alt="Screenshot 2026-03-03 at 10 10 44"
src="https://github.com/user-attachments/assets/6ca1512e-dcaf-49cf-8da9-1c6ae554733a"
/>
DiffTrain build for [4cc5b7a](react@4cc5b7a)
@rubennorterubennorte
mentioned this pull request
Jun 5, 2026
 Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@javachejavachejavache approved these changes
@sammy-SCsammy-SCAwaiting requested review from sammy-SC
@huntiehuntieAwaiting requested review from huntie
@cipolleschicipolleschiAwaiting requested review from cipolleschi

Assignees


No one assigned


Labels

CLA Signed

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@rubennorte@react-sizebot@javache

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
[RN] Fix timeStamp property of SyntheticEvent in React Native by rubennorte · Pull Request #35912 · react/react · GitHub
Skip to content
[RN] Fix timeStamp property of SyntheticEvent in React Native - #35912
Merged
rubennorte merged 1 commit into
react:mainfrom 
rubennorte:correct-event-timestamps
Feb 26, 2026
Merged
[RN] Fix timeStamp property of SyntheticEvent in React Native#35912
rubennorte merged 1 commit into
react:mainfrom 
rubennorte:correct-event-timestamps
Conversation
@rubennorte
@rubennorterubennorte
commented
Feb 26, 2026

Copy link


Copy Markdown

Member
Summary
This fixes the semantics of the timeStamp property of events in React Native.
Currently, most events just assign Date.now() (at the time of creating the event object in JavaScript) as the timeStamp property. This is a divergence with Web and most native platforms, that use a monotonic timestamp for the value (on Web, the same timestamp provided by performance.now()).
Additionally, many native events specify a timestamp in the event data object as timestamp and gets ignored by the logic in JS as it only looks at properties named timeStamp specifically (camel case).
This PR fixes both issues by:
  1. Using performance.now() instead of Date.now() by default (if available).
  2. Checking for a timestamp property before falling back to the default (apart from timeStamp).
How did you test this change?
Added unit tests for verify the new behavior.
@react-sizebot
react-sizebot
commented
Feb 26, 2026

Copy link


Copy Markdown

Comparing: 074d96b...eec2df2
Critical size changes
Includes critical production bundles, as well as any change greater than 2%:
Name+/-BaseCurrent+/- gzipBase gzipCurrent gzip
oss-stable/react-dom/cjs/react-dom.production.js=6.84 kB6.84 kB=1.88 kB1.88 kB
oss-stable/react-dom/cjs/react-dom-client.production.js=611.76 kB611.76 kB=108.10 kB108.10 kB
oss-experimental/react-dom/cjs/react-dom.production.js=6.84 kB6.84 kB=1.88 kB1.88 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js=677.69 kB677.69 kB=119.07 kB119.06 kB
facebook-www/ReactDOM-prod.classic.js=697.89 kB697.89 kB=122.63 kB122.63 kB
facebook-www/ReactDOM-prod.modern.js=688.21 kB688.21 kB=121.01 kB121.01 kB
Significant size changes
Includes any change greater than 0.2%:
(No significant changes)

Generated by 🚫 dangerJS against eec2df2
@rubennorte
rubennorte
merged commit a48e9e3
into
react:mainFeb 26, 2026

235 of 241 checks passed

@rubennorte
rubennorte
deleted the

correct-event-timestamps

branch
February 26, 2026 15:51
github-actionsBot
pushed a commit
that referenced
this pull request
Feb 26, 2026
@rubennorte
[RN] Fix timeStamp property of SyntheticEvent in React Native (#35912)
510aa60
## Summary
This fixes the semantics of the `timeStamp` property of events in React
Native.
Currently, most events just assign `Date.now()` (at the time of creating
the event object in JavaScript) as the `timeStamp` property. This is a
divergence with Web and most native platforms, that use a monotonic
timestamp for the value (on Web, the same timestamp provided by
`performance.now()`).
Additionally, many native events specify a timestamp in the event data
object as `timestamp` and gets ignored by the logic in JS as it only
looks at properties named `timeStamp` specifically (camel case).
This PR fixes both issues by:
1. Using `performance.now()` instead of `Date.now()` by default (if
available).
2. Checking for a `timestamp` property before falling back to the
default (apart from `timeStamp`).
## How did you test this change?
Added unit tests for verify the new behavior.
DiffTrain build for [a48e9e3](a48e9e3)
@nextjs-botnextjs-bot
mentioned this pull request
Feb 26, 2026
 Merged

emmaeng700 added a commit
to emmaeng700/react
that referenced
this pull request
Feb 26, 2026
@emmaeng700
fix: don't double-invoke effects for moved children in StrictMode
a2b2040
In StrictMode, `doubleInvokeEffectsInDEVIfNecessary` fires for any
fiber that has the `PlacementDEV` flag set. Previously, `placeChild`
set `PlacementDEV` on both newly inserted fibers AND fibers that were
moved to a different position in an array.
This caused a regression in React 19: when a keyed child is reordered
within an array, its effects are re-run in dev/StrictMode even when
dependencies are empty `[]`. The same component in production, or in
React 18, correctly skips effect re-runs for moves.
The fix is to only set `PlacementDEV` for actual insertions (where
`current === null`). Moved fibers (`current !== null`, `oldIndex <
lastPlacedIndex`) still receive the `Placement` flag so the host node
is correctly repositioned in the DOM, but StrictMode no longer treats
them as new mounts.
Also fix unused `ref3` variable in ReactFabric-test.internal.js
introduced in react#35912 (copy-paste: third View used ref2 instead of ref3).
Fixesreact#32561
@rubennorterubennorte
mentioned this pull request
Mar 3, 2026
 Merged

rubennorte added a commit
that referenced
this pull request
Mar 3, 2026
@rubennorte
Add support for event information in React scheduler tracks in React …
4cc5b7a
…Native (#35947)
## Summary
This defines the same fiber configuration for RN as used in DOM, so we
can expose event timing information in the React scheduler tracks in
performance traces.
This was unblocked by #35913 and #35912.
## How did you test this change?
Manually compiled the renderer and tested e2e in FB infra: <img width="1217" height="161" alt="Screenshot 2026-03-03 at 10 10 44"
src="https://github.com/user-attachments/assets/6ca1512e-dcaf-49cf-8da9-1c6ae554733a"
/>
github-actionsBot
pushed a commit
that referenced
this pull request
Mar 3, 2026
@rubennorte
Add support for event information in React scheduler tracks in React …
809350a
…Native (#35947)
## Summary
This defines the same fiber configuration for RN as used in DOM, so we
can expose event timing information in the React scheduler tracks in
performance traces.
This was unblocked by #35913 and #35912.
## How did you test this change?
Manually compiled the renderer and tested e2e in FB infra:
<img width="1217" height="161" alt="Screenshot 2026-03-03 at 10 10 44"
src="https://github.com/user-attachments/assets/6ca1512e-dcaf-49cf-8da9-1c6ae554733a"
/>
DiffTrain build for [4cc5b7a](4cc5b7a)
github-actionsBot
pushed a commit
to code/lib-react
that referenced
this pull request
Mar 7, 2026
@pull
Add support for event information in React scheduler tracks in React …
da8969c
…Native (react#35947)
## Summary
This defines the same fiber configuration for RN as used in DOM, so we
can expose event timing information in the React scheduler tracks in
performance traces.
This was unblocked by react#35913 and react#35912.
## How did you test this change?
Manually compiled the renderer and tested e2e in FB infra:
<img width="1217" height="161" alt="Screenshot 2026-03-03 at 10 10 44"
src="https://github.com/user-attachments/assets/6ca1512e-dcaf-49cf-8da9-1c6ae554733a"
/>
DiffTrain build for [4cc5b7a](react@4cc5b7a)
github-actionsBot
pushed a commit
to code/lib-react
that referenced
this pull request
Mar 7, 2026
@pull
Add support for event information in React scheduler tracks in React …
8ede614
…Native (react#35947)
## Summary
This defines the same fiber configuration for RN as used in DOM, so we
can expose event timing information in the React scheduler tracks in
performance traces.
This was unblocked by react#35913 and react#35912.
## How did you test this change?
Manually compiled the renderer and tested e2e in FB infra:
<img width="1217" height="161" alt="Screenshot 2026-03-03 at 10 10 44"
src="https://github.com/user-attachments/assets/6ca1512e-dcaf-49cf-8da9-1c6ae554733a"
/>
DiffTrain build for [4cc5b7a](react@4cc5b7a)
@rubennorterubennorte
mentioned this pull request
Jun 5, 2026
 Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@javachejavachejavache approved these changes
@sammy-SCsammy-SCAwaiting requested review from sammy-SC
@huntiehuntieAwaiting requested review from huntie
@cipolleschicipolleschiAwaiting requested review from cipolleschi

Assignees


No one assigned


Labels

CLA Signed

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@rubennorte@react-sizebot@javache

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
[RN] Fix timeStamp property of SyntheticEvent in React Native by rubennorte · Pull Request #35912 · react/react · GitHub
Skip to content
[RN] Fix timeStamp property of SyntheticEvent in React Native - #35912
Merged
rubennorte merged 1 commit into
react:mainfrom 
rubennorte:correct-event-timestamps
Feb 26, 2026
Merged
[RN] Fix timeStamp property of SyntheticEvent in React Native#35912
rubennorte merged 1 commit into
react:mainfrom 
rubennorte:correct-event-timestamps
Conversation
@rubennorte
@rubennorterubennorte
commented
Feb 26, 2026

Copy link


Copy Markdown

Member
Summary
This fixes the semantics of the timeStamp property of events in React Native.
Currently, most events just assign Date.now() (at the time of creating the event object in JavaScript) as the timeStamp property. This is a divergence with Web and most native platforms, that use a monotonic timestamp for the value (on Web, the same timestamp provided by performance.now()).
Additionally, many native events specify a timestamp in the event data object as timestamp and gets ignored by the logic in JS as it only looks at properties named timeStamp specifically (camel case).
This PR fixes both issues by:
  1. Using performance.now() instead of Date.now() by default (if available).
  2. Checking for a timestamp property before falling back to the default (apart from timeStamp).
How did you test this change?
Added unit tests for verify the new behavior.
@react-sizebot
react-sizebot
commented
Feb 26, 2026

Copy link


Copy Markdown

Comparing: 074d96b...eec2df2
Critical size changes
Includes critical production bundles, as well as any change greater than 2%:
Name+/-BaseCurrent+/- gzipBase gzipCurrent gzip
oss-stable/react-dom/cjs/react-dom.production.js=6.84 kB6.84 kB=1.88 kB1.88 kB
oss-stable/react-dom/cjs/react-dom-client.production.js=611.76 kB611.76 kB=108.10 kB108.10 kB
oss-experimental/react-dom/cjs/react-dom.production.js=6.84 kB6.84 kB=1.88 kB1.88 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js=677.69 kB677.69 kB=119.07 kB119.06 kB
facebook-www/ReactDOM-prod.classic.js=697.89 kB697.89 kB=122.63 kB122.63 kB
facebook-www/ReactDOM-prod.modern.js=688.21 kB688.21 kB=121.01 kB121.01 kB
Significant size changes
Includes any change greater than 0.2%:
(No significant changes)

Generated by 🚫 dangerJS against eec2df2
@rubennorte
rubennorte
merged commit a48e9e3
into
react:mainFeb 26, 2026

235 of 241 checks passed

@rubennorte
rubennorte
deleted the

correct-event-timestamps

branch
February 26, 2026 15:51
github-actionsBot
pushed a commit
that referenced
this pull request
Feb 26, 2026
@rubennorte
[RN] Fix timeStamp property of SyntheticEvent in React Native (#35912)
510aa60
## Summary
This fixes the semantics of the `timeStamp` property of events in React
Native.
Currently, most events just assign `Date.now()` (at the time of creating
the event object in JavaScript) as the `timeStamp` property. This is a
divergence with Web and most native platforms, that use a monotonic
timestamp for the value (on Web, the same timestamp provided by
`performance.now()`).
Additionally, many native events specify a timestamp in the event data
object as `timestamp` and gets ignored by the logic in JS as it only
looks at properties named `timeStamp` specifically (camel case).
This PR fixes both issues by:
1. Using `performance.now()` instead of `Date.now()` by default (if
available).
2. Checking for a `timestamp` property before falling back to the
default (apart from `timeStamp`).
## How did you test this change?
Added unit tests for verify the new behavior.
DiffTrain build for [a48e9e3](a48e9e3)
@nextjs-botnextjs-bot
mentioned this pull request
Feb 26, 2026
 Merged

emmaeng700 added a commit
to emmaeng700/react
that referenced
this pull request
Feb 26, 2026
@emmaeng700
fix: don't double-invoke effects for moved children in StrictMode
a2b2040
In StrictMode, `doubleInvokeEffectsInDEVIfNecessary` fires for any
fiber that has the `PlacementDEV` flag set. Previously, `placeChild`
set `PlacementDEV` on both newly inserted fibers AND fibers that were
moved to a different position in an array.
This caused a regression in React 19: when a keyed child is reordered
within an array, its effects are re-run in dev/StrictMode even when
dependencies are empty `[]`. The same component in production, or in
React 18, correctly skips effect re-runs for moves.
The fix is to only set `PlacementDEV` for actual insertions (where
`current === null`). Moved fibers (`current !== null`, `oldIndex <
lastPlacedIndex`) still receive the `Placement` flag so the host node
is correctly repositioned in the DOM, but StrictMode no longer treats
them as new mounts.
Also fix unused `ref3` variable in ReactFabric-test.internal.js
introduced in react#35912 (copy-paste: third View used ref2 instead of ref3).
Fixesreact#32561
@rubennorterubennorte
mentioned this pull request
Mar 3, 2026
 Merged

rubennorte added a commit
that referenced
this pull request
Mar 3, 2026
@rubennorte
Add support for event information in React scheduler tracks in React …
4cc5b7a
…Native (#35947)
## Summary
This defines the same fiber configuration for RN as used in DOM, so we
can expose event timing information in the React scheduler tracks in
performance traces.
This was unblocked by #35913 and #35912.
## How did you test this change?
Manually compiled the renderer and tested e2e in FB infra: <img width="1217" height="161" alt="Screenshot 2026-03-03 at 10 10 44"
src="https://github.com/user-attachments/assets/6ca1512e-dcaf-49cf-8da9-1c6ae554733a"
/>
github-actionsBot
pushed a commit
that referenced
this pull request
Mar 3, 2026
@rubennorte
Add support for event information in React scheduler tracks in React …
809350a
…Native (#35947)
## Summary
This defines the same fiber configuration for RN as used in DOM, so we
can expose event timing information in the React scheduler tracks in
performance traces.
This was unblocked by #35913 and #35912.
## How did you test this change?
Manually compiled the renderer and tested e2e in FB infra:
<img width="1217" height="161" alt="Screenshot 2026-03-03 at 10 10 44"
src="https://github.com/user-attachments/assets/6ca1512e-dcaf-49cf-8da9-1c6ae554733a"
/>
DiffTrain build for [4cc5b7a](4cc5b7a)
github-actionsBot
pushed a commit
to code/lib-react
that referenced
this pull request
Mar 7, 2026
@pull
Add support for event information in React scheduler tracks in React …
da8969c
…Native (react#35947)
## Summary
This defines the same fiber configuration for RN as used in DOM, so we
can expose event timing information in the React scheduler tracks in
performance traces.
This was unblocked by react#35913 and react#35912.
## How did you test this change?
Manually compiled the renderer and tested e2e in FB infra:
<img width="1217" height="161" alt="Screenshot 2026-03-03 at 10 10 44"
src="https://github.com/user-attachments/assets/6ca1512e-dcaf-49cf-8da9-1c6ae554733a"
/>
DiffTrain build for [4cc5b7a](react@4cc5b7a)
github-actionsBot
pushed a commit
to code/lib-react
that referenced
this pull request
Mar 7, 2026
@pull
Add support for event information in React scheduler tracks in React …
8ede614
…Native (react#35947)
## Summary
This defines the same fiber configuration for RN as used in DOM, so we
can expose event timing information in the React scheduler tracks in
performance traces.
This was unblocked by react#35913 and react#35912.
## How did you test this change?
Manually compiled the renderer and tested e2e in FB infra:
<img width="1217" height="161" alt="Screenshot 2026-03-03 at 10 10 44"
src="https://github.com/user-attachments/assets/6ca1512e-dcaf-49cf-8da9-1c6ae554733a"
/>
DiffTrain build for [4cc5b7a](react@4cc5b7a)
@rubennorterubennorte
mentioned this pull request
Jun 5, 2026
 Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@javachejavachejavache approved these changes
@sammy-SCsammy-SCAwaiting requested review from sammy-SC
@huntiehuntieAwaiting requested review from huntie
@cipolleschicipolleschiAwaiting requested review from cipolleschi

Assignees


No one assigned


Labels

CLA Signed

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@rubennorte@react-sizebot@javache

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Universal Dark Mode - works on any site
(function() {
var enabled = true;
function applyDarkMode() {
if (!enabled) return;
// Create style element if it doesn't exist
var style = document.getElementById('universal-dark-mode-style');
if (!style) {
style = document.createElement('style');
style.id = 'universal-dark-mode-style';
document.head.appendChild(style);
}
// Dark mode CSS - inverts colors but preserves images/video
style.textContent = '
/* Invert everything except media */
html {
filter: invert(1) hue-rotate(180deg) !important;
background: #1a1a2e !important;
}
/* Restore images, videos, iframes, canvas */
img, video, iframe, canvas, svg, picture, [style*="background-image"] {
filter: invert(1) hue-rotate(180deg) !important;
}
/* Preserve specific elements that should not be inverted */
.no-dark-mode, .no-dark-mode *,
[data-theme="light"], [data-theme="light"],
.ace_editor, .ace_editor *,
.CodeMirror, .CodeMirror *,
.monaco-editor, .monaco-editor *,
.markdown-body pre, .markdown-body pre *,
.highlight, .highlight *,
pre code, pre code * {
filter: none !important;
}
/* Fix common UI elements */
.modal, .popup, .dropdown-menu, .tooltip, .popover {
filter: invert(1) hue-rotate(180deg) !important;
background: #2d2d44 !important;
border-color: #444 !important;
}
/* Scrollbars */
::-webkit-scrollbar { background: #1a1a2e !important; }
::-webkit-scrollbar-thumb { background: #444 !important; }
::-webkit-scrollbar-thumb:hover { background: #555 !important; }
/* Selection */
::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
';
}
function removeDarkMode() {
var style = document.getElementById('universal-dark-mode-style');
if (style) style.remove();
}
// Toggle with Alt+Shift+D
document.addEventListener('keydown', function(e) {
if (e.altKey && e.shiftKey && e.key === 'D') {
e.preventDefault();
enabled = !enabled;
if (enabled) {
applyDarkMode();
console.log('[Universal Dark Mode] Enabled');
} else {
removeDarkMode();
console.log('[Universal Dark Mode] Disabled');
}
}
});
// Apply on load
applyDarkMode();
// Re-apply on dynamic content
var observer = new MutationObserver(function(mutations) {
if (enabled && !document.getElementById('universal-dark-mode-style')) {
applyDarkMode();
}
});
observer.observe(document.head, { childList: true });
console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');
})();
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();
[RN] Fix timeStamp property of SyntheticEvent in React Native by rubennorte · Pull Request #35912 · react/react · GitHub
Skip to content
[RN] Fix timeStamp property of SyntheticEvent in React Native - #35912
Merged
rubennorte merged 1 commit into
react:mainfrom 
rubennorte:correct-event-timestamps
Feb 26, 2026
Merged
[RN] Fix timeStamp property of SyntheticEvent in React Native#35912
rubennorte merged 1 commit into
react:mainfrom 
rubennorte:correct-event-timestamps
Conversation
@rubennorte
@rubennorterubennorte
commented
Feb 26, 2026

Copy link


Copy Markdown

Member
Summary
This fixes the semantics of the timeStamp property of events in React Native.
Currently, most events just assign Date.now() (at the time of creating the event object in JavaScript) as the timeStamp property. This is a divergence with Web and most native platforms, that use a monotonic timestamp for the value (on Web, the same timestamp provided by performance.now()).
Additionally, many native events specify a timestamp in the event data object as timestamp and gets ignored by the logic in JS as it only looks at properties named timeStamp specifically (camel case).
This PR fixes both issues by:
  1. Using performance.now() instead of Date.now() by default (if available).
  2. Checking for a timestamp property before falling back to the default (apart from timeStamp).
How did you test this change?
Added unit tests for verify the new behavior.
@react-sizebot
react-sizebot
commented
Feb 26, 2026

Copy link


Copy Markdown

Comparing: 074d96b...eec2df2
Critical size changes
Includes critical production bundles, as well as any change greater than 2%:
Name+/-BaseCurrent+/- gzipBase gzipCurrent gzip
oss-stable/react-dom/cjs/react-dom.production.js=6.84 kB6.84 kB=1.88 kB1.88 kB
oss-stable/react-dom/cjs/react-dom-client.production.js=611.76 kB611.76 kB=108.10 kB108.10 kB
oss-experimental/react-dom/cjs/react-dom.production.js=6.84 kB6.84 kB=1.88 kB1.88 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js=677.69 kB677.69 kB=119.07 kB119.06 kB
facebook-www/ReactDOM-prod.classic.js=697.89 kB697.89 kB=122.63 kB122.63 kB
facebook-www/ReactDOM-prod.modern.js=688.21 kB688.21 kB=121.01 kB121.01 kB
Significant size changes
Includes any change greater than 0.2%:
(No significant changes)

Generated by 🚫 dangerJS against eec2df2
@rubennorte
rubennorte
merged commit a48e9e3
into
react:mainFeb 26, 2026

235 of 241 checks passed

@rubennorte
rubennorte
deleted the

correct-event-timestamps

branch
February 26, 2026 15:51
github-actionsBot
pushed a commit
that referenced
this pull request
Feb 26, 2026
@rubennorte
[RN] Fix timeStamp property of SyntheticEvent in React Native (#35912)
510aa60
## Summary
This fixes the semantics of the `timeStamp` property of events in React
Native.
Currently, most events just assign `Date.now()` (at the time of creating
the event object in JavaScript) as the `timeStamp` property. This is a
divergence with Web and most native platforms, that use a monotonic
timestamp for the value (on Web, the same timestamp provided by
`performance.now()`).
Additionally, many native events specify a timestamp in the event data
object as `timestamp` and gets ignored by the logic in JS as it only
looks at properties named `timeStamp` specifically (camel case).
This PR fixes both issues by:
1. Using `performance.now()` instead of `Date.now()` by default (if
available).
2. Checking for a `timestamp` property before falling back to the
default (apart from `timeStamp`).
## How did you test this change?
Added unit tests for verify the new behavior.
DiffTrain build for [a48e9e3](a48e9e3)
@nextjs-botnextjs-bot
mentioned this pull request
Feb 26, 2026
 Merged

emmaeng700 added a commit
to emmaeng700/react
that referenced
this pull request
Feb 26, 2026
@emmaeng700
fix: don't double-invoke effects for moved children in StrictMode
a2b2040
In StrictMode, `doubleInvokeEffectsInDEVIfNecessary` fires for any
fiber that has the `PlacementDEV` flag set. Previously, `placeChild`
set `PlacementDEV` on both newly inserted fibers AND fibers that were
moved to a different position in an array.
This caused a regression in React 19: when a keyed child is reordered
within an array, its effects are re-run in dev/StrictMode even when
dependencies are empty `[]`. The same component in production, or in
React 18, correctly skips effect re-runs for moves.
The fix is to only set `PlacementDEV` for actual insertions (where
`current === null`). Moved fibers (`current !== null`, `oldIndex <
lastPlacedIndex`) still receive the `Placement` flag so the host node
is correctly repositioned in the DOM, but StrictMode no longer treats
them as new mounts.
Also fix unused `ref3` variable in ReactFabric-test.internal.js
introduced in react#35912 (copy-paste: third View used ref2 instead of ref3).
Fixesreact#32561
@rubennorterubennorte
mentioned this pull request
Mar 3, 2026
 Merged

rubennorte added a commit
that referenced
this pull request
Mar 3, 2026
@rubennorte
Add support for event information in React scheduler tracks in React …
4cc5b7a
…Native (#35947)
## Summary
This defines the same fiber configuration for RN as used in DOM, so we
can expose event timing information in the React scheduler tracks in
performance traces.
This was unblocked by #35913 and #35912.
## How did you test this change?
Manually compiled the renderer and tested e2e in FB infra: <img width="1217" height="161" alt="Screenshot 2026-03-03 at 10 10 44"
src="https://github.com/user-attachments/assets/6ca1512e-dcaf-49cf-8da9-1c6ae554733a"
/>
github-actionsBot
pushed a commit
that referenced
this pull request
Mar 3, 2026
@rubennorte
Add support for event information in React scheduler tracks in React …
809350a
…Native (#35947)
## Summary
This defines the same fiber configuration for RN as used in DOM, so we
can expose event timing information in the React scheduler tracks in
performance traces.
This was unblocked by #35913 and #35912.
## How did you test this change?
Manually compiled the renderer and tested e2e in FB infra:
<img width="1217" height="161" alt="Screenshot 2026-03-03 at 10 10 44"
src="https://github.com/user-attachments/assets/6ca1512e-dcaf-49cf-8da9-1c6ae554733a"
/>
DiffTrain build for [4cc5b7a](4cc5b7a)
github-actionsBot
pushed a commit
to code/lib-react
that referenced
this pull request
Mar 7, 2026
@pull
Add support for event information in React scheduler tracks in React …
da8969c
…Native (react#35947)
## Summary
This defines the same fiber configuration for RN as used in DOM, so we
can expose event timing information in the React scheduler tracks in
performance traces.
This was unblocked by react#35913 and react#35912.
## How did you test this change?
Manually compiled the renderer and tested e2e in FB infra:
<img width="1217" height="161" alt="Screenshot 2026-03-03 at 10 10 44"
src="https://github.com/user-attachments/assets/6ca1512e-dcaf-49cf-8da9-1c6ae554733a"
/>
DiffTrain build for [4cc5b7a](react@4cc5b7a)
github-actionsBot
pushed a commit
to code/lib-react
that referenced
this pull request
Mar 7, 2026
@pull
Add support for event information in React scheduler tracks in React …
8ede614
…Native (react#35947)
## Summary
This defines the same fiber configuration for RN as used in DOM, so we
can expose event timing information in the React scheduler tracks in
performance traces.
This was unblocked by react#35913 and react#35912.
## How did you test this change?
Manually compiled the renderer and tested e2e in FB infra:
<img width="1217" height="161" alt="Screenshot 2026-03-03 at 10 10 44"
src="https://github.com/user-attachments/assets/6ca1512e-dcaf-49cf-8da9-1c6ae554733a"
/>
DiffTrain build for [4cc5b7a](react@4cc5b7a)
@rubennorterubennorte
mentioned this pull request
Jun 5, 2026
 Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@javachejavachejavache approved these changes
@sammy-SCsammy-SCAwaiting requested review from sammy-SC
@huntiehuntieAwaiting requested review from huntie
@cipolleschicipolleschiAwaiting requested review from cipolleschi

Assignees


No one assigned


Labels

CLA Signed

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@rubennorte@react-sizebot@javache