Uh oh!
There was an error while loading. Please reload this page.
[noop] Fix createContainer argument order in the Fiber implementation - #35945
Merged
eps1lon merged 6 commits intoMar 4, 2026
Merged
Conversation
createContainer argument ordercreateContainer argument order in the Fiber implementationeps1lon
commented
Mar 2, 2026
| jest.restoreAllMocks(); | ||
| }); | ||
| // @gate enableViewTransition || fb |
CollaboratorAuthor
There was a problem hiding this comment.
Outside of enableViewTransition, <ViewTransition> is rendered as a Scope Component due to how messy feature flags are with switch statements:
This used to just pass the test since react-noop-renderer didn't throw when Scope host config APIs were used. Now we do so the test fails in fb builds that have enableViewTransition off but enableScope on.
unstubbable
approved these changes
Mar 4, 2026
Uh oh!
There was an error while loading. Please reload this page.
eps1lonforce-pushed
the
sebbie/03-02-_noop_match_fiber_host_config
branch
from
March 4, 2026 12:54
5374ae3 to
05bf806CompareNotable `now` and `logRecoverableError` were removed due to being unused by Fiber. The rest is either adding throwing shims for missing host config properties or using the shared shims when the whole feature isn't implemented.
They can't be imported from `react-reconciler` since that package is treated as an external of react-noop-renderer
…s a Scope Component
eps1lonforce-pushed
the
sebbie/03-02-_noop_match_fiber_host_config
branch
from
March 4, 2026 13:07
05bf806 to
8127022CompareUh oh!
There was an error while loading. Please reload this page.
github-actionsBot
pushed a commit
to code/lib-react
that referenced
this pull request
Mar 8, 2026
…on (react#35945) DiffTrain build for [3bc2d41](react@3bc2d41)
github-actionsBot
pushed a commit
to code/lib-react
that referenced
this pull request
Mar 8, 2026
…on (react#35945) DiffTrain build for [3bc2d41](react@3bc2d41)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
...and fix most of the type issues in the Fiber implementation of
react-noop-rendererStacked on #35944
Only addressed the most obvious issues. There's still some issues relating to loosely accessing object properties but those don't feel urgent. Especially because this is a test-only renderer.
The argument order of
createContainerwas the main concern.