Uh oh!
There was an error while loading. Please reload this page.
Use a closure to bind argument to callback in ReactErrorUtils - #8363
Merged
Conversation
This way the fake event isn't being implicitly passed into the event handler
gaearon
commented
Nov 20, 2016
Collaborator
Feel free to add a test for ReactErrorUtils if one doesn't exist already. You could also look at change history to see if there were any related tests introduced with this file in the first place. Can you confirm single argument matches production behavior? |
aweary
commented
Nov 28, 2016
ContributorAuthor
@gaearon I added test for |
gaearon
commented
Nov 28, 2016
Collaborator
Lint is failing. |
gaearon
commented
Nov 28, 2016
Collaborator
Tagging as minor since somebody might have accidentally relied on that. |
gaearon
commented
Nov 28, 2016
Collaborator
Linter fails. |
Add fiber test report Linting fixes
awearyforce-pushed
the
dev-event-handler-args
branch
from
November 28, 2016 16:31
996e59d to
f293884Compareaweary
commented
Nov 28, 2016
ContributorAuthor
@gaearon fixed 👍 |
gaearon
commented
Nov 28, 2016
Collaborator
LGTM |
acusti pushed a commit
to brandcast/react
that referenced
this pull request
Mar 15, 2017
…8363) * Use a closure to bind gaurded callback This way the fake event isn't being implicitly passed into the event handler * Add tests for ReactErrorUtils Add fiber test report Linting fixes
This was referenced Sep 4, 2019
This was referenced Sep 22, 2019
This was referenced Jan 22, 2020
This was referenced Feb 23, 2020
This was referenced Mar 18, 2020
This was referenced Mar 27, 2020
This was referenced May 6, 2020
mrizwanashiq pushed a commit
to mrizwanashiq/react
that referenced
this pull request
Jun 25, 2026
…8363) * Use a closure to bind gaurded callback This way the fake event isn't being implicitly passed into the event handler * Add tests for ReactErrorUtils Add fiber test report Linting fixes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See discussion starting here.
This prevents the fake event used here from being passed to the callback. This was causing issues where event handlers received an extra argument in dev only.
@gaearon I verified this fix resolves the issue by building and testing in the basic click counter example. I'm not sure where a unit test for this would go.