Uh oh!
There was an error while loading. Please reload this page.
This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Re-re-land "Upgrade all[most] androidx dependencies to latest" - #53532
Merged
auto-submit[bot] merged 4 commits intoJun 24, 2024
Conversation
9 tasks
gmackall
marked this pull request as ready for review
June 24, 2024 20:22
matanlurey
approved these changes
Jun 24, 2024
| // by a roller rather than as part of CI. | ||
| // The others are irrelevant for a test application. | ||
| disable 'UnpackedNativeCode','MissingApplicationIcon','GoogleAppIndexingApiWarning','GoogleAppIndexingWarning','GradleDependency','NewerVersionAvailable','Registered' | ||
| disable 'UnpackedNativeCode','MissingApplicationIcon','GoogleAppIndexingApiWarning','GoogleAppIndexingWarning','GradleDependency','NewerVersionAvailable','Registered', 'ObsoleteLintCustomCheck' |
Contributor
There was a problem hiding this comment.
Can you add a comment why this was added?
ContributorAuthor
There was a problem hiding this comment.
Hmm I can't remember at this point, as the original pr was a while ago. I'll try removing.
reidbaker
approved these changes
Jun 24, 2024
9 tasks
engine-flutter-autoroll added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 24, 2024
engine-flutter-autoroll added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 24, 2024
auto-submitBot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jun 25, 2024
Manual engine roll to flutter-team-archive/engine#53532, because the roll requires lockfile generation.
gmackall
commented
Jun 25, 2024
ContributorAuthor
Reason for revert: This breaks apps that use plugins that use compileSdk 31, some of which we use in our postsubmit (so it blocks the tree). |
9 tasks
![auto-submit[bot]](https://github.laxmiang.work.gd/r/github.githubassets.com/images/gravatars/gravatar-user-420.png){kind=avatar}
8 tasks
auto-submitBot
added a commit
to flutter/flutter
that referenced
this pull request
Jun 25, 2024
Reverts: #150733 Initiated by: gmackall Reason for reverting: This breaks apps that use plugins that use `compileSdk` 31, some of which we use in our postsubmit (so it blocks the tree). Original PR Author: gmackall Reviewed By: {jason-simmons} This change reverts the following previous change: Manual engine roll to flutter-team-archive/engine#53532, because the roll requires lockfile generation.
auto-submitBot
added a commit
that referenced
this pull request
Jun 25, 2024
…t" (#53532)" (#53546) Reverts: #53532 Initiated by: gmackall Reason for reverting: This breaks apps that use plugins that use compileSdk 31, some of which we use in our postsubmit (so it blocks the tree). Original PR Author: gmackall Reviewed By: {reidbaker, matanlurey} This change reverts the following previous change: Re-re-land #53001 (Reland attempt was at #53462) Unblocked by flutter/flutter#150585, but will still need a manual roll because I will need to re-generate a bunch of lockfiles. Also, https://github.com/flutter/flutter/blob/master/docs/engine/Testing-presubmit-Engine-PRs-with-the-Flutter-framework.md doesn't work (it's blocked on flutter/flutter#149780) so I mostly just have to pray that no new issues occur in the roll. But I believe all issues that came up in the last attempt should be addressed by the above pr and by manual lockfile generation. [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
engine-flutter-autoroll added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 25, 2024
engine-flutter-autoroll added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 25, 2024
engine-flutter-autoroll added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 25, 2024
engine-flutter-autoroll added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 25, 2024
engine-flutter-autoroll added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 25, 2024
auto-submitBot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jun 25, 2024
flutter-team-archive/engine@be7db94...afa7ce1 2024-06-25 skia-flutter-autoroll@skia.org Roll Dart SDK from bb18127b2a8e to b5fc85cfcf1b (1 revision) (flutter-team-archive/engine#53552) 2024-06-25 skia-flutter-autoroll@skia.org Roll Skia from 5feca3095719 to 335200e57c26 (1 revision) (flutter-team-archive/engine#53549) 2024-06-25 skia-flutter-autoroll@skia.org Roll Dart SDK from c187d4b3ec88 to bb18127b2a8e (1 revision) (flutter-team-archive/engine#53547) 2024-06-25 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from _6HNhJ6G59VMceKoN... to WUN7NQK04NjF9fRmf... (flutter-team-archive/engine#53545) 2024-06-25 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Re-re-land "Upgrade all[most] androidx dependencies to latest" (#53532)" (flutter-team-archive/engine#53546) 2024-06-25 bdero@google.com Bump impeller-cmake-example (flutter-team-archive/engine#53538) 2024-06-24 skia-flutter-autoroll@skia.org Roll Skia from e20c8b0bac0c to 5feca3095719 (1 revision) (flutter-team-archive/engine#53544) 2024-06-24 ditman@gmail.com [web] Reland "Fix focus management for text fields (#51009)" (flutter-team-archive/engine#53537) 2024-06-24 skia-flutter-autoroll@skia.org Roll Dart SDK from 5df89347bddf to c187d4b3ec88 (1 revision) (flutter-team-archive/engine#53542) 2024-06-24 chris@bracken.jp [macOS] Generate universal gen_snapshots (flutter-team-archive/engine#53524) 2024-06-24 34871572+gmackall@users.noreply.github.com Re-re-land "Upgrade all[most] androidx dependencies to latest" (flutter-team-archive/engine#53532) 2024-06-24 skia-flutter-autoroll@skia.org Roll Skia from 1948fd53e280 to e20c8b0bac0c (1 revision) (flutter-team-archive/engine#53540) 2024-06-24 skia-flutter-autoroll@skia.org Roll Skia from 0fa58b6ddba0 to 1948fd53e280 (2 revisions) (flutter-team-archive/engine#53536) 2024-06-24 skia-flutter-autoroll@skia.org Roll Skia from ea84df425483 to 0fa58b6ddba0 (3 revisions) (flutter-team-archive/engine#53535) 2024-06-24 30870216+gaaclarke@users.noreply.github.com [Impeller] added a fallback that will make sure the blur fragment shader doesn't overflow (flutter-team-archive/engine#53466) 2024-06-24 jonnywang@google.com [fuchsia] Update Fuchsia API level to 19 (flutter-team-archive/engine#53494) 2024-06-24 skia-flutter-autoroll@skia.org Roll Dart SDK from 95470b2cac1f to 5df89347bddf (1 revision) (flutter-team-archive/engine#53534) 2024-06-24 skia-flutter-autoroll@skia.org Roll Skia from f6b4344d73cc to ea84df425483 (1 revision) (flutter-team-archive/engine#53531) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from _6HNhJ6G59VM to WUN7NQK04NjF If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
sigurdm pushed a commit
to sigurdm/flutter
that referenced
this pull request
Jun 26, 2024
Manual engine roll to flutter-team-archive/engine#53532, because the roll requires lockfile generation.
sigurdm pushed a commit
to sigurdm/flutter
that referenced
this pull request
Jun 26, 2024
) Reverts: flutter#150733 Initiated by: gmackall Reason for reverting: This breaks apps that use plugins that use `compileSdk` 31, some of which we use in our postsubmit (so it blocks the tree). Original PR Author: gmackall Reviewed By: {jason-simmons} This change reverts the following previous change: Manual engine roll to flutter-team-archive/engine#53532, because the roll requires lockfile generation.
gmackall pushed a commit
to gmackall/engine
that referenced
this pull request
Jun 26, 2024
…to latest" (flutter-team-archive#53532)" (flutter-team-archive#53546)" This reverts commit a07ba90.
8 tasks
auto-submitBot
pushed a commit
that referenced
this pull request
Jun 27, 2024
…3592) Re-re-re-land #53001. I recreated the postsubmit failures of the [roll](flutter/flutter#150733) of the [last land](#53532), and then verified on a local branch that those same postsubmits pass with this upgrade after the land of flutter/flutter#150873. So I have pretty high confidence this won't cause any problems in the framework repo. I also tested on a previous land attempt that the `all_packages` app builds on this branch, so that is also a good sign for the packages repo. [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re-re-land #53001
(Reland attempt was at #53462)
Unblocked by flutter/flutter#150585, but will still need a manual roll because I will need to re-generate a bunch of lockfiles.
Also, https://github.com/flutter/flutter/blob/master/docs/engine/Testing-presubmit-Engine-PRs-with-the-Flutter-framework.md doesn't work (it's blocked on flutter/flutter#149780) so I mostly just have to pray that no new issues occur in the roll. But I believe all issues that came up in the last attempt should be addressed by the above pr and by manual lockfile generation.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.