Uh oh!
There was an error while loading. Please reload this page.
This repository was archived by the owner on Feb 22, 2023. It is now read-only.
[ci] Run analyze with minimum resolved packages - #6207
Merged
auto-submit[bot] merged 4 commits intoAug 5, 2022
Merged
Conversation
stuartmorgan-g
requested review from
GaryQian, camsim99, cbracken, cyanglaz, ditman and hellohuanlin
as code ownersAugust 5, 2022 01:31
stuartmorgan-g
commented
Aug 5, 2022
ContributorAuthor
@bparrishMines Follow-up from discussion today. It did require minor tool changes because we have to run |
Closed
11 tasks
GaryQian
reviewed
Aug 5, 2022
Uh oh!
There was an error while loading. Please reload this page.
GaryQian
reviewed
Aug 5, 2022
Uh oh!
There was an error while loading. Please reload this page.
GaryQian
reviewed
Aug 5, 2022
| # Does a sanity check that plugins pass analysis with the lowest possible | ||
| # versions of all dependencies. This is to catch cases where we add use of | ||
| # new APIs but forget to update minimum versions of dependencies to when | ||
| # those APIs are introduced. |
Contributor
There was a problem hiding this comment.
Awesome! This check seems useful.
ditman
approved these changes
Aug 5, 2022
ditman
left a comment
Contributor
There was a problem hiding this comment.
This is a very cool new check! Ship it!
GaryQian
approved these changes
Aug 5, 2022
engine-flutter-autoroll added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 8, 2022
yutaaraki-toydium pushed a commit
to yutaaraki-toydium/plugins
that referenced
this pull request
Aug 12, 2022
moisefeelin pushed a commit
to feelinproject/plugins
that referenced
this pull request
Aug 26, 2022
mauricioluz pushed a commit
to mauricioluz/plugins
that referenced
this pull request
Jan 26, 2023
11 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since our CI always runs on clean projects, they always get the latest resolved versions of dependencies, so won't catch the easy-to-make mistake of introducing use of a new dependency API without updating the minimum version of that dependency to the version that introduced that API.
This adds a new
--downgradeflag toanalyzeto runflutter pub downgradebefore analyzing, and adds a new CI step to run in that mode. (This won't catch runtime mistakes, but as with the "legacy analyze" runs this catches the most common type of mistake at a fraction of the CI cost of running all tests again.)Also fixes all the existing violations flagged by the new step.
Fixesflutter/flutter#108992
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).