From fd4eea090137be0f55bc535b45c5bb1ba8d96e1a Mon Sep 17 00:00:00 2001 From: nohli <43643339+nohli@users.noreply.github.com> Date: Tue, 5 Oct 2021 11:18:17 +0200 Subject: [PATCH] Remove deprecated method registerWith, remove unused instance, make TAG static, update changelog and readme --- .../android_alarm_manager_plus/CHANGELOG.md | 4 ++++ .../AndroidAlarmManagerPlugin.java | 18 +----------------- .../android_alarm_manager_plus/pubspec.yaml | 2 +- 3 files changed, 6 insertions(+), 18 deletions(-) diff --git a/packages/android_alarm_manager_plus/CHANGELOG.md b/packages/android_alarm_manager_plus/CHANGELOG.md index f3415dda42..9d91ac44c8 100644 --- a/packages/android_alarm_manager_plus/CHANGELOG.md +++ b/packages/android_alarm_manager_plus/CHANGELOG.md @@ -1,3 +1,7 @@ +## 2.0.0 + +- Remove deprecated method `registerWith` (of Android v1 embedding) + ## 1.3.2 - Fix build issue introduced in 1.3.1. diff --git a/packages/android_alarm_manager_plus/android/src/main/java/dev/fluttercommunity/plus/androidalarmmanager/AndroidAlarmManagerPlugin.java b/packages/android_alarm_manager_plus/android/src/main/java/dev/fluttercommunity/plus/androidalarmmanager/AndroidAlarmManagerPlugin.java index 006ef9f1e9..ea17206638 100644 --- a/packages/android_alarm_manager_plus/android/src/main/java/dev/fluttercommunity/plus/androidalarmmanager/AndroidAlarmManagerPlugin.java +++ b/packages/android_alarm_manager_plus/android/src/main/java/dev/fluttercommunity/plus/androidalarmmanager/AndroidAlarmManagerPlugin.java @@ -13,7 +13,6 @@ import io.flutter.plugin.common.MethodChannel; import io.flutter.plugin.common.MethodChannel.MethodCallHandler; import io.flutter.plugin.common.MethodChannel.Result; -import io.flutter.plugin.common.PluginRegistry.Registrar; import io.flutter.view.FlutterNativeView; import org.json.JSONArray; import org.json.JSONException; @@ -41,26 +40,11 @@ * */ public class AndroidAlarmManagerPlugin implements FlutterPlugin, MethodCallHandler { - private static AndroidAlarmManagerPlugin instance; - private final String TAG = "AndroidAlarmManagerPlugin"; + private static final String TAG = "AndroidAlarmManagerPlugin"; private Context context; private Object initializationLock = new Object(); private MethodChannel alarmManagerPluginChannel; - /** - * Registers this plugin with an associated Flutter execution context, represented by the given - * {@link Registrar}. - * - *

Once this method is executed, an instance of {@code AndroidAlarmManagerPlugin} will be - * connected to, and running against, the associated Flutter execution context. - */ - public static void registerWith(Registrar registrar) { - if (instance == null) { - instance = new AndroidAlarmManagerPlugin(); - } - instance.onAttachedToEngine(registrar.context(), registrar.messenger()); - } - @Override public void onAttachedToEngine(FlutterPluginBinding binding) { onAttachedToEngine(binding.getApplicationContext(), binding.getBinaryMessenger()); diff --git a/packages/android_alarm_manager_plus/pubspec.yaml b/packages/android_alarm_manager_plus/pubspec.yaml index 080468fae5..01e5946c81 100644 --- a/packages/android_alarm_manager_plus/pubspec.yaml +++ b/packages/android_alarm_manager_plus/pubspec.yaml @@ -1,7 +1,7 @@ name: android_alarm_manager_plus description: Flutter plugin for accessing the Android AlarmManager service, and running Dart code in the background when alarms fire. -version: 1.3.2 +version: 2.0.0 homepage: https://plus.fluttercommunity.dev/ repository: https://github.com/fluttercommunity/plus_plugins/tree/main/packages/