A mostly reasonable approach to React and JSX
- Basic Rules
- Class vs
React.createClassvs stateless - Naming
- Declaration
- Alignment
- Quotes
- Spacing
- Props
- Parentheses
- Tags
- Methods
- Ordering
isMounted
- Only include one React component per file.
- However, multiple Stateless, or Pure, Components are allowed per file. eslint:
react/no-multi-comp.
- However, multiple Stateless, or Pure, Components are allowed per file. eslint:
- Always use JSX syntax.
- Do not use
React.createElementunless you're initializing the app from a file that is not JSX.
If you have internal state and/or refs, prefer
class extends React.ComponentoverReact.createClassunless you have a very good reason to use mixins. eslint:react/prefer-es6-classreact/prefer-stateless-function// badconstListing=React.createClass({// ...render(){return<div>{this.state.hello}</div>;}});// goodclassListingextendsReact.Component{// ...render(){return<div>{this.state.hello}</div>;}}
And if you don't have state or refs, prefer normal functions (not arrow functions) over classes:
// badclassListingextendsReact.Component{render(){return<div>{this.props.hello}</div>;}}// bad (relying on function name inference is discouraged)constListing=({ hello })=>(<div>{hello}</div>);// goodfunctionListing({ hello }){return<div>{hello}</div>;}
Extensions: Use
.jsxextension for React components.Filename: Use PascalCase for filenames. E.g.,
ReservationCard.jsx.Reference Naming: Use PascalCase for React components and camelCase for their instances. eslint:
react/jsx-pascal-case// badimportreservationCardfrom'./ReservationCard';// goodimportReservationCardfrom'./ReservationCard';// badconstReservationItem=<ReservationCard/>;// goodconstreservationItem=<ReservationCard/>;
Component Naming: Use the filename as the component name. For example,
ReservationCard.jsxshould have a reference name ofReservationCard. However, for root components of a directory, useindex.jsxas the filename and use the directory name as the component name:// badimportFooterfrom'./Footer/Footer';// badimportFooterfrom'./Footer/index';// goodimportFooterfrom'./Footer';
Do not use
displayNamefor naming components. Instead, name the component by reference.// badexportdefaultReact.createClass({displayName: 'ReservationCard',// stuff goes here});// goodexportdefaultclassReservationCardextendsReact.Component{}
Follow these alignment styles for JSX syntax. eslint:
react/jsx-closing-bracket-location// bad<FoosuperLongParam="bar"anotherSuperLongParam="baz"/>// good<FoosuperLongParam="bar"anotherSuperLongParam="baz"/>// if props fit in one line then keep it on the same line<Foobar="bar"/>// children get indented normally<FoosuperLongParam="bar"anotherSuperLongParam="baz"><Quux/></Foo>
- Always use double quotes (
") for JSX attributes, but single quotes for all other JS. eslint:jsx-quotes
Why? JSX attributes can't contain escaped quotes, so double quotes make conjunctions like
"don't"easier to type. Regular HTML attributes also typically use double quotes instead of single, so JSX attributes mirror this convention.
```jsx
// bad
<Foo bar='bar' />
// good
<Foo bar="bar" />
// bad
<Foo style={{ left: "20px" }} />
// good
<Foo style={{ left: '20px' }} />
```
Always include a single space in your self-closing tag.
// bad<Foo/>// very bad<Foo/>// bad<Foo/>// good<Foo/>
Do not pad JSX curly braces with spaces. eslint:
react/jsx-curly-spacing// bad<Foobar={baz}/>// good<Foobar={baz}/>
Always use camelCase for prop names.
// bad<FooUserName="hello"phone_number={12345678}/>// good<FoouserName="hello"phoneNumber={12345678}/>
Omit the value of the prop when it is explicitly
true. eslint:react/jsx-boolean-value// bad<Foohidden={true}/>// good<Foohidden/>
Always include an
altprop on<img>tags. If the image is presentational,altcan be an empty string or the<img>must haverole="presentation". eslint:jsx-a11y/img-has-alt// bad<imgsrc="hello.jpg"/>// good<imgsrc="hello.jpg"alt="Me waving hello"/>// good<imgsrc="hello.jpg"alt=""/>// good<imgsrc="hello.jpg"role="presentation"/>
Do not use words like "image", "photo", or "picture" in
<img>altprops. eslint:jsx-a11y/img-redundant-alt
Why? Screenreaders already announce
imgelements as images, so there is no need to include this information in the alt text.
```jsx
// bad
<img src="hello.jpg" alt="Picture of me waving hello" />
// good
<img src="hello.jpg" alt="Me waving hello" />
```
Use only valid, non-abstract ARIA roles. eslint:
jsx-a11y/aria-role// bad - not an ARIA role<divrole="datepicker"/>// bad - abstract ARIA role<divrole="range"/>// good<divrole="button"/>
Do not use
accessKeyon elements. eslint:jsx-a11y/no-access-key
Why? Inconsistencies between keyboard shortcuts and keyboard commands used by people using screenreaders and keyboards complicate accessibility.
// bad<divaccessKey="h"/>// good<div/>- Avoid using an array index as
keyprop, prefer a unique ID. (why?)
// bad{todos.map((todo,index)=><Todo{...todo}key={index}/>)}// good{todos.map(todo=>(<Todo{...todo}key={todo.id}/>))}Wrap JSX tags in parentheses when they span more than one line. eslint:
react/wrap-multilines// badrender(){return<MyComponentclassName="long body"foo="bar"><MyChild/></MyComponent>;}// goodrender(){return(<MyComponentclassName="long body"foo="bar"><MyChild/></MyComponent>);}// good, when single linerender(){constbody=<div>hello</div>;return<MyComponent>{body}</MyComponent>;}
Always self-close tags that have no children. eslint:
react/self-closing-comp// bad<FooclassName="stuff"></Foo>// good<FooclassName="stuff"/>
If your component has multi-line properties, close its tag on a new line. eslint:
react/jsx-closing-bracket-location// bad<Foobar="bar"baz="baz"/>// good<Foobar="bar"baz="baz"/>
Use arrow functions to close over local variables.
functionItemList(props){return(<ul>{props.items.map((item,index)=>(<Itemkey={item.key}onClick={()=>doSomethingWith(item.name,index)}/>))}</ul>);}
Bind event handlers for the render method in the constructor. eslint:
react/jsx-no-bind
Why? A bind call in the render path creates a brand new function on every single render.
```jsx
// bad
class extends React.Component {
onClickDiv() {
// do stuff
}
render() {
return <div onClick={this.onClickDiv.bind(this)} />
}
}
// good
class extends React.Component {
constructor(props) {
super(props);
this.onClickDiv = this.onClickDiv.bind(this);
}
onClickDiv() {
// do stuff
}
render() {
return <div onClick={this.onClickDiv} />
}
}
```
Do not use underscore prefix for internal methods of a React component.
// badReact.createClass({_onClickSubmit(){// do stuff},// other stuff});// goodclassextendsReact.Component{onClickSubmit(){// do stuff}// other stuff}
Be sure to return a value in your
rendermethods. eslint:require-render-return// badrender(){(<div/>);}// goodrender(){return(<div/>);}
- Ordering for
class extends React.Component:
- optional
staticmethods constructorgetChildContextcomponentWillMountcomponentDidMountcomponentWillReceivePropsshouldComponentUpdatecomponentWillUpdatecomponentDidUpdatecomponentWillUnmount- clickHandlers or eventHandlers like
onClickSubmit()oronChangeDescription() - getter methods for
renderlikegetSelectReason()orgetFooterContent() - Optional render methods like
renderNavigation()orrenderProfilePicture() render
How to define
propTypes,defaultProps,contextTypes, etc...importReact,{PropTypes}from'react';constpropTypes={id: PropTypes.number.isRequired,url: PropTypes.string.isRequired,text: PropTypes.string,};constdefaultProps={text: 'Hello World',};classLinkextendsReact.Component{staticmethodsAreOk(){returntrue;}render(){return<ahref={this.props.url}data-id={this.props.id}>{this.props.text}</a>}}Link.propTypes=propTypes;Link.defaultProps=defaultProps;exportdefaultLink;
Ordering for
React.createClass: eslint:react/sort-comp
displayNamepropTypescontextTypeschildContextTypesmixinsstaticsdefaultPropsgetDefaultPropsgetInitialStategetChildContextcomponentWillMountcomponentDidMountcomponentWillReceivePropsshouldComponentUpdatecomponentWillUpdatecomponentDidUpdatecomponentWillUnmount- clickHandlers or eventHandlers like
onClickSubmit()oronChangeDescription() - getter methods for
renderlikegetSelectReason()orgetFooterContent() - Optional render methods like
renderNavigation()orrenderProfilePicture() render
- Do not use
isMounted. eslint:react/no-is-mounted
Why?
isMountedis an anti-pattern, is not available when using ES6 classes, and is on its way to being officially deprecated.
This JSX/React style guide is also available in other languages:
Chinese (Simplified): JasonBoy/javascript
Polish: pietraszekl/javascript
Korean: apple77y/javascript