From 1764acfa8177c054a756afbb030a1ad55a9fec4b Mon Sep 17 00:00:00 2001
From: Philipp Hofmann <philipp.hofmann@sentry.io>
Date: Wed, 28 Oct 2020 16:56:36 +0100
Subject: [PATCH 1/5] feat: Manually capturing User Feedback

The SDK now provides a method captureUserFeedback to associate user
feedback to an event.
---
 CHANGELOG.md                                  |   1 +
 .../java/io/sentry/sample/MainActivity.java   |  12 +
 .../src/main/res/layout/activity_main.xml     |   8 +-
 .../src/main/res/values/strings.xml           |   1 +
 .../main/java/io/sentry/GsonSerializer.java   |  29 +++
 sentry/src/main/java/io/sentry/Hub.java       |  22 ++
 .../src/main/java/io/sentry/HubAdapter.java   |   5 +
 sentry/src/main/java/io/sentry/IHub.java      |   7 +
 .../main/java/io/sentry/ISentryClient.java    |   7 +
 .../src/main/java/io/sentry/ISerializer.java  |   4 +
 sentry/src/main/java/io/sentry/NoOpHub.java   |   3 +
 .../main/java/io/sentry/NoOpSentryClient.java |   3 +
 .../main/java/io/sentry/NoOpSerializer.java   |   8 +
 sentry/src/main/java/io/sentry/Sentry.java    |   9 +
 .../src/main/java/io/sentry/SentryClient.java |  26 +++
 .../java/io/sentry/SentryEnvelopeItem.java    |  22 ++
 .../main/java/io/sentry/SentryItemType.java   |   1 +
 .../src/main/java/io/sentry/UserFeedback.java |  99 +++++++++
 .../test/java/io/sentry/GsonSerializerTest.kt |  54 ++++-
 sentry/src/test/java/io/sentry/HubTest.kt     | 209 +++++++-----------
 .../test/java/io/sentry/SentryClientTest.kt   |  69 +++++-
 .../java/io/sentry/SentryEnvelopeItemTest.kt  |   1 +
 sentry/src/test/java/io/sentry/SentryTest.kt  |  33 ++-
 23 files changed, 489 insertions(+), 144 deletions(-)
 create mode 100644 sentry/src/main/java/io/sentry/UserFeedback.java

diff --git a/CHANGELOG.md b/CHANGELOG.md
index 43d0b933413..954443542d6 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -1,5 +1,6 @@
 # 3.1.2
 
+* feat: Manually capturing User Feedback
 * Enhancement: Set environment to "production" by default.
 
 # 3.1.1
diff --git a/sentry-samples/sentry-samples-android/src/main/java/io/sentry/sample/MainActivity.java b/sentry-samples/sentry-samples-android/src/main/java/io/sentry/sample/MainActivity.java
index a6e424df7f0..eb7980ed739 100644
--- a/sentry-samples/sentry-samples-android/src/main/java/io/sentry/sample/MainActivity.java
+++ b/sentry-samples/sentry-samples-android/src/main/java/io/sentry/sample/MainActivity.java
@@ -3,6 +3,8 @@
 import android.os.Bundle;
 import androidx.appcompat.app.AppCompatActivity;
 import io.sentry.Sentry;
+import io.sentry.UserFeedback;
+import io.sentry.protocol.SentryId;
 import io.sentry.protocol.User;
 import io.sentry.sample.databinding.ActivityMainBinding;
 import java.util.Collections;
@@ -22,6 +24,16 @@ protected void onCreate(Bundle savedInstanceState) {
 
     binding.sendMessage.setOnClickListener(view -> Sentry.captureMessage("Some message."));
 
+    binding.sendUserFeedback.setOnClickListener(view -> {
+      SentryId sentryId = Sentry.captureException(new Exception("I have feedback"));
+
+      UserFeedback userFeedback = new UserFeedback(sentryId);
+      userFeedback.setComments("It broke on Android. I don't know why, but this happens.");
+      userFeedback.setEmail("john@me.com");
+      userFeedback.setName("John Me");
+      Sentry.captureUserFeedback(userFeedback);
+    });
+
     binding.captureException.setOnClickListener(
         view ->
             Sentry.captureException(
diff --git a/sentry-samples/sentry-samples-android/src/main/res/layout/activity_main.xml b/sentry-samples/sentry-samples-android/src/main/res/layout/activity_main.xml
index 54cac756107..b1d82bbb0d7 100644
--- a/sentry-samples/sentry-samples-android/src/main/res/layout/activity_main.xml
+++ b/sentry-samples/sentry-samples-android/src/main/res/layout/activity_main.xml
@@ -16,7 +16,13 @@
         android:id="@+id/send_message"
         android:text="@string/send_message"/>
 
-    <Button android:layout_width="wrap_content"
+  <Button
+    android:id="@+id/send_user_feedback"
+    android:layout_width="wrap_content"
+    android:layout_height="wrap_content"
+    android:text="@string/send_user_feedback" />
+
+  <Button android:layout_width="wrap_content"
         android:layout_height="wrap_content"
         android:id="@+id/capture_exception"
         android:text="@string/capture_exception"/>
diff --git a/sentry-samples/sentry-samples-android/src/main/res/values/strings.xml b/sentry-samples/sentry-samples-android/src/main/res/values/strings.xml
index bba1a4e499d..ef6fe2322f6 100644
--- a/sentry-samples/sentry-samples-android/src/main/res/values/strings.xml
+++ b/sentry-samples/sentry-samples-android/src/main/res/values/strings.xml
@@ -2,6 +2,7 @@
   <string name="app_name">Sentry sample</string>
   <string name="crash_from_java">Crash from Java (UncaughtException)</string>
   <string name="send_message">Send Message</string>
+  <string name="send_user_feedback">Send User Feedback</string>
   <string name="capture_exception">Capture Exception</string>
   <string name="breadcrumb">Breadcrumb</string>
   <string name="set_user">Set user</string>
diff --git a/sentry/src/main/java/io/sentry/GsonSerializer.java b/sentry/src/main/java/io/sentry/GsonSerializer.java
index 5bb53c9a1df..6a496998c76 100644
--- a/sentry/src/main/java/io/sentry/GsonSerializer.java
+++ b/sentry/src/main/java/io/sentry/GsonSerializer.java
@@ -106,6 +106,19 @@ Device.DeviceOrientation.class, new OrientationDeserializerAdapter(logger))
     return gson.fromJson(reader, SentryEvent.class);
   }
 
+  /**
+   * Deserialize UserFeedback from a stream Reader (JSON)
+   *
+   * @param reader the Reader
+   * @return the UserFeedback class or null
+   */
+  @Override
+  public UserFeedback deserializeUserFeedback(Reader reader) {
+    Objects.requireNonNull(reader, "The Reader object is required.");
+
+    return gson.fromJson(reader, UserFeedback.class);
+  }
+
   /**
    * Deserialize a Session from a stream Reader (JSON)
    *
@@ -170,6 +183,22 @@ public void serialize(final @NotNull Session session, final @NotNull Writer writ
     writer.flush();
   }
 
+  /**
+   * Serialize UserFeedback to a stream Writer (JSON)
+   *
+   * @param userFeedback the Session
+   * @param writer the Writer
+   * @throws IOException an IOException
+   */
+  @Override
+  public void serialize(UserFeedback userFeedback, Writer writer) throws IOException {
+    Objects.requireNonNull(userFeedback, "The UserFeedback object is required.");
+    Objects.requireNonNull(writer, "The Writer object is required.");
+
+    gson.toJson(userFeedback, UserFeedback.class, writer);
+    writer.flush();
+  }
+
   /**
    * Serialize a SentryEnvelope to a stream Writer (JSON)
    *
diff --git a/sentry/src/main/java/io/sentry/Hub.java b/sentry/src/main/java/io/sentry/Hub.java
index e4722166802..940e80f18bf 100644
--- a/sentry/src/main/java/io/sentry/Hub.java
+++ b/sentry/src/main/java/io/sentry/Hub.java
@@ -188,6 +188,28 @@ public SentryId captureEnvelope(
     return sentryId;
   }
 
+  @Override
+  public void captureUserFeedback(UserFeedback userFeedback) {
+    if (!isEnabled()) {
+      options
+        .getLogger()
+        .log(
+          SentryLevel.WARNING, "Instance is disabled and this 'captureUserFeedback' call is a no-op.");
+    } else {
+      try {
+        final StackItem item = stack.peek();
+        if (item != null) {
+          item.client.captureUserFeedback(userFeedback);
+        } else {
+          options.getLogger().log(SentryLevel.FATAL, "Stack peek was null when captureUserFeedback");
+        }
+      } catch (Exception e) {
+        options.getLogger().log(SentryLevel.ERROR,
+          "Error while capturing captureUserFeedback: " + userFeedback.toString(), e);
+      }
+    }
+  }
+
   @Override
   public void startSession() {
     if (!isEnabled()) {
diff --git a/sentry/src/main/java/io/sentry/HubAdapter.java b/sentry/src/main/java/io/sentry/HubAdapter.java
index ed4c0b47465..2ed357bb1af 100644
--- a/sentry/src/main/java/io/sentry/HubAdapter.java
+++ b/sentry/src/main/java/io/sentry/HubAdapter.java
@@ -42,6 +42,11 @@ public SentryId captureException(Throwable throwable, @Nullable Object hint) {
     return Sentry.captureException(throwable, hint);
   }
 
+  @Override
+  public void captureUserFeedback(UserFeedback userFeedback) {
+    Sentry.captureUserFeedback(userFeedback);
+  }
+
   @Override
   public void startSession() {
     Sentry.startSession();
diff --git a/sentry/src/main/java/io/sentry/IHub.java b/sentry/src/main/java/io/sentry/IHub.java
index 9f0369d88fb..f06112639e2 100644
--- a/sentry/src/main/java/io/sentry/IHub.java
+++ b/sentry/src/main/java/io/sentry/IHub.java
@@ -92,6 +92,13 @@ default SentryId captureException(Throwable throwable) {
     return captureException(throwable, null);
   }
 
+  /**
+   * Captures a manually created user feedback and sends it to Sentry.
+   *
+   * @param userFeedback The user feedback to send to Sentry.
+   */
+  void captureUserFeedback(UserFeedback userFeedback);
+
   /** Starts a new session. If there's a running session, it ends it before starting the new one. */
   void startSession();
 
diff --git a/sentry/src/main/java/io/sentry/ISentryClient.java b/sentry/src/main/java/io/sentry/ISentryClient.java
index e41efec3242..d6a282b1ebf 100644
--- a/sentry/src/main/java/io/sentry/ISentryClient.java
+++ b/sentry/src/main/java/io/sentry/ISentryClient.java
@@ -141,6 +141,13 @@ default SentryId captureException(Throwable throwable, @Nullable Scope scope) {
     return captureException(throwable, scope, null);
   }
 
+  /**
+   * Captures a manually created user feedback and sends it to Sentry.
+   *
+   * @param userFeedback The user feedback to send to Sentry.
+   */
+  void captureUserFeedback(UserFeedback userFeedback);
+
   /**
    * Captures a session. This method transform a session to an envelope and forwards to
    * captureEnvelope
diff --git a/sentry/src/main/java/io/sentry/ISerializer.java b/sentry/src/main/java/io/sentry/ISerializer.java
index b7c941b05b5..d97fbeec3af 100644
--- a/sentry/src/main/java/io/sentry/ISerializer.java
+++ b/sentry/src/main/java/io/sentry/ISerializer.java
@@ -9,6 +9,8 @@
 public interface ISerializer {
   SentryEvent deserializeEvent(Reader reader);
 
+  UserFeedback deserializeUserFeedback(Reader reader);
+
   Session deserializeSession(Reader reader);
 
   SentryEnvelope deserializeEnvelope(InputStream inputStream);
@@ -17,6 +19,8 @@ public interface ISerializer {
 
   void serialize(Session session, Writer writer) throws IOException;
 
+  void serialize(UserFeedback userFeedback, Writer writer) throws IOException;
+
   void serialize(SentryEnvelope envelope, Writer writer) throws Exception;
 
   String serialize(Map<String, Object> data) throws Exception;
diff --git a/sentry/src/main/java/io/sentry/NoOpHub.java b/sentry/src/main/java/io/sentry/NoOpHub.java
index 8319ff55436..e65ce15b464 100644
--- a/sentry/src/main/java/io/sentry/NoOpHub.java
+++ b/sentry/src/main/java/io/sentry/NoOpHub.java
@@ -40,6 +40,9 @@ public SentryId captureException(Throwable throwable, @Nullable Object hint) {
     return SentryId.EMPTY_ID;
   }
 
+  @Override
+  public void captureUserFeedback(UserFeedback userFeedback) { }
+
   @Override
   public void startSession() {}
 
diff --git a/sentry/src/main/java/io/sentry/NoOpSentryClient.java b/sentry/src/main/java/io/sentry/NoOpSentryClient.java
index 65c6256d790..70afd14d2f4 100644
--- a/sentry/src/main/java/io/sentry/NoOpSentryClient.java
+++ b/sentry/src/main/java/io/sentry/NoOpSentryClient.java
@@ -29,6 +29,9 @@ public void close() {}
   @Override
   public void flush(long timeoutMillis) {}
 
+  @Override
+  public void captureUserFeedback(UserFeedback userFeedback) { }
+
   @Override
   public void captureSession(Session session, @Nullable Object hint) {}
 
diff --git a/sentry/src/main/java/io/sentry/NoOpSerializer.java b/sentry/src/main/java/io/sentry/NoOpSerializer.java
index 5e7abd94d28..66d643059ba 100644
--- a/sentry/src/main/java/io/sentry/NoOpSerializer.java
+++ b/sentry/src/main/java/io/sentry/NoOpSerializer.java
@@ -22,6 +22,11 @@ public SentryEvent deserializeEvent(Reader reader) {
     return null;
   }
 
+  @Override
+  public UserFeedback deserializeUserFeedback(Reader reader) {
+    return null;
+  }
+
   @Override
   public Session deserializeSession(Reader reader) {
     return null;
@@ -38,6 +43,9 @@ public void serialize(SentryEvent event, Writer writer) {}
   @Override
   public void serialize(Session session, Writer writer) throws IOException {}
 
+  @Override
+  public void serialize(UserFeedback userFeedback, Writer writer) throws IOException { }
+
   @Override
   public void serialize(SentryEnvelope envelope, Writer outputStream) throws Exception {}
 
diff --git a/sentry/src/main/java/io/sentry/Sentry.java b/sentry/src/main/java/io/sentry/Sentry.java
index fe3f391211f..3339b8f997c 100644
--- a/sentry/src/main/java/io/sentry/Sentry.java
+++ b/sentry/src/main/java/io/sentry/Sentry.java
@@ -293,6 +293,15 @@ public static synchronized void close() {
     return getCurrentHub().captureException(throwable, hint);
   }
 
+  /**
+   * Captures a manually created user feedback and sends it to Sentry.
+   *
+   * @param userFeedback The user feedback to send to Sentry.
+   */
+  public static void captureUserFeedback(UserFeedback userFeedback) {
+    getCurrentHub().captureUserFeedback(userFeedback);
+  }
+
   /**
    * Adds a breadcrumb to the current Scope
    *
diff --git a/sentry/src/main/java/io/sentry/SentryClient.java b/sentry/src/main/java/io/sentry/SentryClient.java
index 2dee70f8f8a..c8b4db21b05 100644
--- a/sentry/src/main/java/io/sentry/SentryClient.java
+++ b/sentry/src/main/java/io/sentry/SentryClient.java
@@ -183,6 +183,32 @@ private SentryEvent processEvent(
     return event;
   }
 
+  @Override
+  public void captureUserFeedback(UserFeedback userFeedback) {
+    Objects.requireNonNull(userFeedback, "SentryEvent is required.");
+
+    options.getLogger().log(SentryLevel.DEBUG, "Capturing userFeedback: %s", userFeedback.getEventId());
+
+    try {
+      final SentryEnvelope envelope = buildEnvelope(userFeedback);
+      connection.send(envelope);
+    } catch (IOException e) {
+      options.getLogger().log(SentryLevel.WARNING, e, "Capturing user feedback %s failed.", userFeedback.getEventId());
+    }
+  }
+
+  private SentryEnvelope buildEnvelope(@NotNull UserFeedback userFeedback) {
+    final List<SentryEnvelopeItem> envelopeItems = new ArrayList<>();
+
+    final SentryEnvelopeItem userFeedbackItem = SentryEnvelopeItem.fromUserFeedback(options.getSerializer(), userFeedback);
+    envelopeItems.add(userFeedbackItem);
+
+    final SentryEnvelopeHeader envelopeHeader =
+      new SentryEnvelopeHeader(userFeedback.getEventId(), options.getSdkVersion());
+
+    return new SentryEnvelope(envelopeHeader, envelopeItems);
+  }
+
   /**
    * Updates the session data based on the event, hint and scope data
    *
diff --git a/sentry/src/main/java/io/sentry/SentryEnvelopeItem.java b/sentry/src/main/java/io/sentry/SentryEnvelopeItem.java
index 7e71d6552ed..6e51e0d5c6a 100644
--- a/sentry/src/main/java/io/sentry/SentryEnvelopeItem.java
+++ b/sentry/src/main/java/io/sentry/SentryEnvelopeItem.java
@@ -108,6 +108,28 @@ public final class SentryEnvelopeItem {
     return new SentryEnvelopeItem(itemHeader, () -> cachedItem.getBytes());
   }
 
+  public static SentryEnvelopeItem fromUserFeedback(
+    final @NotNull ISerializer serializer, final @NotNull UserFeedback userFeedback) {
+    Objects.requireNonNull(serializer, "ISerializer is required.");
+    Objects.requireNonNull(userFeedback, "UserFeedback is required.");
+
+    final CachedItem cachedItem =
+      new CachedItem(
+        () -> {
+          try (final ByteArrayOutputStream stream = new ByteArrayOutputStream();
+               final Writer writer = new BufferedWriter(new OutputStreamWriter(stream, UTF_8))) {
+            serializer.serialize(userFeedback, writer);
+            return stream.toByteArray();
+          }
+        });
+
+    SentryEnvelopeItemHeader itemHeader =
+      new SentryEnvelopeItemHeader(
+        SentryItemType.User_Report, () -> cachedItem.getBytes().length, "application/json", null);
+
+    return new SentryEnvelopeItem(itemHeader, cachedItem::getBytes);
+  }
+
   private static class CachedItem {
     private @Nullable byte[] bytes;
     private final @Nullable Callable<byte[]> dataFactory;
diff --git a/sentry/src/main/java/io/sentry/SentryItemType.java b/sentry/src/main/java/io/sentry/SentryItemType.java
index 3ad9b3afb80..62550740b5d 100644
--- a/sentry/src/main/java/io/sentry/SentryItemType.java
+++ b/sentry/src/main/java/io/sentry/SentryItemType.java
@@ -6,6 +6,7 @@
 public enum SentryItemType {
   Session("session"),
   Event("event"), // DataCategory.Error
+  User_Report("user_report"), // UserFeedback
   Attachment("attachment"),
   Transaction("transaction"),
   Unknown("__unknown__"); // DataCategory.Unknown
diff --git a/sentry/src/main/java/io/sentry/UserFeedback.java b/sentry/src/main/java/io/sentry/UserFeedback.java
new file mode 100644
index 00000000000..d2791cc6936
--- /dev/null
+++ b/sentry/src/main/java/io/sentry/UserFeedback.java
@@ -0,0 +1,99 @@
+package io.sentry;
+
+import org.jetbrains.annotations.Nullable;
+
+import io.sentry.protocol.SentryId;
+
+/**
+ * Adds additional information about what happened to an event.
+ */
+public final class UserFeedback {
+
+  private final SentryId eventId;
+  private @Nullable String name;
+  private @Nullable String email;
+  private @Nullable String comments;
+
+
+  /**
+   * Initializes SentryUserFeedback and sets the required eventId.
+   *
+   * @param eventId The eventId of the event to which the user feedback is associated.
+   */
+  public UserFeedback(SentryId eventId) {
+    this.eventId = eventId;
+  }
+
+  /**
+   * Gets the eventId of the event to which the user feedback is associated.
+   *
+   * @return the eventId
+   */
+  public SentryId getEventId() {
+    return eventId;
+  }
+
+  /**
+   * Gets the name of the user.
+   *
+   * @return the name.
+   */
+  public @Nullable String getName() {
+    return name;
+  }
+
+  /**
+   * Sets the name of the user.
+   *
+   * @param name the name of the user.
+   */
+  public void setName(String name) {
+    this.name = name;
+  }
+
+  /**
+   * Gets the email of the user.
+   *
+   * @return the email.
+   */
+  public @Nullable String getEmail() {
+    return email;
+  }
+
+  /**
+   * Sets the email of the user.
+   *
+   * @param email the email of the user.
+   */
+  public void setEmail(@Nullable String email) {
+    this.email = email;
+  }
+
+  /**
+   * Gets comments of the user about what happened.
+   *
+   * @return the comments
+   */
+  public @Nullable String getComments() {
+    return comments;
+  }
+
+  /**
+   * Sets comments of the user about what happened.
+   *
+   * @param comments the comments
+   */
+  public void setComments(@Nullable String comments) {
+    this.comments = comments;
+  }
+
+  @Override
+  public String toString() {
+    return "UserFeedback{" +
+      "eventId=" + eventId +
+      ", name='" + name + '\'' +
+      ", email='" + email + '\'' +
+      ", comments='" + comments + '\'' +
+      '}';
+  }
+}
diff --git a/sentry/src/test/java/io/sentry/GsonSerializerTest.kt b/sentry/src/test/java/io/sentry/GsonSerializerTest.kt
index cd66a310fb9..37c334a3788 100644
--- a/sentry/src/test/java/io/sentry/GsonSerializerTest.kt
+++ b/sentry/src/test/java/io/sentry/GsonSerializerTest.kt
@@ -8,6 +8,7 @@ import com.nhaarman.mockitokotlin2.whenever
 import io.sentry.protocol.Contexts
 import io.sentry.protocol.Device
 import io.sentry.protocol.SdkVersion
+import io.sentry.protocol.SentryId
 import java.io.ByteArrayInputStream
 import java.io.IOException
 import java.io.InputStream
@@ -29,20 +30,24 @@ class GsonSerializerTest {
     private val serializer = GsonSerializer(mock(), EnvelopeReader())
 
     private fun serializeToString(ev: SentryEvent): String {
-        val wrt = StringWriter()
-        serializer.serialize(ev, wrt)
-        return wrt.toString()
+        return serializeToString { wrt -> serializer.serialize(ev, wrt) }
     }
 
     private fun serializeToString(session: Session): String {
-        val wrt = StringWriter()
-        serializer.serialize(session, wrt)
-        return wrt.toString()
+        return serializeToString { wrt -> serializer.serialize(session, wrt) }
     }
 
     private fun serializeToString(envelope: SentryEnvelope): String {
+        return serializeToString { wrt -> serializer.serialize(envelope, wrt) }
+    }
+
+    private fun serializeToString(userFeedback: UserFeedback): String {
+        return serializeToString { wrt -> serializer.serialize(userFeedback, wrt) }
+    }
+
+    private fun serializeToString(serialize: (StringWriter) -> Unit): String {
         val wrt = StringWriter()
-        serializer.serialize(envelope, wrt)
+        serialize(wrt)
         return wrt.toString()
     }
 
@@ -422,6 +427,28 @@ class GsonSerializerTest {
         assertEquals(expected, dataJson)
     }
 
+    @Test
+    fun `serializing user feedback`() {
+        val actual =  serializeToString(userFeedback)
+
+        val expected = "{\"event_id\":\"${userFeedback.eventId}\",\"name\":\"${userFeedback.name}\"," +
+            "\"email\":\"${userFeedback.email}\",\"comments\":\"${userFeedback.comments}\"}"
+
+        assertEquals(expected, actual)
+    }
+
+    @Test
+    fun `deserializing user feedback`() {
+        val jsonUserFeedback = "{\"event_id\":\"c2fb8fee2e2b49758bcb67cda0f713c7\"," +
+            "\"name\":\"John\",\"email\":\"john@me.com\",\"comments\":\"comment\"}"
+        val actual = serializer.deserializeUserFeedback(StringReader(jsonUserFeedback))
+
+        assertEquals(userFeedback.eventId, actual.eventId)
+        assertEquals(userFeedback.name, actual.name)
+        assertEquals(userFeedback.email, actual.email)
+        assertEquals(userFeedback.comments, actual.comments)
+    }
+
     private fun assertSessionData(expectedSession: Session?) {
         assertNotNull(expectedSession)
         assertEquals(UUID.fromString("c81d4e2e-bcf2-11e6-869b-7df92533d2db"), expectedSession.sessionId)
@@ -472,4 +499,17 @@ class GsonSerializerTest {
             "debug",
             "io.sentry@1.0+123"
         )
+
+    private val userFeedback: UserFeedback get()  {
+        val eventId = SentryId("c2fb8fee2e2b49758bcb67cda0f713c7")
+        val userFeedback = UserFeedback(eventId)
+        userFeedback.apply {
+            name = "John"
+            email = "john@me.com"
+            comments = "comment"
+        }
+
+        return userFeedback
+    }
 }
+
diff --git a/sentry/src/test/java/io/sentry/HubTest.kt b/sentry/src/test/java/io/sentry/HubTest.kt
index 89c6f803dd3..7dc5ec92efb 100644
--- a/sentry/src/test/java/io/sentry/HubTest.kt
+++ b/sentry/src/test/java/io/sentry/HubTest.kt
@@ -4,6 +4,7 @@ import com.nhaarman.mockitokotlin2.any
 import com.nhaarman.mockitokotlin2.anyOrNull
 import com.nhaarman.mockitokotlin2.argWhere
 import com.nhaarman.mockitokotlin2.doAnswer
+import com.nhaarman.mockitokotlin2.doThrow
 import com.nhaarman.mockitokotlin2.eq
 import com.nhaarman.mockitokotlin2.isNull
 import com.nhaarman.mockitokotlin2.mock
@@ -16,6 +17,8 @@ import io.sentry.hints.SessionEndHint
 import io.sentry.hints.SessionStartHint
 import io.sentry.protocol.SentryId
 import io.sentry.protocol.User
+import org.mockito.ArgumentCaptor
+import org.mockito.Mockito.`when`
 import java.io.File
 import java.nio.file.Files
 import java.util.Queue
@@ -121,8 +124,7 @@ class HubTest {
     fun `when beforeBreadcrumb returns null, crumb is dropped`() {
         val options = SentryOptions()
         options.cacheDirPath = file.absolutePath
-        options.beforeBreadcrumb = SentryOptions.BeforeBreadcrumbCallback {
-            _: Breadcrumb, _: Any? -> null }
+        options.beforeBreadcrumb = SentryOptions.BeforeBreadcrumbCallback { _: Breadcrumb, _: Any? -> null }
         options.dsn = "https://key@sentry.io/proj"
         options.setSerializer(mock())
         val sut = Hub(options)
@@ -235,13 +237,7 @@ class HubTest {
 
     @Test
     fun `when flush is called on disabled client, no-op`() {
-        val options = SentryOptions()
-        options.cacheDirPath = file.absolutePath
-        options.dsn = "https://key@sentry.io/proj"
-        options.setSerializer(mock())
-        val sut = Hub(options)
-        val mockClient = mock<ISentryClient>()
-        sut.bindClient(mockClient)
+        val (sut, mockClient) = getEnabledHub()
         sut.close()
 
         sut.flush(1000)
@@ -250,13 +246,7 @@ class HubTest {
 
     @Test
     fun `when flush is called, client flush gets called`() {
-        val options = SentryOptions()
-        options.cacheDirPath = file.absolutePath
-        options.dsn = "https://key@sentry.io/proj"
-        options.setSerializer(mock())
-        val sut = Hub(options)
-        val mockClient = mock<ISentryClient>()
-        sut.bindClient(mockClient)
+        val (sut, mockClient) = getEnabledHub()
 
         sut.flush(1000)
         verify(mockClient).flush(1000)
@@ -276,13 +266,7 @@ class HubTest {
 
     @Test
     fun `when captureEvent is called on disabled client, do nothing`() {
-        val options = SentryOptions()
-        options.cacheDirPath = file.absolutePath
-        options.dsn = "https://key@sentry.io/proj"
-        options.setSerializer(mock())
-        val sut = Hub(options)
-        val mockClient = mock<ISentryClient>()
-        sut.bindClient(mockClient)
+        val (sut, mockClient) = getEnabledHub()
         sut.close()
 
         sut.captureEvent(SentryEvent())
@@ -291,13 +275,7 @@ class HubTest {
 
     @Test
     fun `when captureEvent is called with a valid argument, captureEvent on the client should be called`() {
-        val options = SentryOptions()
-        options.cacheDirPath = file.absolutePath
-        options.dsn = "https://key@sentry.io/proj"
-        options.setSerializer(mock())
-        val sut = Hub(options)
-        val mockClient = mock<ISentryClient>()
-        sut.bindClient(mockClient)
+        val (sut, mockClient) = getEnabledHub()
 
         val event = SentryEvent()
         val hint = { }
@@ -307,13 +285,7 @@ class HubTest {
 
     @Test
     fun `when captureEvent is called and session tracking is disabled, it should not capture a session`() {
-        val options = SentryOptions()
-        options.cacheDirPath = file.absolutePath
-        options.dsn = "https://key@sentry.io/proj"
-        options.setSerializer(mock())
-        val sut = Hub(options)
-        val mockClient = mock<ISentryClient>()
-        sut.bindClient(mockClient)
+        val (sut, mockClient) = getEnabledHub()
 
         val event = SentryEvent()
         val hint = { }
@@ -324,13 +296,7 @@ class HubTest {
 
     @Test
     fun `when captureEvent is called but no session started, it should not capture a session`() {
-        val options = SentryOptions()
-        options.cacheDirPath = file.absolutePath
-        options.dsn = "https://key@sentry.io/proj"
-        options.setSerializer(mock())
-        val sut = Hub(options)
-        val mockClient = mock<ISentryClient>()
-        sut.bindClient(mockClient)
+        val (sut, mockClient) = getEnabledHub()
 
         val event = SentryEvent()
         val hint = { }
@@ -354,13 +320,7 @@ class HubTest {
 
     @Test
     fun `when captureMessage is called on disabled client, do nothing`() {
-        val options = SentryOptions()
-        options.cacheDirPath = file.absolutePath
-        options.dsn = "https://key@sentry.io/proj"
-        options.setSerializer(mock())
-        val sut = Hub(options)
-        val mockClient = mock<ISentryClient>()
-        sut.bindClient(mockClient)
+        val (sut, mockClient) = getEnabledHub()
         sut.close()
 
         sut.captureMessage("test")
@@ -369,13 +329,7 @@ class HubTest {
 
     @Test
     fun `when captureMessage is called with a valid message, captureMessage on the client should be called`() {
-        val options = SentryOptions()
-        options.cacheDirPath = file.absolutePath
-        options.dsn = "https://key@sentry.io/proj"
-        options.setSerializer(mock())
-        val sut = Hub(options)
-        val mockClient = mock<ISentryClient>()
-        sut.bindClient(mockClient)
+        val (sut, mockClient) = getEnabledHub()
 
         sut.captureMessage("test")
         verify(mockClient).captureMessage(any(), any(), any())
@@ -383,13 +337,7 @@ class HubTest {
 
     @Test
     fun `when captureMessage is called, level is INFO by default`() {
-        val options = SentryOptions()
-        options.cacheDirPath = file.absolutePath
-        options.dsn = "https://key@sentry.io/proj"
-        options.setSerializer(mock())
-        val sut = Hub(options)
-        val mockClient = mock<ISentryClient>()
-        sut.bindClient(mockClient)
+        val (sut, mockClient) = getEnabledHub()
         sut.captureMessage("test")
         verify(mockClient).captureMessage(eq("test"), eq(SentryLevel.INFO), any())
     }
@@ -409,13 +357,7 @@ class HubTest {
 
     @Test
     fun `when captureException is called on disabled client, do nothing`() {
-        val options = SentryOptions()
-        options.cacheDirPath = file.absolutePath
-        options.dsn = "https://key@sentry.io/proj"
-        options.setSerializer(mock())
-        val sut = Hub(options)
-        val mockClient = mock<ISentryClient>()
-        sut.bindClient(mockClient)
+        val (sut, mockClient) = getEnabledHub()
         sut.close()
 
         sut.captureException(Throwable())
@@ -424,13 +366,7 @@ class HubTest {
 
     @Test
     fun `when captureException is called with a valid argument and hint, captureException on the client should be called`() {
-        val options = SentryOptions()
-        options.cacheDirPath = file.absolutePath
-        options.dsn = "https://key@sentry.io/proj"
-        options.setSerializer(mock())
-        val sut = Hub(options)
-        val mockClient = mock<ISentryClient>()
-        sut.bindClient(mockClient)
+        val (sut, mockClient) = getEnabledHub()
 
         sut.captureException(Throwable(), Object())
         verify(mockClient).captureException(any(), any(), any())
@@ -438,29 +374,65 @@ class HubTest {
 
     @Test
     fun `when captureException is called with a valid argument but no hint, captureException on the client should be called`() {
-        val options = SentryOptions()
-        options.cacheDirPath = file.absolutePath
-        options.dsn = "https://key@sentry.io/proj"
-        options.setSerializer(mock())
-        val sut = Hub(options)
-        val mockClient = mock<ISentryClient>()
-        sut.bindClient(mockClient)
+        val (sut, mockClient) = getEnabledHub()
 
         sut.captureException(Throwable())
         verify(mockClient).captureException(any(), any(), isNull())
     }
     //endregion
 
+    //region captureUserFeedback tests
+
+    @Test
+    fun `when captureUserFeedback is called it is forwarded to the client`() {
+        val (sut, mockClient) = getEnabledHub()
+        sut.captureUserFeedback(userFeedback)
+
+        val captor = ArgumentCaptor.forClass(UserFeedback::class.java)
+        verify(mockClient).captureUserFeedback(captor.capture())
+
+        val actual = captor.value
+        assertEquals(userFeedback.eventId, actual.eventId)
+        assertEquals(userFeedback.email, actual.email)
+        assertEquals(userFeedback.name, actual.name)
+        assertEquals(userFeedback.comments, actual.comments)
+    }
+
+    @Test
+    fun `when captureUserFeedback is called on disabled client, do nothing`() {
+        val (sut, mockClient) = getEnabledHub()
+        sut.close()
+
+        sut.captureUserFeedback(userFeedback)
+        verify(mockClient, never()).captureUserFeedback(any())
+    }
+    @Test
+    fun `when captureUserFeedback is called and client throws, don't crash`() {
+        val (sut, mockClient) = getEnabledHub()
+
+        `when`(mockClient.captureUserFeedback(any())).doThrow(InvalidDsnException(""))
+
+        sut.captureUserFeedback(userFeedback)
+    }
+
+    private val userFeedback: UserFeedback get()  {
+        val eventId = SentryId("c2fb8fee2e2b49758bcb67cda0f713c7")
+        val userFeedback = UserFeedback(eventId)
+        userFeedback.apply {
+            name = "John"
+            email = "john@me.com"
+            comments = "comment"
+        }
+
+        return userFeedback
+    }
+
+    //endregion
+
     //region close tests
     @Test
     fun `when close is called on disabled client, do nothing`() {
-        val options = SentryOptions()
-        options.cacheDirPath = file.absolutePath
-        options.dsn = "https://key@sentry.io/proj"
-        options.setSerializer(mock())
-        val sut = Hub(options)
-        val mockClient = mock<ISentryClient>()
-        sut.bindClient(mockClient)
+        val (sut, mockClient) = getEnabledHub()
         sut.close()
 
         sut.close()
@@ -469,13 +441,7 @@ class HubTest {
 
     @Test
     fun `when close is called and client is alive, close on the client should be called`() {
-        val options = SentryOptions()
-        options.cacheDirPath = file.absolutePath
-        options.dsn = "https://key@sentry.io/proj"
-        options.setSerializer(mock())
-        val sut = Hub(options)
-        val mockClient = mock<ISentryClient>()
-        sut.bindClient(mockClient)
+        val (sut, mockClient) = getEnabledHub()
 
         sut.close()
         verify(mockClient).close()
@@ -485,13 +451,7 @@ class HubTest {
     //region withScope tests
     @Test
     fun `when withScope is called on disabled client, do nothing`() {
-        val options = SentryOptions()
-        options.cacheDirPath = file.absolutePath
-        options.dsn = "https://key@sentry.io/proj"
-        options.setSerializer(mock())
-        val sut = Hub(options)
-        val mockClient = mock<ISentryClient>()
-        sut.bindClient(mockClient)
+        val (sut) = getEnabledHub()
 
         val scopeCallback = mock<ScopeCallback>()
         sut.close()
@@ -502,13 +462,7 @@ class HubTest {
 
     @Test
     fun `when withScope is called with alive client, run should be called`() {
-        val options = SentryOptions()
-        options.cacheDirPath = file.absolutePath
-        options.dsn = "https://key@sentry.io/proj"
-        options.setSerializer(mock())
-        val sut = Hub(options)
-        val mockClient = mock<ISentryClient>()
-        sut.bindClient(mockClient)
+        val (sut) = getEnabledHub()
 
         val scopeCallback = mock<ScopeCallback>()
 
@@ -520,13 +474,7 @@ class HubTest {
     //region configureScope tests
     @Test
     fun `when configureScope is called on disabled client, do nothing`() {
-        val options = SentryOptions()
-        options.cacheDirPath = file.absolutePath
-        options.dsn = "https://key@sentry.io/proj"
-        options.setSerializer(mock())
-        val sut = Hub(options)
-        val mockClient = mock<ISentryClient>()
-        sut.bindClient(mockClient)
+        val (sut) = getEnabledHub()
 
         val scopeCallback = mock<ScopeCallback>()
         sut.close()
@@ -537,13 +485,7 @@ class HubTest {
 
     @Test
     fun `when configureScope is called with alive client, run should be called`() {
-        val options = SentryOptions()
-        options.cacheDirPath = file.absolutePath
-        options.dsn = "https://key@sentry.io/proj"
-        options.setSerializer(mock())
-        val sut = Hub(options)
-        val mockClient = mock<ISentryClient>()
-        sut.bindClient(mockClient)
+        val (sut) = getEnabledHub()
 
         val scopeCallback = mock<ScopeCallback>()
 
@@ -978,4 +920,15 @@ class HubTest {
         }
         return Hub(options)
     }
+
+    private fun getEnabledHub(): Pair<Hub, ISentryClient> {
+        val options = SentryOptions()
+        options.cacheDirPath = file.absolutePath
+        options.dsn = "https://key@sentry.io/proj"
+        options.setSerializer(mock())
+        val sut = Hub(options)
+        val mockClient = mock<ISentryClient>()
+        sut.bindClient(mockClient)
+        return Pair(sut, mockClient)
+    }
 }
diff --git a/sentry/src/test/java/io/sentry/SentryClientTest.kt b/sentry/src/test/java/io/sentry/SentryClientTest.kt
index 04d916e5b75..1ece9066139 100644
--- a/sentry/src/test/java/io/sentry/SentryClientTest.kt
+++ b/sentry/src/test/java/io/sentry/SentryClientTest.kt
@@ -22,11 +22,18 @@ import io.sentry.protocol.User
 import io.sentry.transport.AsyncConnection
 import io.sentry.transport.HttpTransport
 import io.sentry.transport.ITransportGate
-import java.io.ByteArrayInputStream
+import org.mockito.ArgumentCaptor
+import org.mockito.Mockito.`when`
+import java.io.BufferedWriter
+import java.io.ByteArrayOutputStream
 import java.io.IOException
+import java.io.OutputStreamWriter
 import java.io.InputStreamReader
+import java.io.ByteArrayInputStream
 import java.lang.RuntimeException
 import java.net.URL
+import java.nio.charset.Charset
+import java.util.Arrays
 import java.util.UUID
 import kotlin.test.Ignore
 import kotlin.test.Test
@@ -47,6 +54,8 @@ class SentryClientTest {
                 name = "test"
                 version = "1.2.3"
             }
+            isDebug = true
+            setDiagnosticLevel(SentryLevel.DEBUG)
             setSerializer(GsonSerializer(mock(), envelopeReader))
         }
         var connection: AsyncConnection = mock()
@@ -328,6 +337,52 @@ class SentryClientTest {
         assertEquals(allEvents, mockingDetails(fixture.connection).invocations.size - 1) // 1 extra invocation outside .send()
     }
 
+    @Test
+    fun `when captureUserFeedback, envelope is sent`() {
+        val sut = fixture.getSut()
+
+        sut.captureUserFeedback(userFeedback)
+
+        val captor = ArgumentCaptor.forClass(SentryEnvelope::class.java)
+        verify(fixture.connection).send(captor.capture())
+
+        val actual = captor.value
+        assertEquals(userFeedback.eventId, actual.header.eventId)
+        assertEquals(fixture.sentryOptions.sdkVersion, actual.header.sdkVersion)
+
+        assertEquals(1, actual.items.count())
+        val item = actual.items.first()
+        assertEquals(SentryItemType.User_Report, item.header.type)
+        assertEquals("application/json", item.header.contentType)
+
+        assertEnvelopeItemDataForUserFeedback(item)
+    }
+
+    private fun assertEnvelopeItemDataForUserFeedback(item: SentryEnvelopeItem) {
+        val stream = ByteArrayOutputStream()
+        val writer = BufferedWriter(OutputStreamWriter(stream, Charset.forName("UTF-8")))
+        fixture.sentryOptions.serializer.serialize(userFeedback, writer)
+        val expectedData = stream.toByteArray()
+        assertTrue(Arrays.equals(expectedData, item.data))
+    }
+
+    @Test
+    fun `when captureUserFeedback and connection throws, log exception`() {
+        val sut = fixture.getSut()
+
+        val exception = IOException("No connection")
+        `when`(fixture.connection.send(any())).thenThrow(exception)
+
+        val logger = mock<ILogger>()
+        fixture.sentryOptions.setLogger(logger)
+
+        sut.captureUserFeedback(userFeedback)
+
+        verify(logger)
+            .log(SentryLevel.WARNING, exception,
+                "Capturing user feedback %s failed.", userFeedback.eventId);
+    }
+
     @Test
     fun `when hint is Cached, scope is not applied`() {
         val sut = fixture.getSut()
@@ -675,6 +730,18 @@ class SentryClientTest {
         return Session("dis", User(), "env", release)
     }
 
+    private val userFeedback: UserFeedback get()  {
+        val eventId = SentryId("c2fb8fee2e2b49758bcb67cda0f713c7")
+        val userFeedback = UserFeedback(eventId)
+        userFeedback.apply {
+            name = "John"
+            email = "john@me.com"
+            comments = "comment"
+        }
+
+        return userFeedback
+    }
+
     internal class CustomTransportGate : ITransportGate {
         override fun isConnected(): Boolean = false
     }
diff --git a/sentry/src/test/java/io/sentry/SentryEnvelopeItemTest.kt b/sentry/src/test/java/io/sentry/SentryEnvelopeItemTest.kt
index 9cc15c9ae21..cdd1a0b5a94 100644
--- a/sentry/src/test/java/io/sentry/SentryEnvelopeItemTest.kt
+++ b/sentry/src/test/java/io/sentry/SentryEnvelopeItemTest.kt
@@ -1,6 +1,7 @@
 package io.sentry
 
 import com.nhaarman.mockitokotlin2.mock
+import io.sentry.protocol.SentryId
 import io.sentry.protocol.User
 import kotlin.test.Test
 import kotlin.test.assertEquals
diff --git a/sentry/src/test/java/io/sentry/SentryTest.kt b/sentry/src/test/java/io/sentry/SentryTest.kt
index 940a8a69621..8b158a94a5d 100644
--- a/sentry/src/test/java/io/sentry/SentryTest.kt
+++ b/sentry/src/test/java/io/sentry/SentryTest.kt
@@ -1,8 +1,10 @@
 package io.sentry
 
+import com.nhaarman.mockitokotlin2.argThat
 import com.nhaarman.mockitokotlin2.eq
 import com.nhaarman.mockitokotlin2.mock
 import com.nhaarman.mockitokotlin2.verify
+import io.sentry.protocol.SentryId
 import java.io.File
 import java.nio.file.Files
 import java.util.concurrent.CompletableFuture
@@ -16,6 +18,8 @@ import org.junit.rules.TemporaryFolder
 
 class SentryTest {
 
+    private val dsn = "http://key@localhost/proj"
+
     @BeforeTest
     @AfterTest
     fun beforeTest() {
@@ -26,7 +30,7 @@ class SentryTest {
     fun `outboxDir should be created at initialization`() {
         var sentryOptions: SentryOptions? = null
         Sentry.init {
-            it.dsn = "http://key@localhost/proj"
+            it.dsn = dsn
             it.cacheDirPath = getTempPath()
             sentryOptions = it
         }
@@ -40,7 +44,7 @@ class SentryTest {
     fun `envelopesDir should be created at initialization`() {
         var sentryOptions: SentryOptions? = null
         Sentry.init {
-            it.dsn = "http://key@localhost/proj"
+            it.dsn = dsn
             it.cacheDirPath = getTempPath()
             sentryOptions = it
         }
@@ -54,7 +58,7 @@ class SentryTest {
     fun `Init sets SystemOutLogger if logger is NoOp and debug is enabled`() {
         var sentryOptions: SentryOptions? = null
         Sentry.init {
-            it.dsn = "http://key@localhost/proj"
+            it.dsn = dsn
             it.cacheDirPath = getTempPath()
             sentryOptions = it
             it.isDebug = true
@@ -67,7 +71,7 @@ class SentryTest {
     fun `Init sets GsonSerializer if serializer is NoOp`() {
         var sentryOptions: SentryOptions? = null
         Sentry.init {
-            it.dsn = "http://key@localhost/proj"
+            it.dsn = dsn
             it.cacheDirPath = getTempPath()
             sentryOptions = it
         }
@@ -78,7 +82,7 @@ class SentryTest {
     @Test
     fun `scope changes are isolated to a thread`() {
         Sentry.init {
-            it.dsn = "http://key@localhost/proj"
+            it.dsn = dsn
         }
         Sentry.configureScope {
             it.setTag("a", "a")
@@ -103,10 +107,10 @@ class SentryTest {
     fun `warns about multiple Sentry initializations`() {
         val logger = mock<ILogger>()
         Sentry.init {
-            it.dsn = "http://key@localhost/proj"
+            it.dsn = dsn
         }
         Sentry.init {
-            it.dsn = "http://key@localhost/proj"
+            it.dsn = dsn
             it.isDebug = true
             it.setLogger(logger)
         }
@@ -134,6 +138,21 @@ class SentryTest {
         }
     }
 
+    @Test
+    fun `captureUserFeedback gets forwarded to client`() {
+        Sentry.init { it.dsn = dsn }
+
+        val client = mock<ISentryClient>()
+        Sentry.getCurrentHub().bindClient(client)
+
+        val userFeedback = UserFeedback(SentryId.EMPTY_ID)
+        Sentry.captureUserFeedback(userFeedback)
+
+        verify(client).captureUserFeedback(argThat {
+            eventId == userFeedback.eventId
+        })
+    }
+
     private fun getTempPath(): String {
         val tempFile = Files.createTempDirectory("cache").toFile()
         tempFile.delete()

From 33fa309bece5ef76d7d08bf4603001cc443454ae Mon Sep 17 00:00:00 2001
From: Philipp Hofmann <philipp.hofmann@sentry.io>
Date: Thu, 29 Oct 2020 15:47:49 +0100
Subject: [PATCH 2/5] Fix SentryItemType

---
 sentry/src/main/java/io/sentry/SentryEnvelopeItem.java          | 2 +-
 .../main/java/io/sentry/SentryEnvelopeItemHeaderAdapter.java    | 2 +-
 sentry/src/main/java/io/sentry/SentryItemType.java              | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/sentry/src/main/java/io/sentry/SentryEnvelopeItem.java b/sentry/src/main/java/io/sentry/SentryEnvelopeItem.java
index 6e51e0d5c6a..6040e94a302 100644
--- a/sentry/src/main/java/io/sentry/SentryEnvelopeItem.java
+++ b/sentry/src/main/java/io/sentry/SentryEnvelopeItem.java
@@ -125,7 +125,7 @@ public static SentryEnvelopeItem fromUserFeedback(
 
     SentryEnvelopeItemHeader itemHeader =
       new SentryEnvelopeItemHeader(
-        SentryItemType.User_Report, () -> cachedItem.getBytes().length, "application/json", null);
+        SentryItemType.UserFeedback, () -> cachedItem.getBytes().length, "application/json", null);
 
     return new SentryEnvelopeItem(itemHeader, cachedItem::getBytes);
   }
diff --git a/sentry/src/main/java/io/sentry/SentryEnvelopeItemHeaderAdapter.java b/sentry/src/main/java/io/sentry/SentryEnvelopeItemHeaderAdapter.java
index ee3f9030d15..ee57e400965 100644
--- a/sentry/src/main/java/io/sentry/SentryEnvelopeItemHeaderAdapter.java
+++ b/sentry/src/main/java/io/sentry/SentryEnvelopeItemHeaderAdapter.java
@@ -31,7 +31,7 @@ public void write(JsonWriter writer, SentryEnvelopeItemHeader value) throws IOEx
 
     if (!SentryItemType.Unknown.equals(value.getType())) {
       writer.name("type");
-      writer.value(value.getType().name().toLowerCase(Locale.ROOT));
+      writer.value(value.getType().getItemType().toLowerCase(Locale.ROOT));
     }
 
     writer.name("length");
diff --git a/sentry/src/main/java/io/sentry/SentryItemType.java b/sentry/src/main/java/io/sentry/SentryItemType.java
index 62550740b5d..88e4606bf04 100644
--- a/sentry/src/main/java/io/sentry/SentryItemType.java
+++ b/sentry/src/main/java/io/sentry/SentryItemType.java
@@ -6,7 +6,7 @@
 public enum SentryItemType {
   Session("session"),
   Event("event"), // DataCategory.Error
-  User_Report("user_report"), // UserFeedback
+  UserFeedback("user_report"), // Sentry backend still uses user_report
   Attachment("attachment"),
   Transaction("transaction"),
   Unknown("__unknown__"); // DataCategory.Unknown

From 44f69596dbcd387ab4a23d253bcb6823cec489d1 Mon Sep 17 00:00:00 2001
From: Philipp Hofmann <philipp.hofmann@sentry.io>
Date: Thu, 29 Oct 2020 16:26:10 +0100
Subject: [PATCH 3/5] Use mockitokotlin2 instead of mockito

---
 .../test/java/io/sentry/GsonSerializerTest.kt |  5 +---
 sentry/src/test/java/io/sentry/HubTest.kt     | 24 +++++++------------
 .../test/java/io/sentry/SentryClientTest.kt   | 24 ++++++++-----------
 3 files changed, 20 insertions(+), 33 deletions(-)

diff --git a/sentry/src/test/java/io/sentry/GsonSerializerTest.kt b/sentry/src/test/java/io/sentry/GsonSerializerTest.kt
index 37c334a3788..53572103b60 100644
--- a/sentry/src/test/java/io/sentry/GsonSerializerTest.kt
+++ b/sentry/src/test/java/io/sentry/GsonSerializerTest.kt
@@ -502,14 +502,11 @@ class GsonSerializerTest {
 
     private val userFeedback: UserFeedback get()  {
         val eventId = SentryId("c2fb8fee2e2b49758bcb67cda0f713c7")
-        val userFeedback = UserFeedback(eventId)
-        userFeedback.apply {
+        return UserFeedback(eventId).apply {
             name = "John"
             email = "john@me.com"
             comments = "comment"
         }
-
-        return userFeedback
     }
 }
 
diff --git a/sentry/src/test/java/io/sentry/HubTest.kt b/sentry/src/test/java/io/sentry/HubTest.kt
index 7dc5ec92efb..0e5305ffe94 100644
--- a/sentry/src/test/java/io/sentry/HubTest.kt
+++ b/sentry/src/test/java/io/sentry/HubTest.kt
@@ -3,6 +3,7 @@ package io.sentry
 import com.nhaarman.mockitokotlin2.any
 import com.nhaarman.mockitokotlin2.anyOrNull
 import com.nhaarman.mockitokotlin2.argWhere
+import com.nhaarman.mockitokotlin2.check
 import com.nhaarman.mockitokotlin2.doAnswer
 import com.nhaarman.mockitokotlin2.doThrow
 import com.nhaarman.mockitokotlin2.eq
@@ -17,8 +18,6 @@ import io.sentry.hints.SessionEndHint
 import io.sentry.hints.SessionStartHint
 import io.sentry.protocol.SentryId
 import io.sentry.protocol.User
-import org.mockito.ArgumentCaptor
-import org.mockito.Mockito.`when`
 import java.io.File
 import java.nio.file.Files
 import java.util.Queue
@@ -388,14 +387,12 @@ class HubTest {
         val (sut, mockClient) = getEnabledHub()
         sut.captureUserFeedback(userFeedback)
 
-        val captor = ArgumentCaptor.forClass(UserFeedback::class.java)
-        verify(mockClient).captureUserFeedback(captor.capture())
-
-        val actual = captor.value
-        assertEquals(userFeedback.eventId, actual.eventId)
-        assertEquals(userFeedback.email, actual.email)
-        assertEquals(userFeedback.name, actual.name)
-        assertEquals(userFeedback.comments, actual.comments)
+        verify(mockClient).captureUserFeedback(check {
+            assertEquals(userFeedback.eventId, it.eventId)
+            assertEquals(userFeedback.email, it.email)
+            assertEquals(userFeedback.name, it.name)
+            assertEquals(userFeedback.comments, it.comments)
+        })
     }
 
     @Test
@@ -410,21 +407,18 @@ class HubTest {
     fun `when captureUserFeedback is called and client throws, don't crash`() {
         val (sut, mockClient) = getEnabledHub()
 
-        `when`(mockClient.captureUserFeedback(any())).doThrow(InvalidDsnException(""))
+        whenever(mockClient.captureUserFeedback(any())).doThrow(InvalidDsnException(""))
 
         sut.captureUserFeedback(userFeedback)
     }
 
     private val userFeedback: UserFeedback get()  {
         val eventId = SentryId("c2fb8fee2e2b49758bcb67cda0f713c7")
-        val userFeedback = UserFeedback(eventId)
-        userFeedback.apply {
+        return UserFeedback(eventId).apply {
             name = "John"
             email = "john@me.com"
             comments = "comment"
         }
-
-        return userFeedback
     }
 
     //endregion
diff --git a/sentry/src/test/java/io/sentry/SentryClientTest.kt b/sentry/src/test/java/io/sentry/SentryClientTest.kt
index 1ece9066139..9129e369fdd 100644
--- a/sentry/src/test/java/io/sentry/SentryClientTest.kt
+++ b/sentry/src/test/java/io/sentry/SentryClientTest.kt
@@ -22,8 +22,6 @@ import io.sentry.protocol.User
 import io.sentry.transport.AsyncConnection
 import io.sentry.transport.HttpTransport
 import io.sentry.transport.ITransportGate
-import org.mockito.ArgumentCaptor
-import org.mockito.Mockito.`when`
 import java.io.BufferedWriter
 import java.io.ByteArrayOutputStream
 import java.io.IOException
@@ -343,19 +341,17 @@ class SentryClientTest {
 
         sut.captureUserFeedback(userFeedback)
 
-        val captor = ArgumentCaptor.forClass(SentryEnvelope::class.java)
-        verify(fixture.connection).send(captor.capture())
+        verify(fixture.connection).send(check { actual ->
+            assertEquals(userFeedback.eventId, actual.header.eventId)
+            assertEquals(fixture.sentryOptions.sdkVersion, actual.header.sdkVersion)
 
-        val actual = captor.value
-        assertEquals(userFeedback.eventId, actual.header.eventId)
-        assertEquals(fixture.sentryOptions.sdkVersion, actual.header.sdkVersion)
+            assertEquals(1, actual.items.count())
+            val item = actual.items.first()
+            assertEquals(SentryItemType.UserFeedback, item.header.type)
+            assertEquals("application/json", item.header.contentType)
 
-        assertEquals(1, actual.items.count())
-        val item = actual.items.first()
-        assertEquals(SentryItemType.User_Report, item.header.type)
-        assertEquals("application/json", item.header.contentType)
-
-        assertEnvelopeItemDataForUserFeedback(item)
+            assertEnvelopeItemDataForUserFeedback(item)
+        })
     }
 
     private fun assertEnvelopeItemDataForUserFeedback(item: SentryEnvelopeItem) {
@@ -371,7 +367,7 @@ class SentryClientTest {
         val sut = fixture.getSut()
 
         val exception = IOException("No connection")
-        `when`(fixture.connection.send(any())).thenThrow(exception)
+        whenever(fixture.connection.send(any())).thenThrow(exception)
 
         val logger = mock<ILogger>()
         fixture.sentryOptions.setLogger(logger)

From 3ec5ce4e25bbde3f992a54f358d5dd78955dbaab Mon Sep 17 00:00:00 2001
From: Philipp Hofmann <philipp.hofmann@sentry.io>
Date: Thu, 29 Oct 2020 16:28:46 +0100
Subject: [PATCH 4/5] use extension method bufferedWriter

---
 sentry/src/test/java/io/sentry/SentryClientTest.kt | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sentry/src/test/java/io/sentry/SentryClientTest.kt b/sentry/src/test/java/io/sentry/SentryClientTest.kt
index 9129e369fdd..5d9da992764 100644
--- a/sentry/src/test/java/io/sentry/SentryClientTest.kt
+++ b/sentry/src/test/java/io/sentry/SentryClientTest.kt
@@ -356,7 +356,7 @@ class SentryClientTest {
 
     private fun assertEnvelopeItemDataForUserFeedback(item: SentryEnvelopeItem) {
         val stream = ByteArrayOutputStream()
-        val writer = BufferedWriter(OutputStreamWriter(stream, Charset.forName("UTF-8")))
+        val writer = stream.bufferedWriter(Charset.forName("UTF-8"))
         fixture.sentryOptions.serializer.serialize(userFeedback, writer)
         val expectedData = stream.toByteArray()
         assertTrue(Arrays.equals(expectedData, item.data))

From df438e4e1b70fdb84db53ab3d33315a5cfbed804 Mon Sep 17 00:00:00 2001
From: Philipp Hofmann <philipp.hofmann@sentry.io>
Date: Thu, 29 Oct 2020 17:15:41 +0100
Subject: [PATCH 5/5] Add constructor for all parameters

---
 .../src/main/java/io/sentry/UserFeedback.java   | 17 +++++++++++++++++
 1 file changed, 17 insertions(+)

diff --git a/sentry/src/main/java/io/sentry/UserFeedback.java b/sentry/src/main/java/io/sentry/UserFeedback.java
index d2791cc6936..db4765972dc 100644
--- a/sentry/src/main/java/io/sentry/UserFeedback.java
+++ b/sentry/src/main/java/io/sentry/UserFeedback.java
@@ -21,7 +21,24 @@ public final class UserFeedback {
    * @param eventId The eventId of the event to which the user feedback is associated.
    */
   public UserFeedback(SentryId eventId) {
+    this(eventId, null, null, null);
+  }
+
+  /**
+   * Initializes SentryUserFeedback and sets the required eventId.
+   * @param eventId The eventId of the event to which the user feedback is associated.
+   * @param name the name of the user.
+   * @param email the email of the user.
+   * @param comments comments of the user about what happened.
+   */
+  public UserFeedback(SentryId eventId,
+                      @Nullable String name,
+                      @Nullable String email,
+                      @Nullable String comments) {
     this.eventId = eventId;
+    this.name = name;
+    this.email = email;
+    this.comments = comments;
   }
 
   /**