Skip to content

feat(tanstackstart-react): Add distributed tracing - #21144

Merged
nicohrubec merged 8 commits into
developfrom
feat/tanstack-start-distributed-tracing
May 26, 2026
Merged

feat(tanstackstart-react): Add distributed tracing#21144
nicohrubec merged 8 commits into
developfrom
feat/tanstack-start-distributed-tracing

Conversation

@nicohrubec

@nicohrubecnicohrubec commented May 23, 2026•
edited
Loading

Copy link
Copy Markdown
Member

Adds distributed tracing to the TanStack Start SDK by injecting sentry-trace and baggage meta tags into HTML responses in wrapFetchWithSentry. This connects server and client traces automatically without requiring any additional user setup.

The added functions that do the meta tag injections are essentially copies from the astro package (addMetaTagToHead, injectMetaTagsInResponse).

Added a trace-propagation test to the main TSS e2e test application and adjusted the existing cloudflare TSS e2e test application to the new pattern (i.e. remove the manual injection of meta tags).

Example trace with my local sample app:
Screenshot 2026-05-23 at 16 40 05

Closes#18286

cursor[bot]
cursorBot reviewed May 23, 2026
View reviewed changes
Comment threadpackages/tanstackstart-react/src/server/wrapFetchWithSentry.ts Outdated
cursor[bot]
cursorBot reviewed May 23, 2026
View reviewed changes
Comment threadpackages/tanstackstart-react/src/server/wrapFetchWithSentry.ts
cursor[bot]
cursorBot reviewed May 23, 2026
View reviewed changes
Comment threadpackages/tanstackstart-react/src/server/wrapFetchWithSentry.ts
Comment threadpackages/tanstackstart-react/src/server/wrapFetchWithSentry.ts
@nicohrubecnicohrubec changed the title feat(tanstackstart-react): Add distributed tracing via meta tag injectionfeat(tanstackstart-react): Add distributed tracingMay 23, 2026
@nicohrubec
nicohrubec marked this pull request as ready for review May 26, 2026 07:23
@nicohrubec
nicohrubec requested a review from a team as a code ownerMay 26, 2026 07:23
@nicohrubec
nicohrubec requested review from JPeer264, chargome, mydea and s1gr1d and removed request for a team and mydeaMay 26, 2026 07:23
@nicohrubecnicohrubec mentioned this pull request May 26, 2026
Closed
6 tasks
s1gr1d
s1gr1d reviewed May 26, 2026
View reviewed changes
Comment threadpackages/tanstackstart-react/src/server/wrapFetchWithSentry.ts
}
} catch (e) {
captureException(e, {
mechanism: { type: 'auto.http.tanstackstart', handled: false },

@s1gr1ds1gr1dMay 26, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe you could also test that those exceptions are correctly captured.

sentry[bot]
sentryBot reviewed May 26, 2026
View reviewed changes
Comment threadpackages/tanstackstart-react/src/server/wrapFetchWithSentry.ts
nicohrubecand others added 8 commits May 26, 2026 16:21
@nicohrubec@claude
feat(tanstackstart-react): Add distributed tracing via meta tag injec…
694bff8
…tion
Adds distributed tracing to the TanStack Start SDK by injecting `sentry-trace` and `baggage` meta tags into HTML responses in `wrapFetchWithSentry`, connecting server and client traces automatically.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@nicohrubec@claude
fix: Match original comment from Astro middleware
c8e927c
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@nicohrubec@claude
fix: Match Astro injectMetaTagsInResponse implementation 1:1
295b57a
Restore bodyIterator generator for stream error reporting, captureException
in outer catch, TS narrowing reassignment, and comments.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@nicohrubec@claude
fix: Use inline captureException with auto.http.tanstackstart mechanism
c5b8f10
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@nicohrubec@claude
fix: Rename bodyIterator to bodyReporter, add mechanism to outer catch
0c8b118
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@nicohrubec@claude
fix: Avoid calling controller.close() after controller.error()
94fb6a0
Closing an already-errored ReadableStream controller throws TypeError.
Track error state and skip close() in that case.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@nicohrubec@claude
test: Add unit test for stream error captureException, add changelog
6fc3d11
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@nicohrubec
ci: retrigger
53a6c2b
@nicohrubec
nicohrubecforce-pushed the feat/tanstack-start-distributed-tracing branch from 796ae00 to 53a6c2bCompareMay 26, 2026 14:23
cursor[bot]
cursorBot reviewed May 26, 2026
View reviewed changes

@cursorcursorBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 53a6c2b. Configure here.

Comment threadpackages/tanstackstart-react/src/server/wrapFetchWithSentry.ts
sentry[bot]
sentryBot reviewed May 26, 2026
View reviewed changes
Comment threadpackages/tanstackstart-react/src/server/wrapFetchWithSentry.ts
@nicohrubec
nicohrubec merged commit 0a8adc4 into developMay 26, 2026
46 checks passed
@nicohrubec
nicohrubec deleted the feat/tanstack-start-distributed-tracing branch May 26, 2026 14:34
@sentry-release-botsentry-release-botBot mentioned this pull request May 28, 2026
Closed
47 tasks
@github-actionsgithub-actionsBot mentioned this pull request May 28, 2026
Closed
@alex-zwinglialex-zwingli mentioned this pull request Jun 24, 2026
Closed
@zenatozenato mentioned this pull request Jul 2, 2026
Closed
3 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sentrysentry[bot]sentry[bot] left review comments
@cursorcursor[bot]cursor[bot] left review comments
@s1gr1ds1gr1ds1gr1d approved these changes
@JPeer264JPeer264Awaiting requested review from JPeer264
@chargomechargomeAwaiting requested review from chargome

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Support distributed tracing

2 participants

@nicohrubec@s1gr1d