runtime: flush stdout and stderr file descriptors at exit by gf712 · Pull Request #38 · gf712/python-cpp

gf712 · 2026-07-27T08:34:52Z

No description provided.

claude · 2026-07-27T08:51:32Z

Code review

Found 2 new issues — see the inline comments.

claude · 2026-07-27T11:16:02Z

Code review

Found 2 new issues — see the inline comments.

claude · 2026-07-27T12:44:04Z

Code review

Found 3 new issues — see the inline comments.

claude · 2026-07-27T14:03:46Z

Code review

Found 1 new issue — see the inline comment.

claude · 2026-07-27T14:29:08Z

Code review

Found 1 new issue — see the inline comments.

claude · 2026-07-27T15:14:44Z

+	PyResult<PyObject *> isatty()
+	{
+ return m_buffer->get_method(PyString::create("isatty").unwrap()).and_then([](auto *isatty) {
+ return isatty->call(nullptr, nullptr);
+ });
+	}


isatty() dereferences m_buffer with no initialization check (bug)
m_buffer is only set in init(), and TextIOWrapper.__new__ allocates without initializing it, so _io.TextIOWrapper.__new__(_io.TextIOWrapper).isatty() (or type(sys.stdout).__new__(type(sys.stdout)).isatty()) null-derefs and crashes. Previously isatty() resolved to the inherited IOBase::isatty, which safely returns False after a check_closed() — so this is a new crash path on a call that was previously safe, not just a pre-existing hazard. BufferedWriter in this same PR guards the analogous case via check_initialized().

claude · 2026-07-27T15:14:48Z

Code review

Found 1 new issue — see the inline comments.

claude · 2026-07-28T19:41:30Z

+PyResult<std::monostate> Interpreter::finalise()
+{
+	// TODO: capture exceptions, and raise last one
+	for (auto [callback, args] : m_callbacks) {
+ [[maybe_unused]] auto result = callback->call(args, nullptr);
+	}
+
+	return Ok(std::monostate{});


finalise() discards the result of every exit callback ([[maybe_unused]] auto result = ...) and always returns Ok. The caller in BytecodeProgram.cpp also discards finalise()'s return value, so the process exit code depends only on the main function's result. Since this same PR makes print() default to flush=False and ties sys.stdout line-buffering to isatty(), a flush failure during exit (e.g. EPIPE on a closed pipe, ENOSPC) is now silently swallowed instead of surfacing as a Python error — output can be silently truncated while the process still exits 0. (bug)

claude · 2026-07-28T19:41:34Z

Code review

Found 1 new issue — see the inline comment.

gf712 · 2026-07-27T08:34:52Z

No description provided.

claude · 2026-07-27T08:51:32Z

Code review

Found 2 new issues — see the inline comments.

claude · 2026-07-27T11:16:02Z

Code review

Found 2 new issues — see the inline comments.

claude · 2026-07-27T12:44:04Z

Code review

Found 3 new issues — see the inline comments.

claude · 2026-07-27T14:03:46Z

Code review

Found 1 new issue — see the inline comment.

claude · 2026-07-27T14:29:08Z

Code review

Found 1 new issue — see the inline comments.

claude · 2026-07-27T15:14:44Z

+	PyResult<PyObject *> isatty()
+	{
+ return m_buffer->get_method(PyString::create("isatty").unwrap()).and_then([](auto *isatty) {
+ return isatty->call(nullptr, nullptr);
+ });
+	}


isatty() dereferences m_buffer with no initialization check (bug)
m_buffer is only set in init(), and TextIOWrapper.__new__ allocates without initializing it, so _io.TextIOWrapper.__new__(_io.TextIOWrapper).isatty() (or type(sys.stdout).__new__(type(sys.stdout)).isatty()) null-derefs and crashes. Previously isatty() resolved to the inherited IOBase::isatty, which safely returns False after a check_closed() — so this is a new crash path on a call that was previously safe, not just a pre-existing hazard. BufferedWriter in this same PR guards the analogous case via check_initialized().

claude · 2026-07-27T15:14:48Z

Code review

Found 1 new issue — see the inline comments.

claude · 2026-07-28T19:41:30Z

+PyResult<std::monostate> Interpreter::finalise()
+{
+	// TODO: capture exceptions, and raise last one
+	for (auto [callback, args] : m_callbacks) {
+ [[maybe_unused]] auto result = callback->call(args, nullptr);
+	}
+
+	return Ok(std::monostate{});


finalise() discards the result of every exit callback ([[maybe_unused]] auto result = ...) and always returns Ok. The caller in BytecodeProgram.cpp also discards finalise()'s return value, so the process exit code depends only on the main function's result. Since this same PR makes print() default to flush=False and ties sys.stdout line-buffering to isatty(), a flush failure during exit (e.g. EPIPE on a closed pipe, ENOSPC) is now silently swallowed instead of surfacing as a Python error — output can be silently truncated while the process still exits 0. (bug)

claude · 2026-07-28T19:41:34Z

Code review

Found 1 new issue — see the inline comment.

gf712 · 2026-07-27T08:34:52Z

No description provided.

claude · 2026-07-27T08:51:32Z

Code review

Found 2 new issues — see the inline comments.

claude · 2026-07-27T11:16:02Z

Code review

Found 2 new issues — see the inline comments.

claude · 2026-07-27T12:44:04Z

Code review

Found 3 new issues — see the inline comments.

claude · 2026-07-27T14:03:46Z

Code review

Found 1 new issue — see the inline comment.

claude · 2026-07-27T14:29:08Z

Code review

Found 1 new issue — see the inline comments.

claude · 2026-07-27T15:14:44Z

+	PyResult<PyObject *> isatty()
+	{
+ return m_buffer->get_method(PyString::create("isatty").unwrap()).and_then([](auto *isatty) {
+ return isatty->call(nullptr, nullptr);
+ });
+	}


isatty() dereferences m_buffer with no initialization check (bug)
m_buffer is only set in init(), and TextIOWrapper.__new__ allocates without initializing it, so _io.TextIOWrapper.__new__(_io.TextIOWrapper).isatty() (or type(sys.stdout).__new__(type(sys.stdout)).isatty()) null-derefs and crashes. Previously isatty() resolved to the inherited IOBase::isatty, which safely returns False after a check_closed() — so this is a new crash path on a call that was previously safe, not just a pre-existing hazard. BufferedWriter in this same PR guards the analogous case via check_initialized().

claude · 2026-07-27T15:14:48Z

Code review

Found 1 new issue — see the inline comments.

claude · 2026-07-28T19:41:30Z

+PyResult<std::monostate> Interpreter::finalise()
+{
+	// TODO: capture exceptions, and raise last one
+	for (auto [callback, args] : m_callbacks) {
+ [[maybe_unused]] auto result = callback->call(args, nullptr);
+	}
+
+	return Ok(std::monostate{});


finalise() discards the result of every exit callback ([[maybe_unused]] auto result = ...) and always returns Ok. The caller in BytecodeProgram.cpp also discards finalise()'s return value, so the process exit code depends only on the main function's result. Since this same PR makes print() default to flush=False and ties sys.stdout line-buffering to isatty(), a flush failure during exit (e.g. EPIPE on a closed pipe, ENOSPC) is now silently swallowed instead of surfacing as a Python error — output can be silently truncated while the process still exits 0. (bug)

claude · 2026-07-28T19:41:34Z

Code review

Found 1 new issue — see the inline comment.

gf712 · 2026-07-27T08:34:52Z

No description provided.

claude · 2026-07-27T08:51:32Z

Code review

Found 2 new issues — see the inline comments.

claude · 2026-07-27T11:16:02Z

Code review

Found 2 new issues — see the inline comments.

claude · 2026-07-27T12:44:04Z

Code review

Found 3 new issues — see the inline comments.

claude · 2026-07-27T14:03:46Z

Code review

Found 1 new issue — see the inline comment.

claude · 2026-07-27T14:29:08Z

Code review

Found 1 new issue — see the inline comments.

claude · 2026-07-27T15:14:44Z

+	PyResult<PyObject *> isatty()
+	{
+ return m_buffer->get_method(PyString::create("isatty").unwrap()).and_then([](auto *isatty) {
+ return isatty->call(nullptr, nullptr);
+ });
+	}


isatty() dereferences m_buffer with no initialization check (bug)
m_buffer is only set in init(), and TextIOWrapper.__new__ allocates without initializing it, so _io.TextIOWrapper.__new__(_io.TextIOWrapper).isatty() (or type(sys.stdout).__new__(type(sys.stdout)).isatty()) null-derefs and crashes. Previously isatty() resolved to the inherited IOBase::isatty, which safely returns False after a check_closed() — so this is a new crash path on a call that was previously safe, not just a pre-existing hazard. BufferedWriter in this same PR guards the analogous case via check_initialized().

claude · 2026-07-27T15:14:48Z

Code review

Found 1 new issue — see the inline comments.

claude · 2026-07-28T19:41:30Z

+PyResult<std::monostate> Interpreter::finalise()
+{
+	// TODO: capture exceptions, and raise last one
+	for (auto [callback, args] : m_callbacks) {
+ [[maybe_unused]] auto result = callback->call(args, nullptr);
+	}
+
+	return Ok(std::monostate{});


finalise() discards the result of every exit callback ([[maybe_unused]] auto result = ...) and always returns Ok. The caller in BytecodeProgram.cpp also discards finalise()'s return value, so the process exit code depends only on the main function's result. Since this same PR makes print() default to flush=False and ties sys.stdout line-buffering to isatty(), a flush failure during exit (e.g. EPIPE on a closed pipe, ENOSPC) is now silently swallowed instead of surfacing as a Python error — output can be silently truncated while the process still exits 0. (bug)

claude · 2026-07-28T19:41:34Z

Code review

Found 1 new issue — see the inline comment.

gf712 · 2026-07-27T08:34:52Z

No description provided.

claude · 2026-07-27T08:51:32Z

Code review

Found 2 new issues — see the inline comments.

claude · 2026-07-27T11:16:02Z

Code review

Found 2 new issues — see the inline comments.

claude · 2026-07-27T12:44:04Z

Code review

Found 3 new issues — see the inline comments.

claude · 2026-07-27T14:03:46Z

Code review

Found 1 new issue — see the inline comment.

claude · 2026-07-27T14:29:08Z

Code review

Found 1 new issue — see the inline comments.

claude · 2026-07-27T15:14:44Z

+	PyResult<PyObject *> isatty()
+	{
+ return m_buffer->get_method(PyString::create("isatty").unwrap()).and_then([](auto *isatty) {
+ return isatty->call(nullptr, nullptr);
+ });
+	}


isatty() dereferences m_buffer with no initialization check (bug)
m_buffer is only set in init(), and TextIOWrapper.__new__ allocates without initializing it, so _io.TextIOWrapper.__new__(_io.TextIOWrapper).isatty() (or type(sys.stdout).__new__(type(sys.stdout)).isatty()) null-derefs and crashes. Previously isatty() resolved to the inherited IOBase::isatty, which safely returns False after a check_closed() — so this is a new crash path on a call that was previously safe, not just a pre-existing hazard. BufferedWriter in this same PR guards the analogous case via check_initialized().

claude · 2026-07-27T15:14:48Z

Code review

Found 1 new issue — see the inline comments.

claude · 2026-07-28T19:41:30Z

+PyResult<std::monostate> Interpreter::finalise()
+{
+	// TODO: capture exceptions, and raise last one
+	for (auto [callback, args] : m_callbacks) {
+ [[maybe_unused]] auto result = callback->call(args, nullptr);
+	}
+
+	return Ok(std::monostate{});


finalise() discards the result of every exit callback ([[maybe_unused]] auto result = ...) and always returns Ok. The caller in BytecodeProgram.cpp also discards finalise()'s return value, so the process exit code depends only on the main function's result. Since this same PR makes print() default to flush=False and ties sys.stdout line-buffering to isatty(), a flush failure during exit (e.g. EPIPE on a closed pipe, ENOSPC) is now silently swallowed instead of surfacing as a Python error — output can be silently truncated while the process still exits 0. (bug)

claude · 2026-07-28T19:41:34Z

Code review

Found 1 new issue — see the inline comment.

gf712 · 2026-07-27T08:34:52Z

No description provided.

claude · 2026-07-27T08:51:32Z

Code review

Found 2 new issues — see the inline comments.

claude · 2026-07-27T11:16:02Z

Code review

Found 2 new issues — see the inline comments.

claude · 2026-07-27T12:44:04Z

Code review

Found 3 new issues — see the inline comments.

claude · 2026-07-27T14:03:46Z

Code review

Found 1 new issue — see the inline comment.

claude · 2026-07-27T14:29:08Z

Code review

Found 1 new issue — see the inline comments.

claude · 2026-07-27T15:14:44Z

+	PyResult<PyObject *> isatty()
+	{
+ return m_buffer->get_method(PyString::create("isatty").unwrap()).and_then([](auto *isatty) {
+ return isatty->call(nullptr, nullptr);
+ });
+	}


isatty() dereferences m_buffer with no initialization check (bug)
m_buffer is only set in init(), and TextIOWrapper.__new__ allocates without initializing it, so _io.TextIOWrapper.__new__(_io.TextIOWrapper).isatty() (or type(sys.stdout).__new__(type(sys.stdout)).isatty()) null-derefs and crashes. Previously isatty() resolved to the inherited IOBase::isatty, which safely returns False after a check_closed() — so this is a new crash path on a call that was previously safe, not just a pre-existing hazard. BufferedWriter in this same PR guards the analogous case via check_initialized().

claude · 2026-07-27T15:14:48Z

Code review

Found 1 new issue — see the inline comments.

claude · 2026-07-28T19:41:30Z

+PyResult<std::monostate> Interpreter::finalise()
+{
+	// TODO: capture exceptions, and raise last one
+	for (auto [callback, args] : m_callbacks) {
+ [[maybe_unused]] auto result = callback->call(args, nullptr);
+	}
+
+	return Ok(std::monostate{});


finalise() discards the result of every exit callback ([[maybe_unused]] auto result = ...) and always returns Ok. The caller in BytecodeProgram.cpp also discards finalise()'s return value, so the process exit code depends only on the main function's result. Since this same PR makes print() default to flush=False and ties sys.stdout line-buffering to isatty(), a flush failure during exit (e.g. EPIPE on a closed pipe, ENOSPC) is now silently swallowed instead of surfacing as a Python error — output can be silently truncated while the process still exits 0. (bug)

claude · 2026-07-28T19:41:34Z

Code review

Found 1 new issue — see the inline comment.

gf712 · 2026-07-27T08:34:52Z

No description provided.

claude · 2026-07-27T08:51:32Z

Code review

Found 2 new issues — see the inline comments.

claude · 2026-07-27T11:16:02Z

Code review

Found 2 new issues — see the inline comments.

claude · 2026-07-27T12:44:04Z

Code review

Found 3 new issues — see the inline comments.

claude · 2026-07-27T14:03:46Z

Code review

Found 1 new issue — see the inline comment.

claude · 2026-07-27T14:29:08Z

Code review

Found 1 new issue — see the inline comments.

claude · 2026-07-27T15:14:44Z

+	PyResult<PyObject *> isatty()
+	{
+ return m_buffer->get_method(PyString::create("isatty").unwrap()).and_then([](auto *isatty) {
+ return isatty->call(nullptr, nullptr);
+ });
+	}


isatty() dereferences m_buffer with no initialization check (bug)
m_buffer is only set in init(), and TextIOWrapper.__new__ allocates without initializing it, so _io.TextIOWrapper.__new__(_io.TextIOWrapper).isatty() (or type(sys.stdout).__new__(type(sys.stdout)).isatty()) null-derefs and crashes. Previously isatty() resolved to the inherited IOBase::isatty, which safely returns False after a check_closed() — so this is a new crash path on a call that was previously safe, not just a pre-existing hazard. BufferedWriter in this same PR guards the analogous case via check_initialized().

claude · 2026-07-27T15:14:48Z

Code review

Found 1 new issue — see the inline comments.

claude · 2026-07-28T19:41:30Z

+PyResult<std::monostate> Interpreter::finalise()
+{
+	// TODO: capture exceptions, and raise last one
+	for (auto [callback, args] : m_callbacks) {
+ [[maybe_unused]] auto result = callback->call(args, nullptr);
+	}
+
+	return Ok(std::monostate{});


finalise() discards the result of every exit callback ([[maybe_unused]] auto result = ...) and always returns Ok. The caller in BytecodeProgram.cpp also discards finalise()'s return value, so the process exit code depends only on the main function's result. Since this same PR makes print() default to flush=False and ties sys.stdout line-buffering to isatty(), a flush failure during exit (e.g. EPIPE on a closed pipe, ENOSPC) is now silently swallowed instead of surfacing as a Python error — output can be silently truncated while the process still exits 0. (bug)

claude · 2026-07-28T19:41:34Z

Code review

Found 1 new issue — see the inline comment.

gf712 · 2026-07-27T08:34:52Z

No description provided.

claude · 2026-07-27T08:51:32Z

Code review

Found 2 new issues — see the inline comments.

claude · 2026-07-27T11:16:02Z

Code review

Found 2 new issues — see the inline comments.

claude · 2026-07-27T12:44:04Z

Code review

Found 3 new issues — see the inline comments.

claude · 2026-07-27T14:03:46Z

Code review

Found 1 new issue — see the inline comment.

claude · 2026-07-27T14:29:08Z

Code review

Found 1 new issue — see the inline comments.

claude · 2026-07-27T15:14:44Z

+	PyResult<PyObject *> isatty()
+	{
+ return m_buffer->get_method(PyString::create("isatty").unwrap()).and_then([](auto *isatty) {
+ return isatty->call(nullptr, nullptr);
+ });
+	}


isatty() dereferences m_buffer with no initialization check (bug)
m_buffer is only set in init(), and TextIOWrapper.__new__ allocates without initializing it, so _io.TextIOWrapper.__new__(_io.TextIOWrapper).isatty() (or type(sys.stdout).__new__(type(sys.stdout)).isatty()) null-derefs and crashes. Previously isatty() resolved to the inherited IOBase::isatty, which safely returns False after a check_closed() — so this is a new crash path on a call that was previously safe, not just a pre-existing hazard. BufferedWriter in this same PR guards the analogous case via check_initialized().

claude · 2026-07-27T15:14:48Z

Code review

Found 1 new issue — see the inline comments.

claude · 2026-07-28T19:41:30Z

+PyResult<std::monostate> Interpreter::finalise()
+{
+	// TODO: capture exceptions, and raise last one
+	for (auto [callback, args] : m_callbacks) {
+ [[maybe_unused]] auto result = callback->call(args, nullptr);
+	}
+
+	return Ok(std::monostate{});


finalise() discards the result of every exit callback ([[maybe_unused]] auto result = ...) and always returns Ok. The caller in BytecodeProgram.cpp also discards finalise()'s return value, so the process exit code depends only on the main function's result. Since this same PR makes print() default to flush=False and ties sys.stdout line-buffering to isatty(), a flush failure during exit (e.g. EPIPE on a closed pipe, ENOSPC) is now silently swallowed instead of surfacing as a Python error — output can be silently truncated while the process still exits 0. (bug)

claude · 2026-07-28T19:41:34Z

Code review

Found 1 new issue — see the inline comment.

gf712 added 5 commits July 20, 2026 20:08

runtime: wire isatty of buffered fileio textiowrapper (such as stdout)
90852c1

runtime: pass line_buffering arg when constructing stdout
07db39d

runtime: flush on newline
fee2c03

runtime: Add atexit callbacks
b20b52f

runtime: flush std file descriptors at exit
0984442

claudeBot reviewed Jul 27, 2026
View reviewed changes

Comment threadsrc/executable/bytecode/BytecodeProgram.cpp Outdated

claudeBot reviewed Jul 27, 2026
View reviewed changes

Comment threadsrc/runtime/modules/IOModule.cpp

claudeBot reviewed Jul 27, 2026
View reviewed changes

Comment threadsrc/executable/bytecode/BytecodeProgram.cpp

claudeBot reviewed Jul 27, 2026
View reviewed changes

Comment threadsrc/runtime/modules/IOModule.cpp

gf712 force-pushed the fix-buffer-flush branch from 0b2dff6 to efcfb85Compare July 27, 2026 12:21

claudeBot reviewed Jul 27, 2026
View reviewed changes

Comment threadsrc/runtime/modules/IOModule.cpp

claudeBot reviewed Jul 27, 2026
View reviewed changes

Comment threadsrc/runtime/modules/IOModule.cpp Outdated

claudeBot reviewed Jul 27, 2026
View reviewed changes

Comment threadsrc/runtime/modules/IOModule.cpp

Address review comments
2d09746

gf712 force-pushed the fix-buffer-flush branch from efcfb85 to 306cd11Compare July 27, 2026 13:45

claudeBot reviewed Jul 27, 2026
View reviewed changes

Comment threadintegration/run_python_tests.sh

Add buffered writer tests
81b0d4f

gf712 force-pushed the fix-buffer-flush branch from 306cd11 to 81b0d4fCompare July 27, 2026 14:06

claudeBot reviewed Jul 27, 2026
View reviewed changes

Comment threadsrc/runtime/modules/IOModule.cpp Outdated

claudeBot reviewed Jul 27, 2026
View reviewed changes

Address review comment
e97e80c

gf712 force-pushed the fix-buffer-flush branch from b9c384b to e97e80cCompare July 28, 2026 19:24

claudeBot reviewed Jul 28, 2026
View reviewed changes

gf712 merged commit 74079d9 into mainJul 28, 2026
4 checks passed

gf712 deleted the fix-buffer-flush branch July 28, 2026 19:42

gf712 added 5 commits July 20, 2026 20:08

runtime: wire isatty of buffered fileio textiowrapper (such as stdout)
90852c1

runtime: pass line_buffering arg when constructing stdout
07db39d

runtime: flush on newline
fee2c03

runtime: Add atexit callbacks
b20b52f

runtime: flush std file descriptors at exit
0984442

claudeBot reviewed Jul 27, 2026
View reviewed changes

Comment threadsrc/executable/bytecode/BytecodeProgram.cpp Outdated

claudeBot reviewed Jul 27, 2026
View reviewed changes

Comment threadsrc/runtime/modules/IOModule.cpp

claudeBot reviewed Jul 27, 2026
View reviewed changes

Comment threadsrc/executable/bytecode/BytecodeProgram.cpp

claudeBot reviewed Jul 27, 2026
View reviewed changes

Comment threadsrc/runtime/modules/IOModule.cpp

gf712 force-pushed the fix-buffer-flush branch from 0b2dff6 to efcfb85Compare July 27, 2026 12:21

claudeBot reviewed Jul 27, 2026
View reviewed changes

Comment threadsrc/runtime/modules/IOModule.cpp

claudeBot reviewed Jul 27, 2026
View reviewed changes

Comment threadsrc/runtime/modules/IOModule.cpp Outdated

claudeBot reviewed Jul 27, 2026
View reviewed changes

Comment threadsrc/runtime/modules/IOModule.cpp

Address review comments
2d09746

gf712 force-pushed the fix-buffer-flush branch from efcfb85 to 306cd11Compare July 27, 2026 13:45

claudeBot reviewed Jul 27, 2026
View reviewed changes

Comment threadintegration/run_python_tests.sh

Add buffered writer tests
81b0d4f

gf712 force-pushed the fix-buffer-flush branch from 306cd11 to 81b0d4fCompare July 27, 2026 14:06

claudeBot reviewed Jul 27, 2026
View reviewed changes

Comment threadsrc/runtime/modules/IOModule.cpp Outdated

claudeBot reviewed Jul 27, 2026
View reviewed changes

Address review comment
e97e80c

gf712 force-pushed the fix-buffer-flush branch from b9c384b to e97e80cCompare July 28, 2026 19:24

claudeBot reviewed Jul 28, 2026
View reviewed changes

gf712 merged commit 74079d9 into mainJul 28, 2026
4 checks passed

gf712 deleted the fix-buffer-flush branch July 28, 2026 19:42

gf712 added 5 commits July 20, 2026 20:08

runtime: wire isatty of buffered fileio textiowrapper (such as stdout)
90852c1

runtime: pass line_buffering arg when constructing stdout
07db39d

runtime: flush on newline
fee2c03

runtime: Add atexit callbacks
b20b52f

runtime: flush std file descriptors at exit
0984442

claudeBot reviewed Jul 27, 2026
View reviewed changes

Comment threadsrc/executable/bytecode/BytecodeProgram.cpp Outdated

claudeBot reviewed Jul 27, 2026
View reviewed changes

Comment threadsrc/runtime/modules/IOModule.cpp

claudeBot reviewed Jul 27, 2026
View reviewed changes

Comment threadsrc/executable/bytecode/BytecodeProgram.cpp

claudeBot reviewed Jul 27, 2026
View reviewed changes

Comment threadsrc/runtime/modules/IOModule.cpp

gf712 force-pushed the fix-buffer-flush branch from 0b2dff6 to efcfb85Compare July 27, 2026 12:21

claudeBot reviewed Jul 27, 2026
View reviewed changes

Comment threadsrc/runtime/modules/IOModule.cpp

claudeBot reviewed Jul 27, 2026
View reviewed changes

Comment threadsrc/runtime/modules/IOModule.cpp Outdated

claudeBot reviewed Jul 27, 2026
View reviewed changes

Comment threadsrc/runtime/modules/IOModule.cpp

Address review comments
2d09746

gf712 force-pushed the fix-buffer-flush branch from efcfb85 to 306cd11Compare July 27, 2026 13:45

claudeBot reviewed Jul 27, 2026
View reviewed changes

Comment threadintegration/run_python_tests.sh

Add buffered writer tests
81b0d4f

gf712 force-pushed the fix-buffer-flush branch from 306cd11 to 81b0d4fCompare July 27, 2026 14:06

claudeBot reviewed Jul 27, 2026
View reviewed changes

Comment threadsrc/runtime/modules/IOModule.cpp Outdated

claudeBot reviewed Jul 27, 2026
View reviewed changes

Address review comment
e97e80c

gf712 force-pushed the fix-buffer-flush branch from b9c384b to e97e80cCompare July 28, 2026 19:24

claudeBot reviewed Jul 28, 2026
View reviewed changes

gf712 merged commit 74079d9 into mainJul 28, 2026
4 checks passed

gf712 deleted the fix-buffer-flush branch July 28, 2026 19:42

gf712 added 5 commits July 20, 2026 20:08

runtime: wire isatty of buffered fileio textiowrapper (such as stdout)
90852c1

runtime: pass line_buffering arg when constructing stdout
07db39d

runtime: flush on newline
fee2c03

runtime: Add atexit callbacks
b20b52f

runtime: flush std file descriptors at exit
0984442

claudeBot reviewed Jul 27, 2026
View reviewed changes

Comment threadsrc/executable/bytecode/BytecodeProgram.cpp Outdated

claudeBot reviewed Jul 27, 2026
View reviewed changes

Comment threadsrc/runtime/modules/IOModule.cpp

claudeBot reviewed Jul 27, 2026
View reviewed changes

Comment threadsrc/executable/bytecode/BytecodeProgram.cpp

claudeBot reviewed Jul 27, 2026
View reviewed changes

Comment threadsrc/runtime/modules/IOModule.cpp

gf712 force-pushed the fix-buffer-flush branch from 0b2dff6 to efcfb85Compare July 27, 2026 12:21

claudeBot reviewed Jul 27, 2026
View reviewed changes

Comment threadsrc/runtime/modules/IOModule.cpp

claudeBot reviewed Jul 27, 2026
View reviewed changes

Comment threadsrc/runtime/modules/IOModule.cpp Outdated

claudeBot reviewed Jul 27, 2026
View reviewed changes

Comment threadsrc/runtime/modules/IOModule.cpp

Address review comments
2d09746

gf712 force-pushed the fix-buffer-flush branch from efcfb85 to 306cd11Compare July 27, 2026 13:45

claudeBot reviewed Jul 27, 2026
View reviewed changes

Comment threadintegration/run_python_tests.sh

Add buffered writer tests
81b0d4f

gf712 force-pushed the fix-buffer-flush branch from 306cd11 to 81b0d4fCompare July 27, 2026 14:06

claudeBot reviewed Jul 27, 2026
View reviewed changes

Comment threadsrc/runtime/modules/IOModule.cpp Outdated

claudeBot reviewed Jul 27, 2026
View reviewed changes

Address review comment
e97e80c

gf712 force-pushed the fix-buffer-flush branch from b9c384b to e97e80cCompare July 28, 2026 19:24

claudeBot reviewed Jul 28, 2026
View reviewed changes

gf712 merged commit 74079d9 into mainJul 28, 2026
4 checks passed

gf712 deleted the fix-buffer-flush branch July 28, 2026 19:42

gf712 added 5 commits July 20, 2026 20:08

runtime: wire isatty of buffered fileio textiowrapper (such as stdout)
90852c1

runtime: pass line_buffering arg when constructing stdout
07db39d

runtime: flush on newline
fee2c03

runtime: Add atexit callbacks
b20b52f

runtime: flush std file descriptors at exit
0984442

claudeBot reviewed Jul 27, 2026
View reviewed changes

Comment threadsrc/executable/bytecode/BytecodeProgram.cpp Outdated

claudeBot reviewed Jul 27, 2026
View reviewed changes

Comment threadsrc/runtime/modules/IOModule.cpp

claudeBot reviewed Jul 27, 2026
View reviewed changes

Comment threadsrc/executable/bytecode/BytecodeProgram.cpp

claudeBot reviewed Jul 27, 2026
View reviewed changes

Comment threadsrc/runtime/modules/IOModule.cpp

gf712 force-pushed the fix-buffer-flush branch from 0b2dff6 to efcfb85Compare July 27, 2026 12:21

claudeBot reviewed Jul 27, 2026
View reviewed changes

Comment threadsrc/runtime/modules/IOModule.cpp

claudeBot reviewed Jul 27, 2026
View reviewed changes

Comment threadsrc/runtime/modules/IOModule.cpp Outdated

claudeBot reviewed Jul 27, 2026
View reviewed changes

Comment threadsrc/runtime/modules/IOModule.cpp

Address review comments
2d09746

gf712 force-pushed the fix-buffer-flush branch from efcfb85 to 306cd11Compare July 27, 2026 13:45

claudeBot reviewed Jul 27, 2026
View reviewed changes

Comment threadintegration/run_python_tests.sh

Add buffered writer tests
81b0d4f

gf712 force-pushed the fix-buffer-flush branch from 306cd11 to 81b0d4fCompare July 27, 2026 14:06

claudeBot reviewed Jul 27, 2026
View reviewed changes

Comment threadsrc/runtime/modules/IOModule.cpp Outdated

claudeBot reviewed Jul 27, 2026
View reviewed changes

Address review comment
e97e80c

gf712 force-pushed the fix-buffer-flush branch from b9c384b to e97e80cCompare July 28, 2026 19:24

claudeBot reviewed Jul 28, 2026
View reviewed changes

gf712 merged commit 74079d9 into mainJul 28, 2026
4 checks passed

gf712 deleted the fix-buffer-flush branch July 28, 2026 19:42

gf712 added 5 commits July 20, 2026 20:08

runtime: wire isatty of buffered fileio textiowrapper (such as stdout)
90852c1

runtime: pass line_buffering arg when constructing stdout
07db39d

runtime: flush on newline
fee2c03

runtime: Add atexit callbacks
b20b52f

runtime: flush std file descriptors at exit
0984442

claudeBot reviewed Jul 27, 2026
View reviewed changes

Comment threadsrc/executable/bytecode/BytecodeProgram.cpp Outdated

claudeBot reviewed Jul 27, 2026
View reviewed changes

Comment threadsrc/runtime/modules/IOModule.cpp

claudeBot reviewed Jul 27, 2026
View reviewed changes

Comment threadsrc/executable/bytecode/BytecodeProgram.cpp

claudeBot reviewed Jul 27, 2026
View reviewed changes

Comment threadsrc/runtime/modules/IOModule.cpp

gf712 force-pushed the fix-buffer-flush branch from 0b2dff6 to efcfb85Compare July 27, 2026 12:21

claudeBot reviewed Jul 27, 2026
View reviewed changes

Comment threadsrc/runtime/modules/IOModule.cpp

claudeBot reviewed Jul 27, 2026
View reviewed changes

Comment threadsrc/runtime/modules/IOModule.cpp Outdated

claudeBot reviewed Jul 27, 2026
View reviewed changes

Comment threadsrc/runtime/modules/IOModule.cpp

Address review comments
2d09746

gf712 force-pushed the fix-buffer-flush branch from efcfb85 to 306cd11Compare July 27, 2026 13:45

claudeBot reviewed Jul 27, 2026
View reviewed changes

Comment threadintegration/run_python_tests.sh

Add buffered writer tests
81b0d4f

gf712 force-pushed the fix-buffer-flush branch from 306cd11 to 81b0d4fCompare July 27, 2026 14:06

claudeBot reviewed Jul 27, 2026
View reviewed changes

Comment threadsrc/runtime/modules/IOModule.cpp Outdated

claudeBot reviewed Jul 27, 2026
View reviewed changes

Address review comment
e97e80c

gf712 force-pushed the fix-buffer-flush branch from b9c384b to e97e80cCompare July 28, 2026 19:24

claudeBot reviewed Jul 28, 2026
View reviewed changes

gf712 merged commit 74079d9 into mainJul 28, 2026
4 checks passed

gf712 deleted the fix-buffer-flush branch July 28, 2026 19:42

gf712 added 5 commits July 20, 2026 20:08

runtime: wire isatty of buffered fileio textiowrapper (such as stdout)
90852c1

runtime: pass line_buffering arg when constructing stdout
07db39d

runtime: flush on newline
fee2c03

runtime: Add atexit callbacks
b20b52f

runtime: flush std file descriptors at exit
0984442

claudeBot reviewed Jul 27, 2026
View reviewed changes

Comment threadsrc/executable/bytecode/BytecodeProgram.cpp Outdated

claudeBot reviewed Jul 27, 2026
View reviewed changes

Comment threadsrc/runtime/modules/IOModule.cpp

claudeBot reviewed Jul 27, 2026
View reviewed changes

Comment threadsrc/executable/bytecode/BytecodeProgram.cpp

claudeBot reviewed Jul 27, 2026
View reviewed changes

Comment threadsrc/runtime/modules/IOModule.cpp

gf712 force-pushed the fix-buffer-flush branch from 0b2dff6 to efcfb85Compare July 27, 2026 12:21

claudeBot reviewed Jul 27, 2026
View reviewed changes

Comment threadsrc/runtime/modules/IOModule.cpp

claudeBot reviewed Jul 27, 2026
View reviewed changes

Comment threadsrc/runtime/modules/IOModule.cpp Outdated

claudeBot reviewed Jul 27, 2026
View reviewed changes

Comment threadsrc/runtime/modules/IOModule.cpp

Address review comments
2d09746

gf712 force-pushed the fix-buffer-flush branch from efcfb85 to 306cd11Compare July 27, 2026 13:45

claudeBot reviewed Jul 27, 2026
View reviewed changes

Comment threadintegration/run_python_tests.sh

Add buffered writer tests
81b0d4f

gf712 force-pushed the fix-buffer-flush branch from 306cd11 to 81b0d4fCompare July 27, 2026 14:06

claudeBot reviewed Jul 27, 2026
View reviewed changes

Comment threadsrc/runtime/modules/IOModule.cpp Outdated

claudeBot reviewed Jul 27, 2026
View reviewed changes

Address review comment
e97e80c

gf712 force-pushed the fix-buffer-flush branch from b9c384b to e97e80cCompare July 28, 2026 19:24

claudeBot reviewed Jul 28, 2026
View reviewed changes

gf712 merged commit 74079d9 into mainJul 28, 2026
4 checks passed

gf712 deleted the fix-buffer-flush branch July 28, 2026 19:42

gf712 added 5 commits July 20, 2026 20:08

runtime: wire isatty of buffered fileio textiowrapper (such as stdout)
90852c1

runtime: pass line_buffering arg when constructing stdout
07db39d

runtime: flush on newline
fee2c03

runtime: Add atexit callbacks
b20b52f

runtime: flush std file descriptors at exit
0984442

claudeBot reviewed Jul 27, 2026
View reviewed changes

Comment threadsrc/executable/bytecode/BytecodeProgram.cpp Outdated

claudeBot reviewed Jul 27, 2026
View reviewed changes

Comment threadsrc/runtime/modules/IOModule.cpp

claudeBot reviewed Jul 27, 2026
View reviewed changes

Comment threadsrc/executable/bytecode/BytecodeProgram.cpp

claudeBot reviewed Jul 27, 2026
View reviewed changes

Comment threadsrc/runtime/modules/IOModule.cpp

gf712 force-pushed the fix-buffer-flush branch from 0b2dff6 to efcfb85Compare July 27, 2026 12:21

claudeBot reviewed Jul 27, 2026
View reviewed changes

Comment threadsrc/runtime/modules/IOModule.cpp

claudeBot reviewed Jul 27, 2026
View reviewed changes

Comment threadsrc/runtime/modules/IOModule.cpp Outdated

claudeBot reviewed Jul 27, 2026
View reviewed changes

Comment threadsrc/runtime/modules/IOModule.cpp

Address review comments
2d09746

gf712 force-pushed the fix-buffer-flush branch from efcfb85 to 306cd11Compare July 27, 2026 13:45

claudeBot reviewed Jul 27, 2026
View reviewed changes

Comment threadintegration/run_python_tests.sh

Add buffered writer tests
81b0d4f

gf712 force-pushed the fix-buffer-flush branch from 306cd11 to 81b0d4fCompare July 27, 2026 14:06

claudeBot reviewed Jul 27, 2026
View reviewed changes

Comment threadsrc/runtime/modules/IOModule.cpp Outdated

claudeBot reviewed Jul 27, 2026
View reviewed changes

Address review comment
e97e80c

gf712 force-pushed the fix-buffer-flush branch from b9c384b to e97e80cCompare July 28, 2026 19:24

claudeBot reviewed Jul 28, 2026
View reviewed changes

gf712 merged commit 74079d9 into mainJul 28, 2026
4 checks passed

gf712 deleted the fix-buffer-flush branch July 28, 2026 19:42

Conversation

gf712 commented Jul 27, 2026

Uh oh!

Uh oh!

Uh oh!

claudeBot commented Jul 27, 2026

Code review

Uh oh!

Uh oh!

Uh oh!

claudeBot commented Jul 27, 2026

Code review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

claudeBot commented Jul 27, 2026

Code review

Uh oh!

Uh oh!

claudeBot commented Jul 27, 2026

Code review

Uh oh!

Uh oh!

claudeBot commented Jul 27, 2026

Code review

Uh oh!

claudeBotJul 27, 2026

Choose a reason for hiding this comment

Uh oh!

claudeBot commented Jul 27, 2026

Code review

Uh oh!

claudeBotJul 28, 2026

Choose a reason for hiding this comment

Uh oh!

claudeBot commented Jul 28, 2026

Code review

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

gf712 commented Jul 27, 2026

Uh oh!

Uh oh!

Uh oh!

claudeBot commented Jul 27, 2026

Code review

Uh oh!

Uh oh!

Uh oh!

claudeBot commented Jul 27, 2026

Code review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

claudeBot commented Jul 27, 2026

Code review

Uh oh!

Uh oh!

claudeBot commented Jul 27, 2026

Code review

Uh oh!

Uh oh!

claudeBot commented Jul 27, 2026

Code review

Uh oh!

claudeBotJul 27, 2026

Choose a reason for hiding this comment

Uh oh!

claudeBot commented Jul 27, 2026

Code review