From 450e596be311611e266ff03eb8069854ce96113b Mon Sep 17 00:00:00 2001 From: Casper Smits Date: Wed, 10 Nov 2021 14:12:22 +0100 Subject: [PATCH 1/2] Document reusable workflow limitation I discovered that reusable workflows do not support the `strategy` property and that was not documented anywhere. --- content/actions/learn-github-actions/reusing-workflows.md | 1 + 1 file changed, 1 insertion(+) diff --git a/content/actions/learn-github-actions/reusing-workflows.md b/content/actions/learn-github-actions/reusing-workflows.md index 5979351c4dab..f48a02d16bd6 100644 --- a/content/actions/learn-github-actions/reusing-workflows.md +++ b/content/actions/learn-github-actions/reusing-workflows.md @@ -48,6 +48,7 @@ A reusable workflow can be used by another workflow if any of the following is t * Reusable workflows can't call other reusable workflows. * Reusable workflows stored within a private repository can only be used by workflows within the same repository. * Any environment variables set in an `env` context defined at the workflow level in the caller workflow are not propagated to the called workflow. For more information about the `env` context, see "[Context and expression syntax for GitHub Actions](/actions/reference/context-and-expression-syntax-for-github-actions#env-context)." +* Reusable workflows do not support the `strategy` property. The following limitations will be removed when workflow reuse moves out of beta: * You can't set the concurrency of a called workflow from the caller workflow. For more information about `jobs..concurrency`, see "[Workflow syntax for GitHub Actions](/actions/learn-github-actions/workflow-syntax-for-github-actions#jobsjob_idconcurrency)." From 5a464553d5eb0a7122145ae5cb5b0c2d32352174 Mon Sep 17 00:00:00 2001 From: Sarah Edwards Date: Tue, 30 Nov 2021 16:22:40 -0800 Subject: [PATCH 2/2] specify when strategy cannot be used --- content/actions/learn-github-actions/reusing-workflows.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/content/actions/learn-github-actions/reusing-workflows.md b/content/actions/learn-github-actions/reusing-workflows.md index 4f448c68212f..762284674b98 100644 --- a/content/actions/learn-github-actions/reusing-workflows.md +++ b/content/actions/learn-github-actions/reusing-workflows.md @@ -70,7 +70,7 @@ Called workflows can access self-hosted runners from caller's context. This mean * Reusable workflows stored within a private repository can only be used by workflows within the same repository. * Any environment variables set in an `env` context defined at the workflow level in the caller workflow are not propagated to the called workflow. For more information about the `env` context, see "[Context and expression syntax for GitHub Actions](/actions/reference/context-and-expression-syntax-for-github-actions#env-context)." * You can't set the concurrency of a called workflow from the caller workflow. For more information about `jobs..concurrency`, see "[Workflow syntax for GitHub Actions](/actions/learn-github-actions/workflow-syntax-for-github-actions#jobsjob_idconcurrency)." -* Reusable workflows do not support the `strategy` property. +* The `strategy` property is not supported in any job that calls a reusable workflow. ## Creating a reusable workflow