Uh oh!
There was an error while loading. Please reload this page.
feat: use menubar-managed popup behavior - #3280
Merged
Merged
Conversation
Use the pop-up-menu stacking level on Windows and control click-away dismissal separately. Preserve pin preferences and DevTools behavior. Requires the unreleased electron-menubar hideOnBlur option. Validated against the linked local library; update the dependency before publishing. Related: #1048
afonsojramos
marked this pull request as draft
September 5, 2026 22:59
afonsojramos
marked this pull request as ready for review
September 5, 2026 23:27
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Gitify delegates popup focus and stacking to electron-menubar so Windows tray overflow, desktop docks, keep-open preferences, and DevTools behavior do not require platform checks in the app's focus code. The keep-open handler now forwards one option; Gitify retains its DevTools dimensions and layout.
Uses the published electron-menubar 11.0.0 release, including gitify-app/electron-menubar#185. The dependency now owns popup stacking and DevTools focus behavior; Gitify only forwards the keep-open preference and controls its DevTools layout.
Fixes#1048.
Fixes#2751.