Skip to content

Add py_proto_library support (rules_python approach) - #318

Draft
sergiitk wants to merge 1 commit into
cel-expr:masterfrom
sergiitk:py_proto_libraries
Draft

Add py_proto_library support (rules_python approach)#318
sergiitk wants to merge 1 commit into
cel-expr:masterfrom
sergiitk:py_proto_libraries

Conversation

@sergiitk

@sergiitksergiitk commented Oct 6, 2023

Copy link
Copy Markdown

Needed to add the support of the new stable CEL to cncf/xds/type/v3/cel.proto. This will bring the new CEL into Envoy and gRPC xDS.

ref cncf/xds#69

@sergiitk

Copy link
Copy Markdown
Author

cc @l46kok

@l46kok

Copy link
Copy Markdown
Collaborator

/gcbrun

@TristonianJones

Copy link
Copy Markdown
Collaborator

/gcbrun

@sergiitk

Copy link
Copy Markdown
Author

I'm a bit unsure if using rules_python is too early. The majority of the community is using py_proto_library from old-style packages, e.g. @com_google_protobuf//:protobuf.bzl or @com_github_grpc_grpc//bazel:python_rules.bzl. I'll continue looking into this.

@sergiitksergiitk changed the title Add py_proto_library supportAdd py_proto_library support (rules_python approach)Nov 9, 2023
@ferstlfferstlf mentioned this pull request Mar 28, 2025
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@sergiitk@l46kok@TristonianJones