Uh oh!
There was an error while loading. Please reload this page.
Implemented automatic caching for the discovery documents. - #127
Conversation
tmatsuo
commented
Aug 19, 2015
@nathanielmanistaatgoogle I'd appreciate it if you could take a look. |
tmatsuo
commented
Aug 20, 2015
@dhermes FYI |
dhermes
commented
Aug 20, 2015
Wow. So happy this is coming (3 years later)! /cc @wescpy This is what we talked about at SFPython |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
nathanielmanistaatgoogle
commented
Aug 20, 2015
Please squash commits. |
tmatsuo
commented
Aug 20, 2015
Thanks for the comment @nathanielmanistaatgoogle All addressed, PTAL |
tmatsuo
commented
Aug 20, 2015
Let me write some tests. I'll update here once done. |
tmatsuo
commented
Aug 21, 2015
I added some tests in test_discovery. PTAL |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
nathanielmanistaatgoogle
commented
Aug 23, 2015
@dhermes are you also reviewing this or just excited about it happening? |
dhermes
commented
Aug 23, 2015
I am not reviewing. |
tmatsuo
commented
Aug 23, 2015
@nathanielmanistaatgoogle |
nathanielmanistaatgoogle
commented
Aug 23, 2015
Looks good. Are there more unit tests still to come or is this what you'd like to have merged? |
tmatsuo
commented
Aug 23, 2015
@nathanielmanistaatgoogle Thanks! |
nathanielmanistaatgoogle
commented
Aug 23, 2015
Great; I'll hold steady until I hear more from you. |
782ba62 to
1e10bfaComparetmatsuo
commented
Aug 24, 2015
I have just added a unit test for the file cache, which discovered several bugs in my code! @nathanielmanistaatgoogle Now I'm confident to say "let's merge this". PTAL |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Implemented automatic caching for discovery documents.
nathanielmanistaatgoogle
commented
Aug 24, 2015
Thanks for the contribution! |
tmatsuo
commented
Aug 24, 2015
Thanks for the review! I'm wondering when it goes to pypi distribution so that everyone can benefit from it. |
nathanielmanistaatgoogle
commented
Aug 24, 2015
Likely not this week; we're swamped with other things. Perhaps toward the end of next week? Would that be acceptable? Otherwise "sometime in September"? |
tmatsuo
commented
Aug 24, 2015
Yeah, sounds good, thanks |
tmatsuo
commented
Sep 3, 2015
Ok, will you be able to do the release this week? If you still have other things, maybe I can do the release, especially if there's how-to doc. Let me know if you want me to do. |
tmatsuo
commented
Sep 10, 2015
To clarify, I have uploaded a small library to pypi before, so I know the basic. My username on pypi is tmatsuo, so maybe you can add me to the owners list of this package on pypi so that I can do the release? My current guess for how to release is that:
|
tmatsuo
commented
Sep 14, 2015
JFYI it's released. |
tmatsuo
commented
Sep 24, 2015
@dhermes I haven't seen any issues with the new release for a week, so I removed your original article about cache on App Engine. Thanks! |
dhermes
commented
Sep 24, 2015
You could have just marked it deprecated. Now I have one less imprint on Google Developers 😞 |
tmatsuo
commented
Sep 24, 2015
Yeah, in that sense, I initially tried to mark it as deprecated, but tech writers don't like it. You're doing a greater work on gcloud-python, so I thought you're ok, but let me know if you want it back strongly. |
dhermes
commented
Sep 24, 2015
Ha no worries Takashi! I was just giving you a hard time. Thanks! |
Added 2 keyword arguments; cache_discovery and cache. You can suppress caching by setting cache_discovery=False. You can inject your own caching module via the cache kwarg.
It automatically uses app engine memcache if it's detected. It's not a hard dependency. Then fall back to file based caching.
fixes#110