Uh oh!
There was an error while loading. Please reload this page.
fix(sqlalchemy-bigquery): wrap string in WKT in geography system tests - #17780
Conversation
There was a problem hiding this comment.
Code Review
This pull request unskips several GeoAlchemy2 system tests (test_geoalchemy2_core, test_geoalchemy2_orm, and test_geoalchemy2_orm_w_relationship) in packages/sqlalchemy-bigquery/tests/system/test_geography.py. To resolve the previous failures, the spatial string literals in the queries are now wrapped with WKT imported from sqlalchemy_bigquery. There are no review comments, and I have no additional feedback to provide.
parthea
left a comment
There was a problem hiding this comment.
LGTM but holding off on formal approval. Please also update the unit test here
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Wraps spatial string parameters with
WKT(...)in ST_Contains andST_Intersectssystem test queries. This ensures GeoAlchemy2 compilesST_GeogFromText(...)so BigQuery receivesGEOGRAPHYparameters instead of throwing argument type mismatch errors (GEOGRAPHY, STRING). Unskips geography system tests.Towards #17287 🦕