Uh oh!
There was an error while loading. Please reload this page.
fix(sqlalchemy-spanner): fix get_multi_indexes crash on SEARCH indexes - #17907
Conversation
There was a problem hiding this comment.
Code Review
This pull request updates the Spanner dialect to exclude SEARCH indexes from the results of get_multi_indexes and improves robustness when handling null or missing column orderings. It also adds unit tests to verify these changes. The reviewer suggested a cleaner approach for handling columns without explicit sorting by omitting them from the column_sorting dictionary entirely instead of mapping them to None, which aligns better with SQLAlchemy standards. Corresponding updates to the unit tests were also recommended.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
afe57b1 to
7b0f4c0Compare7b0f4c0 to
cfc408fCompareUh oh!
There was an error while loading. Please reload this page.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> 🦕