From b3f63f1f5475127c3d221f883c487e1bb9f2d3e8 Mon Sep 17 00:00:00 2001 From: Jon Wayne Parrott Date: Thu, 18 Jan 2018 14:56:18 -0800 Subject: [PATCH 1/2] Make row assertion account for non-deterministic order --- docs/bigquery/snippets.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/docs/bigquery/snippets.py b/docs/bigquery/snippets.py index 9c7d3d975eb3..41872aad73e1 100644 --- a/docs/bigquery/snippets.py +++ b/docs/bigquery/snippets.py @@ -491,7 +491,9 @@ def do_something(row): ] assert len(rows) == total == 2 assert token is None - assert rows == expected_rows + # Order is not preserved, so compare individually + for row in expected_rows: + assert row in rows def test_load_table_from_uri(client, to_delete): From e07a8620bd75ab62441991ca048122f59acc803a Mon Sep 17 00:00:00 2001 From: Jon Wayne Parrott Date: Thu, 18 Jan 2018 15:10:35 -0800 Subject: [PATCH 2/2] Let that loop unroll and be wild and free --- docs/bigquery/snippets.py | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/docs/bigquery/snippets.py b/docs/bigquery/snippets.py index 41872aad73e1..88715bc754a6 100644 --- a/docs/bigquery/snippets.py +++ b/docs/bigquery/snippets.py @@ -485,15 +485,13 @@ def do_something(row): token = iterator.next_page_token # [END table_list_rows_iterator_properties] - expected_rows = [ - bigquery.Row(('Wylma Phlyntstone', 29), {'full_name': 0, 'age': 1}), - bigquery.Row(('Phred Phlyntstone', 32), {'full_name': 0, 'age': 1}), - ] assert len(rows) == total == 2 assert token is None # Order is not preserved, so compare individually - for row in expected_rows: - assert row in rows + row1 = bigquery.Row(('Wylma Phlyntstone', 29), {'full_name': 0, 'age': 1}) + assert row1 in rows + row2 = bigquery.Row(('Phred Phlyntstone', 32), {'full_name': 0, 'age': 1}) + assert row2 in rows def test_load_table_from_uri(client, to_delete):