Skip to content
This repository was archived by the owner on Sep 11, 2023. It is now read-only.

fix: the bom module was missing in the root pom - #359

Merged
gcf-merge-on-green[bot] merged 1 commit into
mainfrom
suztomo-patch-1
Jul 8, 2022
Merged

fix: the bom module was missing in the root pom#359
gcf-merge-on-green[bot] merged 1 commit into
mainfrom
suztomo-patch-1

Conversation

@suztomo

@suztomosuztomo commented Jul 8, 2022

Copy link
Copy Markdown
Member

The bom module was missing in the root pom. It caused build failure in another issue in google-cloud-java repository: googleapis/google-cloud-java#7991 (comment)

Other repositories declare the bom module correctly. Example: https://github.com/googleapis/java-accessapproval/blob/main/pom.xml#L116

@suztomo
suztomo requested a review from a teamJuly 8, 2022 18:50
@product-auto-labelproduct-auto-labelBot added size: xs Pull request size is extra small. api: accesscontextmanager Issues related to the googleapis/java-accesscontextmanager API. labels Jul 8, 2022
@suztomosuztomo added the automerge Merge the pull request once unit tests and other checks pass. label Jul 8, 2022
@gcf-merge-on-green
gcf-merge-on-greenBot merged commit 2af19cd into mainJul 8, 2022
@gcf-merge-on-green
gcf-merge-on-greenBot deleted the suztomo-patch-1 branch July 8, 2022 19:08
@gcf-merge-on-greengcf-merge-on-greenBot removed the automerge Merge the pull request once unit tests and other checks pass. label Jul 8, 2022
@release-pleaserelease-pleaseBot mentioned this pull request Jul 8, 2022
gcf-merge-on-greenBot pushed a commit that referenced this pull request Aug 9, 2022
🤖 I have created a release *beep* *boop*
---
## [1.4.1](v1.4.0...v1.4.1) (2022-08-02)
### Bug Fixes
* enable longpaths support for windows test ([#1485](https://github.com/googleapis/java-accesscontextmanager/issues/1485)) ([#361](#361)) ([7c1172c](7c1172c))
* the bom module was missing in the root pom ([#359](#359)) ([2af19cd](2af19cd))
### Dependencies
* update dependency com.google.cloud:google-cloud-shared-dependencies to v3 ([#366](#366)) ([3b2f972](3b2f972))
---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
github-actionsBot pushed a commit to googleapis/google-cloud-java that referenced this pull request Aug 9, 2022
🤖 I have created a release *beep* *boop*
---
## [1.4.1](googleapis/java-accesscontextmanager@v1.4.0...v1.4.1) (2022-08-02)
### Bug Fixes
* enable longpaths support for windows test ([#1485](https://github.com/googleapis/java-accesscontextmanager/issues/1485)) ([#361](googleapis/java-accesscontextmanager#361)) ([8d202d0](googleapis/java-accesscontextmanager@8d202d0))
* the bom module was missing in the root pom ([#359](googleapis/java-accesscontextmanager#359)) ([476e618](googleapis/java-accesscontextmanager@476e618))
### Dependencies
* update dependency com.google.cloud:google-cloud-shared-dependencies to v3 ([#366](googleapis/java-accesscontextmanager#366)) ([fba08eb](googleapis/java-accesscontextmanager@fba08eb))
---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: accesscontextmanagerIssues related to the googleapis/java-accesscontextmanager API.size: xsPull request size is extra small.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@suztomo@blakeli0@alicejli