Skip to content
This repository was archived by the owner on Mar 23, 2026. It is now read-only.

feat: add additional parameters to CsvOptions and ParquetOptions - #3370

Merged
PhongChuong merged 5 commits into
mainfrom
ExternalTableDefinitionOptions
Jun 28, 2024
Merged

feat: add additional parameters to CsvOptions and ParquetOptions#3370
PhongChuong merged 5 commits into
mainfrom
ExternalTableDefinitionOptions

Conversation

@PhongChuong

@PhongChuongPhongChuong commented Jun 27, 2024•
edited
Loading

Copy link
Copy Markdown
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes#3369 ☕️

@product-auto-labelproduct-auto-labelBot added size: m Pull request size is medium. api: bigquery Issues related to the googleapis/java-bigquery API. labels Jun 27, 2024
@PhongChuongPhongChuong added the owlbot:run Add this label to trigger the Owlbot post processor. label Jun 27, 2024
@gcf-owl-botgcf-owl-botBot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jun 27, 2024
@PhongChuong
PhongChuong marked this pull request as ready for review June 27, 2024 15:52
@PhongChuong
PhongChuong requested review from a teamJune 27, 2024 15:52
shollyman
shollyman approved these changes Jun 27, 2024
View reviewed changes

@shollymanshollyman left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks good, a couple of minor questions.

Comment threadgoogle-cloud-bigquery/src/main/java/com/google/cloud/bigquery/CsvOptions.java Outdated
Comment threadgoogle-cloud-bigquery/src/main/java/com/google/cloud/bigquery/ParquetOptions.java
PhongChuong
PhongChuong commented Jun 27, 2024
View reviewed changes

@PhongChuongPhongChuong left a comment

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the review. Updated to address the comments. PTAL.

Comment threadgoogle-cloud-bigquery/src/main/java/com/google/cloud/bigquery/ParquetOptions.java
Comment threadgoogle-cloud-bigquery/src/main/java/com/google/cloud/bigquery/CsvOptions.java Outdated
@PhongChuong
PhongChuong merged commit 34f16fb into mainJun 28, 2024
@PhongChuong
PhongChuong deleted the ExternalTableDefinitionOptions branch June 28, 2024 14:53
@release-pleaserelease-pleaseBot mentioned this pull request Jul 3, 2024
Merged
This was referenced Jul 30, 2024
Closed
Closed
Closed
lqiu96 pushed a commit that referenced this pull request Aug 28, 2024
@PhongChuong@gcf-owl-bot@lqiu96
feat: add additional parameters to CsvOptions and ParquetOptions (#3370)
a626bc6
* feat: add additional parameters to CsvOptions and ParquetOptions
* fix lint
* 🦉 Updates from OwlBot post-processor
See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md
* Addressed review comments
---------
Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
@release-pleaserelease-pleaseBot mentioned this pull request Dec 15, 2025
Merged
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
@shollymanshollymanshollyman approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: bigqueryIssues related to the googleapis/java-bigquery API.size: mPull request size is medium.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Support additional CsvOptions and ParquetOptions

2 participants

@PhongChuong@shollyman