Uh oh!
There was an error while loading. Please reload this page.
This repository was archived by the owner on Feb 23, 2026. It is now read-only.
fix: undeprecate entity factory helpers - #101
Merged
Merged
Conversation
parthea
commented
Jun 25, 2021
Contributor
Hi @tseaver , Can you please confirm if this PR is still relevant? |
tseaver
commented
Jun 25, 2021
ContributorAuthor
Yes, I've just not been able to get anyone's attention to review it. |
tseaver
commented
Jun 25, 2021
ContributorAuthor
I made the argument over in issue #100 that these deprecations were done in error: they were part of a change which deprecated one thing for real, but was over-zealous in the execution. |
parthea
approved these changes
Jun 27, 2021
This was referenced May 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes#100