Skip to content
This repository was archived by the owner on Feb 23, 2026. It is now read-only.

feat: retry google.auth TransportError and requests ConnectionError - #178

Merged
gcf-merge-on-green[bot] merged 1 commit into
googleapis:masterfrom
parthea:additional-transient-errors
May 3, 2021
Merged

feat: retry google.auth TransportError and requests ConnectionError#178
gcf-merge-on-green[bot] merged 1 commit into
googleapis:masterfrom
parthea:additional-transient-errors

Conversation

@parthea

Copy link
Copy Markdown
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes#176 🦕

@partheaparthea self-assigned this May 2, 2021
@parthea
parthea requested a review from a teamMay 2, 2021 10:21
@google-clagoogle-claBot added the cla: yes This human has signed the Contributor License Agreement. label May 2, 2021
@parthea
parthea requested a review from busunkim96May 2, 2021 10:21

@busunkim96busunkim96 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a way for a bare requests.exception to make it to this code? I was under the impression the auth library would always wrap it.

Otherwise LGTM.

@parthea

Copy link
Copy Markdown
ContributorAuthor

@busunkim96 Here is an example of requests.exception in the stack trace in python-bigquery via googleapis/python-bigquery#434.

@partheaparthea added the automerge Merge the pull request once unit tests and other checks pass. label May 3, 2021
@gcf-merge-on-green
gcf-merge-on-greenBot merged commit 6ae04a8 into googleapis:masterMay 3, 2021
@gcf-merge-on-greengcf-merge-on-greenBot removed the automerge Merge the pull request once unit tests and other checks pass. label May 3, 2021
This was referenced May 30, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla: yesThis human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

requests.exceptions.ConnectionError retry

2 participants

@parthea@busunkim96