feat: add grpc transcoding + tests by yihjenku · Pull Request #259 · googleapis/python-api-core

yihjenku · 2021-08-25T17:19:35Z

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
Ensure the tests and linter pass
Code coverage does not decrease (if any source code was changed)
Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

tseaver

@yihjenku Thank you very much for the patch! I've tagged the Owlbot to run here, which should fix any linting issues (black wants spaces between key and value in dict comprehensions, for instance). The testcases look well-thought out.

tseaver · 2021-08-25T19:29:58Z

Coverage failure flake reported in #260.

…on-api-core into transcode-takeover

vam-google

LGTM, but please keep in mind that we may have to circle back to optimize the implementation if it does not meet Ads performance requirements.

…on-api-core into transcode-takeover

feat: add grpc transcoding + tests
598ca88

yihjenku requested a review from a teamAugust 25, 2021 17:19

google-claBot added the cla: yes This human has signed the Contributor License Agreement. label Aug 25, 2021

tseaver added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Aug 25, 2021

yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 25, 2021

🦉 Updates from OwlBot
a956abb
See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

gcf-owl-botBot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 25, 2021

tseaver reviewed Aug 25, 2021
View reviewed changes

Comment threadgoogle/api_core/path_template.py Outdated

parthea added the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 25, 2021

gcf-owl-botBot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 25, 2021

parthea mentioned this pull request Aug 25, 2021
bug: identify and silence owl-bot post-processor failures when PRs attempt to push to a branch on which the post-processor has already run googleapis/repo-automation-bots#2307
Closed

tseaver reviewed Aug 25, 2021
View reviewed changes

Comment threadgoogle/api_core/path_template.py Outdated

chore: tweak for clarity / idiomatic usage
1ca321a

tseaver reviewed Aug 25, 2021
View reviewed changes

Comment threadtests/unit/test_path_template.py

tseaver added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Aug 25, 2021

gcf-owl-botBot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 25, 2021

yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 25, 2021

tseaver reviewed Aug 25, 2021
View reviewed changes

Comment threadgoogle/api_core/path_template.py

chore: attempt to appease Sphinx
f8725d9

tseaver added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Aug 25, 2021

yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 25, 2021

gcf-owl-botBot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 25, 2021

tseaver added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 25, 2021

yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 25, 2021

parthea assigned yihjenku Sep 1, 2021

feat: add grpc transcoding + tests
79f561f

yihjenkuand others added 3 commits September 2, 2021 17:08

Merge changes.
6b6dd7b

Merge branch 'transcode-takeover' ofhttps://github.com/yihjenku/pyth…
01df2c6
…on-api-core into transcode-takeover

Merge branch 'main' into transcode-takeover
5a04dcd

kbandes reviewed Sep 3, 2021
View reviewed changes

Comment threadgoogle/api_core/path_template.py

kbandes reviewed Sep 3, 2021
View reviewed changes

Comment threadgoogle/api_core/path_template.py Outdated

kbandes reviewed Sep 3, 2021
View reviewed changes

Comment threadgoogle/api_core/path_template.py Outdated

yihjenkuand others added 3 commits September 7, 2021 14:49

Merge branch 'main' into transcode-takeover
1b827a2

Add functions to properly handle subfields
51661d3

Merge branch 'transcode-takeover' ofhttps://github.com/yihjenku/pyth…
2dfbc28
…on-api-core into transcode-takeover

jameslynnwu reviewed Sep 9, 2021
View reviewed changes

Comment threadgoogle/api_core/path_template.py Outdated

Add unit tests for get_field and delete_field.
12a4436

alexander-fenster reviewed Sep 10, 2021
View reviewed changes

Comment threadgoogle/api_core/path_template.py

alexander-fenster approved these changes Sep 10, 2021
View reviewed changes

yihjenku requested a review from tseaver September 10, 2021 14:22

vam-google approved these changes Sep 10, 2021
View reviewed changes

Comment threadgoogle/api_core/path_template.py

vam-google requested review from a teamSeptember 10, 2021 23:15

busunkim96 reviewed Sep 11, 2021
View reviewed changes

Comment threadgoogle/api_core/path_template.py
Comment threadgoogle/api_core/path_template.py Outdated
Comment threadgoogle/api_core/path_template.py Outdated
Comment threadgoogle/api_core/path_template.py

Add function docstrings and incorporate correct native dict functions.
28f587d

busunkim96 approved these changes Sep 14, 2021
View reviewed changes

yihjenku added 6 commits September 15, 2021 17:05

Add function docstrings and incorporate correct native dict functions.
928e3fb

Merge branch 'transcode-takeover' ofhttps://github.com/yihjenku/pyth…
6d61e4c
…on-api-core into transcode-takeover

Increase code coverage
97c5697

Increase code coverage
1450b91

Increase code coverage
4c157a9

Reformat files
c99e7bb

vam-google merged commit afe0fa1 into googleapis:mainSep 15, 2021

This was referenced May 30, 2025
chore(main): release 2.0.0 #822
Closed
chore(main): release 2.0.0 #823
Closed

Navigation Menu

Uh oh!

feat: add grpc transcoding + tests - #259

feat: add grpc transcoding + tests#259
vam-google merged 20 commits into
googleapis:mainfrom
yihjenku:transcode-takeover

yihjenku commented Aug 25, 2021•
edited
Loading

Uh oh!

tseaver left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

tseaver commented Aug 25, 2021

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

vam-google left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

Uh oh!

Conversation

yihjenku commented Aug 25, 2021• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

tseaver left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

tseaver commented Aug 25, 2021

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

vam-google left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

yihjenku commented Aug 25, 2021•
edited
Loading