Skip to content
This repository was archived by the owner on Feb 23, 2026. It is now read-only.

fix: add warning to retry target to avoid incorrect usage - #543

Merged
ohmayr merged 4 commits into
mainfrom
add-warning-to-retry
Nov 3, 2023
Merged

fix: add warning to retry target to avoid incorrect usage#543
ohmayr merged 4 commits into
mainfrom
add-warning-to-retry

Conversation

@ohmayr

@ohmayrohmayr commented Oct 26, 2023

Copy link
Copy Markdown
Contributor

Fixes#542 🦕

@ohmayr
ohmayr requested review from a teamOctober 26, 2023 01:07
@product-auto-labelproduct-auto-labelBot added the size: xs Pull request size is extra small. label Oct 26, 2023
@ohmayr
ohmayrforce-pushed the add-warning-to-retry branch 5 times, most recently from 29a7c83 to f5eb290CompareOctober 26, 2023 19:51
@product-auto-labelproduct-auto-labelBot added size: s Pull request size is small. and removed size: xs Pull request size is extra small. labels Oct 26, 2023
@ohmayrohmayr changed the title add warning to retry_target to avoid incorrect usageadd warning to retry target to avoid incorrect usageOct 26, 2023
@ohmayrohmayr changed the title add warning to retry target to avoid incorrect usagefix: add warning to retry target to avoid incorrect usageOct 26, 2023
@ohmayr
ohmayrforce-pushed the add-warning-to-retry branch 6 times, most recently from 95bcc0f to 12d5c35CompareOctober 27, 2023 00:22
vchudnov-g
vchudnov-g reviewed Oct 27, 2023
View reviewed changes
Comment threadgoogle/api_core/retry.py Outdated
@ohmayr
ohmayrforce-pushed the add-warning-to-retry branch 2 times, most recently from 4e04b7d to 11b5e02CompareOctober 27, 2023 17:21
vchudnov-g
vchudnov-g suggested changes Oct 27, 2023
View reviewed changes

@vchudnov-gvchudnov-g left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's looking good, but just a few questions/comments.

Comment threadtests/asyncio/test_retry_async.py Outdated
Comment threadtests/asyncio/test_retry_async.py Outdated
Comment threadgoogle/api_core/operations_v1/operations_async_client.py Outdated
@ohmayr
ohmayrforce-pushed the add-warning-to-retry branch from 934fa4a to 663fb2fCompareOctober 30, 2023 02:03
@ohmayr
ohmayrforce-pushed the add-warning-to-retry branch from 4675b44 to 5cdba7bCompareNovember 3, 2023 16:40
vchudnov-g
vchudnov-g approved these changes Nov 3, 2023
View reviewed changes
Comment threadtests/unit/test_retry.py
@ohmayr
ohmayrforce-pushed the add-warning-to-retry branch from 08c22b3 to 08ddc27CompareNovember 3, 2023 17:14
@ohmayr
ohmayr merged commit bfb40e6 into mainNov 3, 2023
@ohmayr
ohmayr deleted the add-warning-to-retry branch November 3, 2023 19:30
@release-pleaserelease-pleaseBot mentioned this pull request Nov 3, 2023
Merged
@daniel-sanchedaniel-sanche mentioned this pull request May 3, 2024
Merged
This was referenced May 30, 2025
Closed
Closed
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
@vchudnov-gvchudnov-gvchudnov-g approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

size: sPull request size is small.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Raise a warning in google.api_core.retry.retry_target if the return value is awaitable

2 participants

@ohmayr@vchudnov-g