Skip to content
This repository was archived by the owner on Feb 23, 2026. It is now read-only.

feat: add support for python 3.13 - #696

Merged
parthea merged 11 commits into
mainfrom
add-python-313
Oct 15, 2024
Merged

feat: add support for python 3.13#696
parthea merged 11 commits into
mainfrom
add-python-313

Conversation

@parthea

@partheaparthea commented Sep 13, 2024

Copy link
Copy Markdown
Contributor

Fixes#695 🦕

@partheaparthea added the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 13, 2024
@gcf-owl-botgcf-owl-botBot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 13, 2024
@product-auto-labelproduct-auto-labelBot added the size: s Pull request size is small. label Sep 13, 2024
@partheaparthea added the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 13, 2024
@gcf-owl-botgcf-owl-botBot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 13, 2024
@parthea

parthea commented Sep 13, 2024•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

Blocked by grpc/grpc#34922

@partheaparthea added the status: blocked Resolving the issue is dependent on other work. label Sep 13, 2024
@partheaparthea self-assigned this Oct 9, 2024
@partheaparthea removed the status: blocked Resolving the issue is dependent on other work. label Oct 9, 2024
@parthea
parthea marked this pull request as ready for review October 9, 2024 17:12
@parthea
parthea requested review from a teamOctober 9, 2024 17:12
@partheaparthea removed their assignment Oct 9, 2024
ohmayr
ohmayr approved these changes Oct 15, 2024
View reviewed changes
Comment threadnoxfile.py
"google-auth",
"googleapis-common-protos",
"grpcio",
# Exclude grpcio!=1.67.0rc1 which does not support python 3.13

@ohmayrohmayrOct 15, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to disable the rc version? My assumption is that the latest stable version is installed by default.

@partheapartheaOct 15, 2024

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Without this change, the pre-release test fails (See https://github.com/googleapis/python-api-core/actions/runs/11259852849/job/31309789274)

Do we need to disable the rc version? My assumption is that the latest stable version is installed by default.

We don't get the stable version in the prerelease_deps nox session. We get the latest pre-release which is https://pypi.org/project/grpcio/1.67.0rc1/. We're not disabling all rc versions, just 1.67.0rc1 which doesn't support python 3.13

Comment threadnoxfile.py Outdated
@parthea@ohmayr
Update comment
5fb2a14
Co-authored-by: ohmayr <omairnaveed@ymail.com>
@parthea
parthea merged commit 46b3d3a into mainOct 15, 2024
@parthea
parthea deleted the add-python-313 branch October 15, 2024 16:49
@release-pleaserelease-pleaseBot mentioned this pull request Oct 9, 2024
Merged
@partheaparthea mentioned this pull request Oct 23, 2024
Closed
This was referenced May 30, 2025
Closed
Closed
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
@ohmayrohmayrohmayr approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@ohmayrohmayr

Labels

size: sPull request size is small.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add support for Python 3.13

2 participants

@parthea@ohmayr