Skip to content
This repository was archived by the owner on Feb 23, 2026. It is now read-only.

feat: add automatic logging config to support debug logging - #754

Merged
parthea merged 18 commits into
mainfrom
debug-logging
Dec 2, 2024
Merged

feat: add automatic logging config to support debug logging#754
parthea merged 18 commits into
mainfrom
debug-logging

Conversation

@ohmayr

@ohmayrohmayr commented Nov 4, 2024•
edited by parthea
Loading

Copy link
Copy Markdown
Contributor

Implement automatic logging config to allow users to enable debug logging via an environment variable.

Fixes b/381099872

@product-auto-labelproduct-auto-labelBot added the size: s Pull request size is small. label Nov 4, 2024
@product-auto-labelproduct-auto-labelBot added size: m Pull request size is medium. and removed size: s Pull request size is small. labels Nov 11, 2024
vchudnov-g
vchudnov-g reviewed Nov 22, 2024
View reviewed changes
Comment threadgoogle/api_core/client_logging.py Outdated
Comment threadgoogle/api_core/client_logging.py Outdated
Comment threadgoogle/api_core/client_logging.py Outdated
Comment threadgoogle/api_core/client_logging.py Outdated
Comment threadtests/unit/test_client_logging.py Outdated
Comment threadtests/unit/test_client_logging.py
@ohmayrohmayr changed the title feat: add base logger to enable debug loggingfeat: add automatic logging config to support debug loggingNov 25, 2024
vchudnov-g
vchudnov-g reviewed Nov 26, 2024
View reviewed changes
Comment threadgoogle/api_core/client_logging.py Outdated
Comment threadtests/unit/test_client_logging.py Outdated
Comment threadgoogle/api_core/client_logging.py Outdated
Comment threadtests/unit/test_client_logging.py Outdated
Comment threadtests/unit/test_client_logging.py Outdated
Comment threadtests/unit/test_client_logging.py Outdated
@ohmayr
ohmayr marked this pull request as ready for review November 26, 2024 18:48
@ohmayr
ohmayr requested review from a teamNovember 26, 2024 18:48
parthea
parthea reviewed Nov 26, 2024
View reviewed changes
Comment threadgoogle/api_core/client_logging.py Outdated
parthea
parthea reviewed Nov 26, 2024
View reviewed changes
Comment threadgoogle/api_core/client_logging.py
parthea
parthea reviewed Nov 26, 2024
View reviewed changes
Comment threadgoogle/api_core/client_logging.py Outdated
parthea
parthea reviewed Nov 26, 2024
View reviewed changes
Comment threadgoogle/api_core/client_logging.py
vchudnov-g
vchudnov-g reviewed Nov 26, 2024
View reviewed changes
Comment threadgoogle/api_core/client_logging.py Outdated
Comment threadgoogle/api_core/client_logging.py
Comment threadtests/unit/test_client_logging.py Outdated
Comment threadtests/unit/test_client_logging.py
Comment threadtests/unit/test_client_logging.py Outdated
Comment threadtests/unit/test_client_logging.py
Comment threadgoogle/api_core/client_logging.py
@product-auto-labelproduct-auto-labelBot added size: l Pull request size is large. and removed size: m Pull request size is medium. labels Nov 27, 2024
parthea
parthea reviewed Nov 27, 2024
View reviewed changes
Comment threadgoogle/api_core/client_logging.py Outdated
Comment threadgoogle/api_core/client_logging.py Outdated
Comment threadgoogle/api_core/client_logging.py Outdated
parthea
parthea reviewed Nov 28, 2024
View reviewed changes
Comment threadgoogle/api_core/client_logging.py
# Fields to be included in the StructuredLogFormatter.
#
# TODO(https://github.com/googleapis/python-api-core/issues/761): Update this list to support additional logging fields.
_recognized_logging_fields = [

@partheapartheaNov 28, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One thing to note is that users will need to update google-api-core to get any additional logging fields in the future.

@ohmayrohmayrDec 2, 2024

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is true. Any fields that we add in the future will require users to update google-api-core.

parthea
parthea reviewed Nov 28, 2024
View reviewed changes
Comment threadgoogle/api_core/client_logging.py
Comment threadgoogle/api_core/client_logging.py
@parthea
parthea merged commit d18d9b5 into mainDec 2, 2024
@parthea
parthea deleted the debug-logging branch December 2, 2024 11:12
@release-pleaserelease-pleaseBot mentioned this pull request Dec 2, 2024
Merged
This was referenced May 30, 2025
Closed
Closed
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers
@partheapartheaparthea approved these changes
@vchudnov-gvchudnov-gvchudnov-g approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@partheaparthea

Labels

size: lPull request size is large.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ohmayr@parthea@vchudnov-g