Uh oh!
There was an error while loading. Please reload this page.
feat: update recognized logging fields - #766
Conversation
| "httpRequestMethod", | ||
| "httpRequestUrl" "rpcName", |
There was a problem hiding this comment.
As per https://cloud.google.com/logging/docs/structured-logging#structured_logging_special_fields, httpRequest should be of type HttpRequest, which includes the fields requestMethod and requestURL internally.
| "httpRequestMethod", | |
| "httpRequestUrl""rpcName", | |
| "rpcName", |
9871f73 to
88bc82cCompare| "universeDomain", | ||
| "request", | ||
| "response", | ||
| "metadata", |
There was a problem hiding this comment.
Per the parent design doc, we should still have rpcName, right? (We're using it in the pending PR in the generator)
There was a problem hiding this comment.
Yes we should. I see it here it in the list. Let me know if you see otherwise.
There was a problem hiding this comment.
Oh, my bad. Don't know why I didn't see it before.
| "universeDomain", | ||
| "request", | ||
| "response", | ||
| "metadata", |
There was a problem hiding this comment.
Oh, my bad. Don't know why I didn't see it before.
No description provided.