Skip to content
This repository was archived by the owner on Feb 23, 2026. It is now read-only.

fix: use version.py instead of pkg_resources.get_distribution - #80

Merged
crwilcox merged 5 commits into
masterfrom
use-version-py
Oct 5, 2020
Merged

fix: use version.py instead of pkg_resources.get_distribution#80
crwilcox merged 5 commits into
masterfrom
use-version-py

Conversation

@crwilcox

@crwilcoxcrwilcox commented Oct 2, 2020

Copy link
Copy Markdown
Contributor

Related: #27

@crwilcox
crwilcox requested a review from a teamOctober 2, 2020 22:05
@google-clagoogle-claBot added the cla: yes This human has signed the Contributor License Agreement. label Oct 2, 2020

@andrewsgandrewsg left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Chris! Do we need to change release-please or any other tooling?

Comment threadgoogle/api_core/version.py Outdated
@crwilcox

Copy link
Copy Markdown
ContributorAuthor

@andrewsg already underway and part of next release-please release.

@crwilcox
crwilcox merged commit d480d97 into masterOct 5, 2020
@tseaver
tseaver deleted the use-version-py branch December 8, 2020 18:13
gcf-merge-on-greenBot pushed a commit to googleapis/google-auth-library-python that referenced this pull request Mar 16, 2021
Move the version from `setup.py` to `google/auth/version.py`. Same as googleapis/python-api-core#80. (see googleapis/python-api-core#27 for motivation). This is option 3 in https://packaging.python.org/guides/single-sourcing-package-version/.
This unblocks a version check I'd like to add in googleapis/python-api-core#134.
Usage:
```py
>>> import google.auth
>>> google.auth.__version__
'1.25.0'
```
This was referenced May 30, 2025
parthea pushed a commit to googleapis/google-cloud-python that referenced this pull request Nov 26, 2025
Move the version from `setup.py` to `google/auth/version.py`. Same as googleapis/python-api-core#80. (see googleapis/python-api-core#27 for motivation). This is option 3 in https://packaging.python.org/guides/single-sourcing-package-version/.
This unblocks a version check I'd like to add in googleapis/python-api-core#134.
Usage:
```py
>>> import google.auth
>>> google.auth.__version__
'1.25.0'
```
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla: yesThis human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@crwilcox@andrewsg