Skip to content
This repository was archived by the owner on Feb 23, 2026. It is now read-only.

fix: fix async tests and round-off error in test expectations - #837

Merged
vchudnov-g merged 3 commits into
mainfrom
version-support--check-main
Sep 4, 2025
Merged

fix: fix async tests and round-off error in test expectations#837
vchudnov-g merged 3 commits into
mainfrom
version-support--check-main

Conversation

@vchudnov-g

@vchudnov-gvchudnov-g commented Sep 4, 2025

Copy link
Copy Markdown
Contributor

Some test methods to test async functionality had @pytest.mark.asyncio but were not themselves designated as async methods. This led to warnings.

Some of the tests also started failing under Python 3.14 because the numeric comparisons were not exact. These changes makes those expectations be somewhat approximate.

@vchudnov-g
vchudnov-g requested review from a teamSeptember 4, 2025 19:50
@product-auto-labelproduct-auto-labelBot added the size: xs Pull request size is extra small. label Sep 4, 2025
@vchudnov-g
vchudnov-g marked this pull request as draft September 4, 2025 19:50
@vchudnov-g
vchudnov-gforce-pushed the version-support--check-main branch from fbbbab4 to 83c1491CompareSeptember 4, 2025 19:51
@vchudnov-g
vchudnov-gforce-pushed the version-support--check-main branch from 83c1491 to 6966a1aCompareSeptember 4, 2025 19:54
@product-auto-labelproduct-auto-labelBot added size: s Pull request size is small. and removed size: xs Pull request size is extra small. labels Sep 4, 2025
@vchudnov-gvchudnov-g changed the title fix: properly designate async test methodsfix: fix async testsSep 4, 2025
@vchudnov-gvchudnov-g changed the title fix: fix async testsfix: fix async tests and round-off error in test expectationsSep 4, 2025
@vchudnov-g
vchudnov-g marked this pull request as ready for review September 4, 2025 22:25
@vchudnov-g
vchudnov-g merged commit 14a5978 into mainSep 4, 2025
48 checks passed
@vchudnov-g
vchudnov-g deleted the version-support--check-main branch September 4, 2025 23:56
@release-pleaserelease-pleaseBot mentioned this pull request Sep 4, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

size: sPull request size is small.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@vchudnov-g@parthea@ohmayr