Skip to content

feat: add bigframes.bigquery.st_area and suggest it from GeoSeries.area - #1318

Merged
tswast merged 24 commits into
mainfrom
b308738592-geopandas-area
Feb 4, 2025
Merged

feat: add bigframes.bigquery.st_area and suggest it from GeoSeries.area#1318
tswast merged 24 commits into
mainfrom
b308738592-geopandas-area

Conversation

@arwas11

@arwas11arwas11 commented Jan 23, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)
    • area: screen/5SjGQsfX3K4mHpK
    • st_area: screen/7X3xcQcsp968m4a, screen/3LrwWASNt26Whoa, screen/6VUmo2GL6BDjFKA

Fixes #393394363 🦕

@product-auto-labelproduct-auto-labelBot added size: m Pull request size is medium. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels Jan 23, 2025
tswast
tswast reviewed Jan 27, 2025
View reviewed changes
Comment threadtests/system/small/geopandas/test_geoseries.py Outdated
tswast
tswast reviewed Feb 4, 2025
View reviewed changes
Comment threadthird_party/bigframes_vendored/geopandas/geoseries.py Outdated
tswast
tswast reviewed Feb 4, 2025
View reviewed changes
Comment threadbigframes/geopandas/geoseries.py Outdated
@review-notebook-app

review-notebook-appBot commented Feb 4, 2025

Copy link
Copy Markdown

Check out this pull request on ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@product-auto-labelproduct-auto-labelBot added size: l Pull request size is large. and removed size: m Pull request size is medium. labels Feb 4, 2025
@arwas11
arwas11 marked this pull request as ready for review February 4, 2025 17:36
@arwas11
arwas11 requested review from a teamFebruary 4, 2025 17:36
@arwas11
arwas11 requested a review from tswastFebruary 4, 2025 17:36
@tswasttswast changed the title feat: Add GeoSeries.areafeat: add bigframes.bigquery.st_area and suggest it from GeoSeries.areaFeb 4, 2025
arwas11
arwas11 commented Feb 4, 2025
View reviewed changes
Comment threadtests/system/small/bigquery/test_geo.py Outdated
arwas11
arwas11 commented Feb 4, 2025
View reviewed changes
Comment threadtests/system/small/bigquery/test_geo.py Outdated
tswast
tswast reviewed Feb 4, 2025
View reviewed changes
Comment threadtests/system/small/bigquery/test_geo.py
tswast
tswast reviewed Feb 4, 2025
View reviewed changes
Comment threadtests/system/small/bigquery/test_geo.py
@tswast
tswast enabled auto-merge (squash) February 4, 2025 20:31
@tswast
tswast disabled auto-merge February 4, 2025 21:18
@tswast

tswast commented Feb 4, 2025

Copy link
Copy Markdown
Collaborator

Failed doctests are

FAILED bigframes/session/__init__.py::bigframes.session.Session.read_gbq_function
FAILED bigframes/pandas/io/api.py::bigframes.pandas.io.api.read_gbq_function

which appears unrelated.

@tswast
tswast merged commit 8b5ffa8 into mainFeb 4, 2025
@tswast
tswast deleted the b308738592-geopandas-area branch February 4, 2025 21:19
@release-pleaserelease-pleaseBot mentioned this pull request Feb 4, 2025
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tswasttswasttswast approved these changes
@TrevorBergeronTrevorBergeronAwaiting requested review from TrevorBergeron

Assignees

@jiaxunwujiaxunwu

Labels

api: bigqueryIssues related to the googleapis/python-bigquery-dataframes API.size: lPull request size is large.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@arwas11@tswast@jiaxunwu