Skip to content

chore: remove discontinued sqlglot type attribute from the vendored ibis code - #1379

Merged
sycai merged 2 commits into
mainfrom
shobs-UNIQUEIDENTIFIER
Feb 10, 2025
Merged

chore: remove discontinued sqlglot type attribute from the vendored ibis code#1379
sycai merged 2 commits into
mainfrom
shobs-UNIQUEIDENTIFIER

Conversation

@shobsi

@shobsishobsi commented Feb 8, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

The type attribute UNIQUEIDENTIFIER has been removed in sqlglot head
tobymao/sqlglot@b12aba9#diff-7857fedd1d1451b1b9a5b8efaa1cc292c02e7ee4f0d04d7e2f9d5bfb9565802c which is causing unit_prerelease tests fail with AttributeError: type object 'Type' has no attribute 'UNIQUEIDENTIFIER':

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes internal issue 395193422 🦕

@shobsi
shobsi requested review from a team and TrevorBergeronFebruary 8, 2025 02:47
@product-auto-labelproduct-auto-labelBot added the size: xs Pull request size is extra small. label Feb 8, 2025
@product-auto-labelproduct-auto-labelBot added the api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. label Feb 8, 2025
@shobsishobsi changed the title chore: remove UNIQUEIDENTIFIER from the vendored ibis datatypeschore: remove discontinued sqlglot type attribute from the vendored ibis datatypesFeb 8, 2025
@shobsishobsi changed the title chore: remove discontinued sqlglot type attribute from the vendored ibis datatypeschore: remove discontinued sqlglot type attribute from the vendored ibis codeFeb 8, 2025
@sycai
sycai merged commit 24962cd into mainFeb 10, 2025
@sycai
sycai deleted the shobs-UNIQUEIDENTIFIER branch February 10, 2025 20:53
shuoweil pushed a commit that referenced this pull request Feb 10, 2025
@shobsi@shuoweil
removeUNIQUEIDENTIFIERfrom the vendored ibis datatypes (#1379)
2b79635
This type has been removed in sqlglot head
tobymao/sqlglot@b12aba9#diff-7857fedd1d1451b1b9a5b8efaa1cc292c02e7ee4f0d04d7e2f9d5bfb9565802c.
@hellowinhellowin mentioned this pull request Feb 11, 2025
Closed
@Genesis929Genesis929 mentioned this pull request Feb 11, 2025
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TrevorBergeronTrevorBergeronAwaiting requested review from TrevorBergeron
1 more reviewer
@sycaisycaisycai approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@arwas11arwas11

Labels

api: bigqueryIssues related to the googleapis/python-bigquery-dataframes API.size: xsPull request size is extra small.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@shobsi@sycai@arwas11