Skip to content

fix: Improve Series.replace for dict input - #907

Merged
shobsi merged 4 commits into
mainfrom
shobs-series-replace-empty-dict
Aug 26, 2024
Merged

fix: Improve Series.replace for dict input#907
shobsi merged 4 commits into
mainfrom
shobs-series-replace-empty-dict

Conversation

@shobsi

@shobsishobsi commented Aug 20, 2024

Copy link
Copy Markdown
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes internal issue 359980361 🦕

@shobsi
shobsi requested review from a team and mattyoplAugust 20, 2024 04:58
@product-auto-labelproduct-auto-labelBot added size: s Pull request size is small. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels Aug 20, 2024
@shobsi
shobsi merged commit 4208044 into mainAug 26, 2024
@shobsi
shobsi deleted the shobs-series-replace-empty-dict branch August 26, 2024 16:45
@release-pleaserelease-pleaseBot mentioned this pull request Aug 26, 2024
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mattyoplmattyoplAwaiting requested review from mattyopl
1 more reviewer
@TrevorBergeronTrevorBergeronTrevorBergeron approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@TrevorBergeronTrevorBergeron

Labels

api: bigqueryIssues related to the googleapis/python-bigquery-dataframes API.size: sPull request size is small.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@shobsi@TrevorBergeron