Skip to content

feat: support STRUCT data type with Series.struct.field to extract child fields - #71

Merged
gcf-merge-on-green[bot] merged 12 commits into
mainfrom
struct-accessor
Oct 3, 2023
Merged

feat: support STRUCT data type with Series.struct.field to extract child fields#71
gcf-merge-on-green[bot] merged 12 commits into
mainfrom
struct-accessor

Conversation

@tswast

@tswasttswast commented Sep 28, 2023•
edited
Loading

Copy link
Copy Markdown
Collaborator

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@product-auto-labelproduct-auto-labelBot added size: m Pull request size is medium. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels Sep 28, 2023
@product-auto-labelproduct-auto-labelBot added size: l Pull request size is large. and removed size: m Pull request size is medium. labels Sep 29, 2023
@tswast
tswast marked this pull request as ready for review October 2, 2023 15:58
@tswast
tswast requested review from a team and TrevorBergeronOctober 2, 2023 15:58
@tswasttswast changed the title feat: support STRUCT data type with Series.struct.field to extract …feat: support STRUCT data type with Series.struct.field to extract child fieldsOct 2, 2023
TrevorBergeron
TrevorBergeron reviewed Oct 2, 2023
View reviewed changes
Comment threadbigframes/dtypes.py Outdated

if ibis_dtype in IBIS_TO_ARROW:
return IBIS_TO_ARROW[ibis_dtype]
elif isinstance(ibis_dtype, ibis_dtypes.Null):

@TrevorBergeronTrevorBergeronOct 2, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you know how we might hit this case?

@tswasttswastOct 2, 2023

Copy link
Copy Markdown
CollaboratorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think it will, honestly. Can remove for now.

tswast
tswast commented Oct 2, 2023
View reviewed changes

@tswasttswast left a comment

Copy link
Copy Markdown
CollaboratorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove dead ibis null -> arrow check

@tswasttswast added the automerge Merge the pull request once unit tests and other checks pass. label Oct 3, 2023
@gcf-merge-on-green
gcf-merge-on-greenBot merged commit 17afac9 into mainOct 3, 2023
@gcf-merge-on-green
gcf-merge-on-greenBot deleted the struct-accessor branch October 3, 2023 21:04
@gcf-merge-on-greengcf-merge-on-greenBot removed the automerge Merge the pull request once unit tests and other checks pass. label Oct 3, 2023
@release-pleaserelease-pleaseBot mentioned this pull request Oct 3, 2023
Merged
@mattyoplmattyopl mentioned this pull request Aug 19, 2024
Merged
4 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@TrevorBergeronTrevorBergeronTrevorBergeron approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: bigqueryIssues related to the googleapis/python-bigquery-dataframes API.size: lPull request size is large.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tswast@TrevorBergeron