Uh oh!
There was an error while loading. Please reload this page.
This repository was archived by the owner on Mar 6, 2026. It is now read-only.
fix: validate opentelemetry span job attributes have values - #1327
Merged
Conversation
There are several job properties that are optional. Existing opentelemetry instrumentation disallows span attribute keys without appropriate values, so this change validates field presence before propagating.
shollyman
commented
Aug 25, 2022
ContributorAuthor
prerelease failures appear unrelated to this PR. |
shollyman
marked this pull request as ready for review
August 25, 2022 16:58
shollyman
requested review from
a team, aribray, chalmerlowe and prash-mi
and removed request for
prash-miAugust 25, 2022 16:58
parthea
approved these changes
Aug 27, 2022
parthea
commented
Aug 27, 2022
Contributor
I've opened googleapis/synthtool#1556 to fix the pre-release failures |
shollyman
commented
Aug 29, 2022
ContributorAuthor
Merging |
This was referenced Oct 4, 2022
abdelmegahedgoogle pushed a commit
to abdelmegahedgoogle/python-bigquery
that referenced
this pull request
Apr 17, 2023
…is#1327) fix: validate opentelemetry span job attributes have values There are several job properties that are optional. Existing opentelemetry instrumentation disallows span attribute keys without appropriate values, so this change validates field presence before propagating.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are several job properties that are optional. Existing
opentelemetry instrumentation disallows span attribute keys without
appropriate values, so this change validates value presence before
propagating.
Fixes: #1140