Skip to content
This repository was archived by the owner on Mar 6, 2026. It is now read-only.

Fix: Refactors code to account for a tdqm code deprecation - #1357

Merged
chalmerlowe merged 10 commits into
mainfrom
fix-tdqm-code-deprecation
Sep 19, 2022
Merged

Fix: Refactors code to account for a tdqm code deprecation#1357
chalmerlowe merged 10 commits into
mainfrom
fix-tdqm-code-deprecation

Conversation

@chalmerlowe

@chalmerlowechalmerlowe commented Sep 15, 2022

Copy link
Copy Markdown
Collaborator

tqdm has changed elements of their codebase and issued a deprecation warning. This change implements several refactors to account for those changes and mitigate the deprecation warning.

The tdqm library would issue the following deprecation warning:

```Please use tqdm.notebook.tqdm instead of `tqdm.tqdm_notebook


This PR:
* revises our code and tests to point at the new file/function
* alters the import statements accordingly
* accounts for potential differences in warnings that appear when errors happen in the tests
Fixes #1146 🦕

@chalmerlowe
chalmerlowe requested review from a team and loferrisSeptember 15, 2022 21:33
@product-auto-labelproduct-auto-labelBot added size: s Pull request size is small. api: bigquery Issues related to the googleapis/python-bigquery API. labels Sep 15, 2022
@chalmerlowechalmerlowe added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 19, 2022
@yoshi-kokoroyoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 19, 2022
@chalmerlowe
chalmerlowe merged commit 1369a9d into mainSep 19, 2022
@chalmerlowe
chalmerlowe deleted the fix-tdqm-code-deprecation branch September 19, 2022 21:18
@release-pleaserelease-pleaseBot mentioned this pull request Sep 19, 2022
Merged
@chalmerlowe

chalmerlowe commented Sep 21, 2022

Copy link
Copy Markdown
CollaboratorAuthor

Fixes #1146

This was referenced Oct 4, 2022
Closed
Closed
Closed
abdelmegahedgoogle pushed a commit to abdelmegahedgoogle/python-bigquery that referenced this pull request Apr 17, 2023
@chalmerlowe@gcf-owl-bot@abdelmegahedgoogle
Fix: Refactors code to account for a tdqm code deprecation (googleapi…
055104f
…s#1357)
* tests some options
* refactors to use tqdm.* notation
* refactors tqdm function calls to account for deprecation warning
* refactors _tqdm_helpers to account for tqdm deprecation warnings
* 🦉 Updates from OwlBot post-processor
See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md
* removes an extraneous reference to ipywidgets
* removes unneeded import
* removes import and fixes linting error
Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@loferrisloferrisAwaiting requested review from loferris
1 more reviewer
@dandhleedandhleedandhlee approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: bigqueryIssues related to the googleapis/python-bigquery API.size: sPull request size is small.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@chalmerlowe@dandhlee@yoshi-kokoro