Skip to content
This repository was archived by the owner on Mar 6, 2026. It is now read-only.

fix: raise most recent exception when not able to fetch query job after starting the job - #1362

Merged
chalmerlowe merged 6 commits into
mainfrom
tswast-b247809965
Jun 1, 2023
Merged

fix: raise most recent exception when not able to fetch query job after starting the job#1362
chalmerlowe merged 6 commits into
mainfrom
tswast-b247809965

Conversation

@tswast

@tswasttswast commented Sep 20, 2022

Copy link
Copy Markdown
Contributor

By raising the most recent exception, it's be clearer to customers and BigQuery backend engineers what the actual error is.

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Towards internal issue 247809965 🦕

@tswast
tswast requested review from a team and Neenu1995September 20, 2022 20:05
@product-auto-labelproduct-auto-labelBot added size: xs Pull request size is extra small. api: bigquery Issues related to the googleapis/python-bigquery API. labels Sep 20, 2022
@tswast

tswast commented Sep 20, 2022

Copy link
Copy Markdown
ContributorAuthor

@aribray@chalmerlowe This PR needs some unit test updates to look for the changed exception type. Please contribute by adding commits to this PR (or fork this PR if you prefer)

@aribrayaribray added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 20, 2022
@yoshi-kokoroyoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 20, 2022
@tswast
fix: raise most recent exception when not able to fetch query job aft…
ce7d358
…er starting the job
Towards internal issue 247809965
@tswast
tswast requested a review from a teamMay 24, 2023 15:01
@product-auto-labelproduct-auto-labelBot added size: s Pull request size is small. and removed size: xs Pull request size is extra small. labels Jun 1, 2023
@tswast
tswast requested review from chalmerlowe and removed request for Neenu1995June 1, 2023 15:28
chalmerlowe
chalmerlowe approved these changes Jun 1, 2023
View reviewed changes

@chalmerlowechalmerlowe left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chalmerlowe
chalmerlowe merged commit 09cc1df into mainJun 1, 2023
@chalmerlowe
chalmerlowe deleted the tswast-b247809965 branch June 1, 2023 16:10
@release-pleaserelease-pleaseBot mentioned this pull request Jun 1, 2023
Merged
This was referenced Jun 13, 2023
Closed
Closed
Closed
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
@chalmerlowechalmerlowechalmerlowe approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@chalmerlowechalmerlowe

Labels

api: bigqueryIssues related to the googleapis/python-bigquery API.size: sPull request size is small.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@tswast@chalmerlowe@yoshi-kokoro@aribray