Skip to content
This repository was archived by the owner on Mar 6, 2026. It is now read-only.

feat: add support for getting and setting table IAM policy - #144

Merged
tseaver merged 16 commits into
googleapis:masterfrom
steffnay:table-acl
Jul 30, 2020
Merged

feat: add support for getting and setting table IAM policy#144
tseaver merged 16 commits into
googleapis:masterfrom
steffnay:table-acl

Conversation

@steffnay

@steffnaysteffnay commented Jun 23, 2020•
edited
Loading

Copy link
Copy Markdown
Contributor

Adds support for interacting with IAM policies for BigQuery table resources.

  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

🦕

@googlebotgooglebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 23, 2020
@steffnay
steffnay requested a review from shollymanJune 23, 2020 03:41
@steffnaysteffnay changed the title Table aclfeat: adds support for getting and setting table IAM policyJul 13, 2020
@steffnaysteffnay added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 14, 2020
@yoshi-kokoroyoshi-kokoro removed kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Jul 14, 2020
@steffnay
steffnay marked this pull request as ready for review July 14, 2020 16:11
shollyman
shollyman reviewed Jul 14, 2020
View reviewed changes

@shollymanshollyman left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One thing that's missing here is the testIamPermissions implementation and accompanying. Is that going to be in a followup PR?

Comment threadgoogle/cloud/bigquery/iam.py Outdated
@shollyman

shollyman commented Jul 24, 2020

Copy link
Copy Markdown
Contributor

Testing is picking up unit test problems with pyarrow tests. Looks like they just jumped from 0.17.1 to 1.0, so possibly some more shenanigans afoot with changes there.

@shollyman

shollyman commented Jul 24, 2020

Copy link
Copy Markdown
Contributor

Given it's friday afternoon now, punting a release window on this until next week.

@shollyman

shollyman commented Jul 24, 2020

Copy link
Copy Markdown
Contributor

And ignore the previous two comments, I've been typing in the wrong PR

@steffnaysteffnay added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 28, 2020
@yoshi-kokoroyoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 28, 2020
@steffnay
steffnay requested a review from shollymanJuly 28, 2020 23:19
@tseavertseaver changed the title feat: adds support for getting and setting table IAM policyfeat: add support for getting and setting table IAM policyJul 29, 2020
tseaver
tseaver suggested changes Jul 29, 2020
View reviewed changes
Comment threadgoogle/cloud/bigquery/client.py Outdated
Comment threadgoogle/cloud/bigquery/client.py Outdated
Comment threadgoogle/cloud/bigquery/client.py Outdated
Comment threadgoogle/cloud/bigquery/client.py Outdated
Comment threadgoogle/cloud/bigquery/client.py Outdated
Comment threadgoogle/cloud/bigquery/client.py Outdated
Comment threadtests/system.py Outdated
Comment threadtests/unit/test_client.py
Comment threadtests/unit/test_client.py Outdated
@steffnaysteffnay added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 30, 2020
@yoshi-kokoroyoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 30, 2020
@tseaver
tseaver merged commit f59fc9a into googleapis:masterJul 30, 2020
@brandonjchoi

brandonjchoi commented Aug 17, 2020

Copy link
Copy Markdown

When will this be released @tseaver@shollyman ?

@release-pleaserelease-pleaseBot mentioned this pull request Jan 4, 2022
Closed
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@shollymanshollymanAwaiting requested review from shollyman
1 more reviewer
@tseavertseavertseaver approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yesThis human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@steffnay@shollyman@brandonjchoi@tseaver@googlebot@yoshi-kokoro