Skip to content
This repository was archived by the owner on Mar 6, 2026. It is now read-only.

feat: adding preserveAsciiControlCharacter to CSVOptions - #1491

Merged
chalmerlowe merged 6 commits into
googleapis:mainfrom
nayaknishant:main
Feb 15, 2023
Merged

feat: adding preserveAsciiControlCharacter to CSVOptions#1491
chalmerlowe merged 6 commits into
googleapis:mainfrom
nayaknishant:main

Conversation

@nayaknishant

@nayaknishantnayaknishant commented Feb 9, 2023

Copy link
Copy Markdown
Contributor

Fixes b/243699249 🦕

@nayaknishant
nayaknishant requested review from a team and Neenu1995February 9, 2023 01:28
@product-auto-labelproduct-auto-labelBot added size: s Pull request size is small. api: bigquery Issues related to the googleapis/python-bigquery API. labels Feb 9, 2023
@shollyman
shollyman requested review from chalmerlowe and removed request for Neenu1995February 13, 2023 23:34

@shollymanshollyman left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for putting this together!

@chalmerlowechalmerlowe left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chalmerlowe
chalmerlowe merged commit f832e7a into googleapis:mainFeb 15, 2023
@release-pleaserelease-pleaseBot mentioned this pull request Feb 15, 2023
abdelmegahedgoogle pushed a commit to abdelmegahedgoogle/python-bigquery that referenced this pull request Apr 17, 2023
…1491)
* adding ASCII support for external config
* adding tests for preserveAscii...
* adding tests for preserveAscii...
* changing 'False' to False
* linting
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: bigqueryIssues related to the googleapis/python-bigquery API.size: sPull request size is small.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@nayaknishant@shollyman@chalmerlowe