Uh oh!
There was an error while loading. Please reload this page.
fix: raise error if inserting rows with unknown fields - #163
Conversation
shollyman
left a comment
There was a problem hiding this comment.
I think I'm missing something here. The user controls whether they want this behavior in tabledata.insertall via ignoreUnknownValues, which is present in the insert_rows_json() method signature, but I don't see how that's plumbed to this helper.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
plamut
commented
Jul 17, 2020
@shollyman Hmm, good point. I'll check how the helper can support the |
plamut
commented
Jul 20, 2020
Changed the helper to include missing fields and let the backend handle that. The |
plamut
commented
Jul 20, 2020
Just the coverage failure it seems, will cover the missed code path. |
tseaver
commented
Jul 30, 2020
Assuming that the Python3 test failures in |
plamut
commented
Jul 31, 2020
Indeed, and those tests were updated in https://github.com/googleapis/python-bigquery/pull/192/files |
Fixes#151.
This PR makes sure that unknown fields are not silently ignored when inserting rows, but instead such errors are detected and raised loudly.
PR checklist