Skip to content
This repository was archived by the owner on Mar 6, 2026. It is now read-only.

feat: implementing Storage Billing model property to BQ Datasets - #1643

Merged
tswast merged 10 commits into
googleapis:mainfrom
sriramsridhar:physical_storage_property
Sep 15, 2023
Merged

feat: implementing Storage Billing model property to BQ Datasets#1643
tswast merged 10 commits into
googleapis:mainfrom
sriramsridhar:physical_storage_property

Conversation

@sriramsridhar

@sriramsridharsriramsridhar commented Aug 16, 2023

Copy link
Copy Markdown
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes Issue #1639 🦕

@sriramsridhar
sriramsridhar requested review from a team and obada-abAugust 16, 2023 07:59
@google-cla

Copy link
Copy Markdown

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@conventional-commit-lint-gcf

conventional-commit-lint-gcfBot commented Aug 16, 2023

Copy link
Copy Markdown

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@product-auto-labelproduct-auto-labelBot added size: s Pull request size is small. api: bigquery Issues related to the googleapis/python-bigquery API. labels Aug 16, 2023
@tswasttswast added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 16, 2023
@yoshi-kokoroyoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 16, 2023
@tswast

Copy link
Copy Markdown
Contributor

Thanks so much for the contribution @sriramsridhar !

@sriramsridhar

Copy link
Copy Markdown
ContributorAuthor

@obada-ab Please review this pr and share your comments

@sriramsridhar

Copy link
Copy Markdown
ContributorAuthor

@tswast Please merge this PR

@tswasttswast added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 5, 2023
@yoshi-kokoroyoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 5, 2023
Comment threadgoogle/cloud/bigquery/dataset.py Outdated
@storage_billing_model.setter
def storage_billing_model(self, value):
if not isinstance(value, str) and value is not None:
raise ValueError("Pass a string, or None")

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're missing some unit tests for some of these branches:

google/cloud/bigquery/dataset.py 352 2 81 3 99% 780, 781->783, 784

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any ETA on this ?

@SudoSpartanDan

Copy link
Copy Markdown

Is there an ETA on this feature? Our team is waiting on this to be able to set this attribute.

@product-auto-labelproduct-auto-labelBot added size: m Pull request size is medium. and removed size: s Pull request size is small. labels Sep 15, 2023
@tswast
tswast enabled auto-merge (squash) September 15, 2023 16:22
@tswasttswast added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Sep 15, 2023
@gcf-owl-botgcf-owl-botBot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 15, 2023
@yoshi-kokoroyoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 15, 2023
@tswast
tswast merged commit 5deba50 into googleapis:mainSep 15, 2023
@release-pleaserelease-pleaseBot mentioned this pull request Sep 15, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: bigqueryIssues related to the googleapis/python-bigquery API.size: mPull request size is medium.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@sriramsridhar@tswast@SudoSpartanDan@agonencyto@yoshi-kokoro