Skip to content
This repository was archived by the owner on Mar 6, 2026. It is now read-only.

fix: use isinstance() per E721, unpin flake8 - #1659

Merged
chalmerlowe merged 3 commits into
googleapis:mainfrom
Linchin:lint-error
Sep 18, 2023
Merged

fix: use isinstance() per E721, unpin flake8#1659
chalmerlowe merged 3 commits into
googleapis:mainfrom
Linchin:lint-error

Conversation

@Linchin

@LinchinLinchin commented Sep 16, 2023

Copy link
Copy Markdown
Contributor
  • Fixes lint error following E721
  • Unpins flake8==6.0.0 because error is resolved

Fixes#1635 🦕

@Linchin
Linchin requested review from a team and prash-miSeptember 16, 2023 01:03
@product-auto-labelproduct-auto-labelBot added size: xs Pull request size is extra small. api: bigquery Issues related to the googleapis/python-bigquery API. labels Sep 16, 2023
@LinchinLinchin added kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. and removed kokoro:run Add this label to force Kokoro to re-run the tests. labels Sep 18, 2023
@yoshi-kokoroyoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 18, 2023
chalmerlowe
chalmerlowe approved these changes Sep 18, 2023
View reviewed changes

@chalmerlowechalmerlowe left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chalmerlowe
chalmerlowe merged commit 54a7769 into googleapis:mainSep 18, 2023
@release-pleaserelease-pleaseBot mentioned this pull request Sep 18, 2023
Merged
@Linchin
Linchin deleted the lint-error branch September 18, 2023 22:19
@LinchinLinchin mentioned this pull request Sep 19, 2023
Merged
This was referenced Oct 10, 2023
Closed
Closed
Closed
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@prash-miprash-miAwaiting requested review from prash-mi
1 more reviewer
@chalmerlowechalmerlowechalmerlowe approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: bigqueryIssues related to the googleapis/python-bigquery API.size: xsPull request size is extra small.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Lint session fails with flake8==6.1.0

3 participants

@Linchin@chalmerlowe@yoshi-kokoro