Skip to content
This repository was archived by the owner on Mar 6, 2026. It is now read-only.

fix: augment universe_domain handling - #1837

Merged
Linchin merged 15 commits into
googleapis:mainfrom
shollyman:universe-validation
Mar 5, 2024
Merged

fix: augment universe_domain handling#1837
Linchin merged 15 commits into
googleapis:mainfrom
shollyman:universe-validation

Conversation

@shollyman

@shollymanshollyman commented Feb 29, 2024

Copy link
Copy Markdown
Contributor

This PR revisits the universe resolution for the BQ client, and handles
new requirements like env-based specification and validation.

@shollyman
fix: augment universe_domain handling
a1e3276
This PR revisits the universe resolution for the BQ client, and handles
new requirements like env-based specification and validation.
@shollyman
Merge branch 'main' into universe-validation
fa65569
@product-auto-labelproduct-auto-labelBot added size: m Pull request size is medium. api: bigquery Issues related to the googleapis/python-bigquery API. labels Feb 29, 2024
@shollymanshollyman added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 29, 2024
@yoshi-kokoroyoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 29, 2024
@shollyman
shollyman requested a review from LinchinMarch 4, 2024 22:13
@shollyman
shollyman marked this pull request as ready for review March 4, 2024 22:13
@shollyman
shollyman requested review from a teamMarch 4, 2024 22:13
Linchin
Linchin reviewed Mar 4, 2024
View reviewed changes
Comment threadgoogle/cloud/bigquery/_helpers.py
Linchin
Linchin reviewed Mar 4, 2024
View reviewed changes
Comment threadgoogle/cloud/bigquery/client.py Outdated
Linchin
Linchin reviewed Mar 4, 2024
View reviewed changes
Comment threadtests/unit/helpers.py
Linchin
Linchin reviewed Mar 4, 2024
View reviewed changes
Comment threadtests/unit/test__helpers.py Outdated
@LinchinLinchin added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 4, 2024
@yoshi-kokoroyoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 4, 2024
@Linchin

Linchin commented Mar 4, 2024

Copy link
Copy Markdown
Contributor

Thank you @shollyman! Overall it looks good, despite a new nitpicks.

@shollymanshollyman added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 5, 2024
@yoshi-kokoroyoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 5, 2024
@shollyman
shollyman requested a review from LinchinMarch 5, 2024 17:23
Linchin
Linchin approved these changes Mar 5, 2024
View reviewed changes

@LinchinLinchin left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you!

@Linchin
Linchin merged commit 53c2cbf into googleapis:mainMar 5, 2024
@release-pleaserelease-pleaseBot mentioned this pull request Mar 5, 2024
Merged
@shollyman
shollyman deleted the universe-validation branch March 5, 2024 17:58
This was referenced Mar 19, 2024
Closed
Closed
Closed
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
@LinchinLinchinLinchin approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: bigqueryIssues related to the googleapis/python-bigquery API.size: mPull request size is medium.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@shollyman@Linchin@yoshi-kokoro