Skip to content
This repository was archived by the owner on Mar 6, 2026. It is now read-only.

fix: correct type checking - #1848

Merged
gcf-merge-on-green[bot] merged 4 commits into
googleapis:mainfrom
Linchin:type-check-1838
Mar 11, 2024
Merged

fix: correct type checking#1848
gcf-merge-on-green[bot] merged 4 commits into
googleapis:mainfrom
Linchin:type-check-1838

Conversation

@Linchin

@LinchinLinchin commented Mar 8, 2024

Copy link
Copy Markdown
Contributor

Correct the way we check whether self._done_timeout is an instance of object class or not.

Fixes#1838 🦕

@Linchin
Linchin requested a review from chalmerloweMarch 8, 2024 22:34
@Linchin
Linchin requested review from a teamMarch 8, 2024 22:34
@product-auto-labelproduct-auto-labelBot added size: xs Pull request size is extra small. api: bigquery Issues related to the googleapis/python-bigquery API. labels Mar 8, 2024
chalmerlowe
chalmerlowe suggested changes Mar 11, 2024
View reviewed changes

@chalmerlowechalmerlowe left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment threadgoogle/cloud/bigquery/job/query.py Outdated
@chalmerlowechalmerlowe added the automerge Merge the pull request once unit tests and other checks pass. label Mar 11, 2024
chalmerlowe
chalmerlowe approved these changes Mar 11, 2024
View reviewed changes

@chalmerlowechalmerlowe left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gcf-merge-on-green
gcf-merge-on-greenBot merged commit 2660dbd into googleapis:mainMar 11, 2024
@gcf-merge-on-greengcf-merge-on-greenBot removed the automerge Merge the pull request once unit tests and other checks pass. label Mar 11, 2024
@release-pleaserelease-pleaseBot mentioned this pull request Mar 11, 2024
Merged
This was referenced Apr 2, 2024
Closed
Closed
Closed
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
@chalmerlowechalmerlowechalmerlowe approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@chalmerlowechalmerlowe

Labels

api: bigqueryIssues related to the googleapis/python-bigquery API.size: xsPull request size is extra small.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Bug introduced in v3.12.0

2 participants

@Linchin@chalmerlowe