Skip to content
This repository was archived by the owner on Mar 6, 2026. It is now read-only.

fix: use an allowlist instead of denylist to determine when query_and_wait uses jobs.query API - #1869

Merged
tswast merged 1 commit into
mainfrom
issue1867-query_and_wait-denylist
Mar 27, 2024
Merged

fix: use an allowlist instead of denylist to determine when query_and_wait uses jobs.query API#1869
tswast merged 1 commit into
mainfrom
issue1867-query_and_wait-denylist

Conversation

@tswast

@tswasttswast commented Mar 25, 2024

Copy link
Copy Markdown
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes#1867 🦕

@tswast
tswast requested review from a team and mrfaizalMarch 25, 2024 15:17
@product-auto-labelproduct-auto-labelBot added the size: m Pull request size is medium. label Mar 25, 2024
@tswast
tswast requested a review from chalmerloweMarch 25, 2024 15:17
@product-auto-labelproduct-auto-labelBot added the api: bigquery Issues related to the googleapis/python-bigquery API. label Mar 25, 2024
chalmerlowe
chalmerlowe approved these changes Mar 27, 2024
View reviewed changes

@chalmerlowechalmerlowe left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tswast
tswast merged commit e265db6 into mainMar 27, 2024
@tswast
tswast deleted the issue1867-query_and_wait-denylist branch March 27, 2024 14:58
@release-pleaserelease-pleaseBot mentioned this pull request Mar 22, 2024
Merged
This was referenced Apr 2, 2024
Closed
Closed
Closed
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@mrfaizalmrfaizalAwaiting requested review from mrfaizal
1 more reviewer
@chalmerlowechalmerlowechalmerlowe approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: bigqueryIssues related to the googleapis/python-bigquery API.size: mPull request size is medium.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

query_and_wait use in Cursor.execute breaks default_query_job_config in SQLAlchemy BQ Dialect

2 participants

@tswast@chalmerlowe