Uh oh!
There was an error while loading. Please reload this page.
fix: edit presubmit for to simplify configuration - #1915
Conversation
🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use -- conventional-commit-lint bot |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
chalmerlowe
commented
May 13, 2024
Using base names in the config file works fine. |
Uh oh!
There was an error while loading. Please reload this page.
shollyman
left a comment
There was a problem hiding this comment.
the title here seems out of sync with the changes, but I may be missing some context. It appears to simply be an update to the existing config, not a new one.
This creates a new cfg that could be used in place of the existing kokoro presubmit test.
The intent here is to avoid using variables to skip certain nox sessions and simply call the nox sessions that we want to execute. The benefit is that...because nox sessions create the virtual env before they execute the session steps, we end up needlessly creating virtual envs for sessions that we end up skipping when we reach the skip/not skip logic.