Skip to content
This repository was archived by the owner on Mar 6, 2026. It is now read-only.

feat: adds timer decorator to facilitate debugging - #1917

Merged
chalmerlowe merged 3 commits into
mainfrom
clowe-adds-timer-decorator
May 16, 2024
Merged

feat: adds timer decorator to facilitate debugging#1917
chalmerlowe merged 3 commits into
mainfrom
clowe-adds-timer-decorator

Conversation

@chalmerlowe

@chalmerlowechalmerlowe commented May 15, 2024

Copy link
Copy Markdown
Collaborator

This PR adds a calculation_duration function to figure out how long each of the nox sessions takes to complete.

This allows us to troubleshoot issues if a session seems to be taking longer than expected.

@chalmerlowe
chalmerlowe requested review from a team and LinchinMay 15, 2024 14:26
@product-auto-labelproduct-auto-labelBot added size: s Pull request size is small. api: bigquery Issues related to the googleapis/python-bigquery API. labels May 15, 2024
@chalmerlowechalmerlowe added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 15, 2024
@yoshi-kokoroyoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 15, 2024
@chalmerlowechalmerlowe added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 15, 2024
@yoshi-kokoroyoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 15, 2024
@chalmerlowechalmerlowe added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 15, 2024
@yoshi-kokoroyoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 15, 2024
shollyman
shollyman approved these changes May 15, 2024
View reviewed changes
Comment threadnoxfile.py
@chalmerlowe
chalmerlowe merged commit ea750e0 into mainMay 16, 2024
@chalmerlowe
chalmerlowe deleted the clowe-adds-timer-decorator branch May 16, 2024 12:02
@release-pleaserelease-pleaseBot mentioned this pull request May 16, 2024
Merged
This was referenced May 21, 2024
Closed
Closed
Closed
@tswast

tswast commented May 29, 2024

Copy link
Copy Markdown
Contributor

FYI: This showed up in the public release notes because of the use of feat: in the commit. chore: may have been more appropriate since users of google-cloud-bigquery shouldn't care about this change.

@chalmerlowe

chalmerlowe commented May 29, 2024

Copy link
Copy Markdown
CollaboratorAuthor

@tswast
I was unaware of the downstream effects of choosing feat: vs chore:. Thanks for this heads up.
Oops.
Will keep that in mind for the future.

CC: @Linchin

Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@LinchinLinchinAwaiting requested review from Linchin
1 more reviewer
@shollymanshollymanshollyman approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@leahecoleleahecole

Labels

api: bigqueryIssues related to the googleapis/python-bigquery API.size: sPull request size is small.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@chalmerlowe@tswast@shollyman@leahecole@yoshi-kokoro