Skip to content
This repository was archived by the owner on Mar 6, 2026. It is now read-only.

feat: add support for map target type in Parquet options - #1919

Merged
Linchin merged 7 commits into
googleapis:mainfrom
sclmn:patch-1
May 21, 2024
Merged

feat: add support for map target type in Parquet options#1919
Linchin merged 7 commits into
googleapis:mainfrom
sclmn:patch-1

Conversation

@sclmn

Copy link
Copy Markdown
Contributor

The map target type creates a schema without the added key_value repeated field.

The map target type creates a schema without the added key_value repeated field.
@sclmn
sclmn requested review from a team and shollymanMay 15, 2024 18:43
@product-auto-labelproduct-auto-labelBot added the size: s Pull request size is small. label May 15, 2024
@product-auto-labelproduct-auto-labelBot added the api: bigquery Issues related to the googleapis/python-bigquery API. label May 15, 2024
@Linchin

Copy link
Copy Markdown
Contributor

Thank you @sclmn for adding the new fields for us! We usually require 100% test coverage. Could you please also add unit tests for the new properties, similar to unit tests here? We also require the first commit and PR title to follow conventional commits. Could you follow the instruction in the link to update your PR? If you need any help with these, feel free to let us know :)

@LinchinLinchin assigned Linchin and unassigned chalmerloweMay 16, 2024
@sclmnsclmn changed the title Update format_options.py to include the newly added map target type.feat: add support for map target type in Parquet optionsMay 17, 2024
@conventional-commit-lint-gcf

Copy link
Copy Markdown

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@sclmn

Copy link
Copy Markdown
ContributorAuthor

I updated the PR. PTAL.

@LinchinLinchin added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 21, 2024
@yoshi-kokoroyoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 21, 2024
@LinchinLinchin added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 21, 2024
@yoshi-kokoroyoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 21, 2024
@LinchinLinchin added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 21, 2024
@yoshi-kokoroyoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 21, 2024
@Linchin
Linchin enabled auto-merge (squash) May 21, 2024 20:40
@LinchinLinchin added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 21, 2024
@yoshi-kokoroyoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 21, 2024
@Linchin
Linchin merged commit c3f7b23 into googleapis:mainMay 21, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: bigqueryIssues related to the googleapis/python-bigquery API.size: sPull request size is small.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@sclmn@Linchin@chalmerlowe@yoshi-kokoro