Uh oh!
There was an error while loading. Please reload this page.
fix: avoid blocking in download thread when using BQ Storage API - #2034
Conversation
256b0f7 to
3f8bd10Comparekien-truong
commented
Oct 24, 2024
Just dropping by to see if there's any concerns about this PR. |
This prevents a deadlock between the main thead and download threads when the threadpool is shutdown prematurely.
d3f2f1e to
8eebb9dComparechalmerlowe
commented
Nov 18, 2024
I took a quick look. |
kien-truong
commented
Nov 18, 2024
The So, I just put a |
tswast
commented
Feb 3, 2025
Looks like cover is passing. |
After sleeping on this, I do think it's important to try and cover the currently uncovered branch. I'll see what I can do in a follow-up PR today. Edit: mailed #2127 |
This prevents a deadlock between the main thead and download threads when the threadpool is shutdown prematurely.
Fixes#2032 🦕