Skip to content
This repository was archived by the owner on Mar 6, 2026. It is now read-only.

feat: migrate to pyproject.toml - #2041

Merged
chalmerlowe merged 7 commits into
googleapis:mainfrom
rinarakaki:pyproject
Nov 13, 2024
Merged

feat: migrate to pyproject.toml#2041
chalmerlowe merged 7 commits into
googleapis:mainfrom
rinarakaki:pyproject

Conversation

@rinarakaki

@rinarakakirinarakaki commented Oct 15, 2024

Copy link
Copy Markdown
Contributor

Tracking issue googleapis/google-cloud-python#13171

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@rinarakaki
rinarakaki requested review from a team and hongalexOctober 15, 2024 12:09
@conventional-commit-lint-gcf

conventional-commit-lint-gcfBot commented Oct 15, 2024

Copy link
Copy Markdown

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@product-auto-labelproduct-auto-labelBot added size: m Pull request size is medium. api: bigquery Issues related to the googleapis/python-bigquery API. labels Oct 15, 2024
@chalmerlowechalmerlowe added kokoro:run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Nov 11, 2024
@gcf-owl-botgcf-owl-botBot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Nov 11, 2024
@yoshi-kokoroyoshi-kokoro removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Nov 11, 2024
@chalmerlowechalmerlowe added the kokoro:run Add this label to force Kokoro to re-run the tests. label Nov 11, 2024
@yoshi-kokoroyoshi-kokoro removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Nov 11, 2024
@chalmerlowechalmerlowe added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 12, 2024
@yoshi-kokoroyoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 12, 2024
@chalmerlowechalmerlowe added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Nov 12, 2024
@gcf-owl-botgcf-owl-botBot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Nov 12, 2024
@yoshi-kokoroyoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 12, 2024
Comment threadpyproject.toml Outdated
@chalmerlowechalmerlowe added kokoro:run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Nov 13, 2024
@gcf-owl-botgcf-owl-botBot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Nov 13, 2024
@yoshi-kokoroyoshi-kokoro removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Nov 13, 2024

@chalmerlowechalmerlowe left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chalmerlowe
chalmerlowe merged commit 1061611 into googleapis:mainNov 13, 2024
@chalmerlowe

Copy link
Copy Markdown
Collaborator

@rinarakaki

Thank you for your assistance with converting this to pyproject.toml.

I am curious... you went through and offered up conversion PRs for a large number of google projects. What inspired this?

@release-pleaserelease-pleaseBot mentioned this pull request Nov 12, 2024
@rinarakaki
rinarakaki deleted the pyproject branch November 13, 2024 14:53
@rinarakaki

Copy link
Copy Markdown
ContributorAuthor

@chalmerlowe
Thanks for reviewing this PR!

For me, it was more about how to motivate/inspire the project maintainers to migrate to pyproject.toml, because this kind of problem (build systems) can only be solved in coordination with other projects, as they tend to rely on the common internal practices, standards and tooling. I use these libraries at work and want them to keep up with the latest Python standards and trends (including typing). pyproject.toml is a good first step towards modernising these Python projects, I believe.

@chalmerlowe

Copy link
Copy Markdown
Collaborator

@rinarakaki

That makes sense.
I manage:

  • python-bigquery
  • python-bigquery-pandas
  • python-bigquery-sqlalchemy
  • python-bigquery-storage
  • python-db-dtypes-pandas

and will be migrating all of these to pyproject.toml in the near future.

Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: bigqueryIssues related to the googleapis/python-bigquery API.size: mPull request size is medium.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@rinarakaki@chalmerlowe@whuffman36@yoshi-kokoro